[OPW,kernel] staging:dgnc:Removed unecessary error messages in dgnc_driver.c
diff mbox

Message ID 1381849204-4391-1-git-send-email-archanakumari959@gmail.com
State Changes Requested
Headers show

Commit Message

Archana kumari Oct. 15, 2013, 3 p.m. UTC
Fixed removal of unecessary error messages in staging:dgnc:dgnc_driver.c

Signed-off-by: Archana kumari <archanakumari959@gmail.com>
---
 drivers/staging/dgnc/dgnc_driver.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Andrew Grover Oct. 17, 2013, 10:12 p.m. UTC | #1
Hi, you can also remove the braces in the first conditional since it just
contains the return statement now.

-- Andy



On Tue, Oct 15, 2013 at 8:00 AM, Archana kumari
<archanakumari959@gmail.com>wrote:

> Fixed removal of unecessary error messages in staging:dgnc:dgnc_driver.c
>
> Signed-off-by: Archana kumari <archanakumari959@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_driver.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_driver.c
> b/drivers/staging/dgnc/dgnc_driver.c
> index 4271fa3..f282188 100644
> --- a/drivers/staging/dgnc/dgnc_driver.c
> +++ b/drivers/staging/dgnc/dgnc_driver.c
> @@ -489,7 +489,6 @@ static int dgnc_found_board(struct pci_dev *pdev, int
> id)
>         brd = dgnc_Board[dgnc_NumBoards] =
>                 kzalloc(sizeof(*brd), GFP_KERNEL);
>         if (!brd) {
> -               APR(("memory allocation for board structure failed\n"));
>                 return -ENOMEM;
>         }
>
> @@ -498,7 +497,6 @@ static int dgnc_found_board(struct pci_dev *pdev, int
> id)
>                 kzalloc(sizeof(u8) * 8192, GFP_KERNEL);
>         if (!brd->msgbuf) {
>                 kfree(brd);
> -               APR(("memory allocation for board msgbuf failed\n"));
>                 return -ENOMEM;
>         }
>
> --
> 1.8.1.2
>
> --
> You received this message because you are subscribed to the Google Groups
> "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

Patch
diff mbox

diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
index 4271fa3..f282188 100644
--- a/drivers/staging/dgnc/dgnc_driver.c
+++ b/drivers/staging/dgnc/dgnc_driver.c
@@ -489,7 +489,6 @@  static int dgnc_found_board(struct pci_dev *pdev, int id)
 	brd = dgnc_Board[dgnc_NumBoards] =
 		kzalloc(sizeof(*brd), GFP_KERNEL);
 	if (!brd) {
-		APR(("memory allocation for board structure failed\n"));
 		return -ENOMEM;
 	}
 
@@ -498,7 +497,6 @@  static int dgnc_found_board(struct pci_dev *pdev, int id)
 		kzalloc(sizeof(u8) * 8192, GFP_KERNEL);
 	if (!brd->msgbuf) {
 		kfree(brd);
-		APR(("memory allocation for board msgbuf failed\n"));
 		return -ENOMEM;
 	}