[OPW,kernel,1/2] Use #include <linux/io.h> instead of #include <asm/io.h>
diff mbox

Message ID 20131016074910.GA6149@TimeHacker
State Changes Requested
Headers show

Commit Message

Monam Agarwal Oct. 16, 2013, 7:49 a.m. UTC
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
---
 drivers/firmware/dcdbas.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

The driver compiles just fine with the linux header rather than the
asm one.

Comments

Josh Triplett Oct. 16, 2013, 8:05 a.m. UTC | #1
On Wed, Oct 16, 2013 at 01:19:10PM +0530, Monam Agarwal wrote:
> Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
> ---
>  drivers/firmware/dcdbas.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/dcdbas.c b/drivers/firmware/dcdbas.c
> index ff080ee..a567c05 100644
> --- a/drivers/firmware/dcdbas.c
> +++ b/drivers/firmware/dcdbas.c
> @@ -35,7 +35,7 @@
>  #include <linux/string.h>
>  #include <linux/types.h>
>  #include <linux/mutex.h>
> -#include <asm/io.h>
> +#include <linux/io.h>
>  
>  #include "dcdbas.h"
> 
> The driver compiles just fine with the linux header rather than the
> asm one.

This comment should be part of the commit message, not here at the
bottom of the patch.  (And you shouldn't be hand-editing such comments
into your mail; you should amend the actual commit, and then generate
the patch from that commit.)

- Josh Triplett

Patch
diff mbox

diff --git a/drivers/firmware/dcdbas.c b/drivers/firmware/dcdbas.c
index ff080ee..a567c05 100644
--- a/drivers/firmware/dcdbas.c
+++ b/drivers/firmware/dcdbas.c
@@ -35,7 +35,7 @@ 
 #include <linux/string.h>
 #include <linux/types.h>
 #include <linux/mutex.h>
-#include <asm/io.h>
+#include <linux/io.h>
 
 #include "dcdbas.h"