[OPW,kernel] Staging: sb105x: Removing space before tab
diff mbox

Message ID 20131017161148.GA5976@Ashvini
State Rejected
Headers show

Commit Message

Ashvini Varatharaj Oct. 17, 2013, 4:11 p.m. UTC
Fix checkpatch warning: WARNING: please, no space before tabs

Signed-off-by: Ashvini Varatharaj <ashvinivaratharaj@gmail.com>
---
 drivers/staging/sb105x/sb_mp_register.h |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
 create mode 100644 drivers/staging/sb105x/Module.symvers

Comments

Greg Kroah-Hartman Oct. 17, 2013, 4:27 p.m. UTC | #1
On Thu, Oct 17, 2013 at 09:41:48PM +0530, Ashvini Varatharaj wrote:
> Fix checkpatch warning: WARNING: please, no space before tabs
> 
> Signed-off-by: Ashvini Varatharaj <ashvinivaratharaj@gmail.com>
> ---
>  drivers/staging/sb105x/sb_mp_register.h |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>  create mode 100644 drivers/staging/sb105x/Module.symvers
> 
> diff --git a/drivers/staging/sb105x/Module.symvers b/drivers/staging/sb105x/Module.symvers
> new file mode 100644
> index 0000000..e69de29

This patch adds a zero-length file called
drivers/staging/sb105x/Module.symvers to the kernel tree.

Tricky if you don't notice it, see how the line above in the diffstat
says "create...".  When just doing a code cleanup, you should never have
a line like that, _unless_ you really are creating a new file.

As you don't seem to be responding to my requests for how you are
creating these patches in this odd manner, I guess another request will
be usless here as well...

greg k-h
Ashvini Varatharaj Oct. 17, 2013, 4:34 p.m. UTC | #2
Hey ,
Do you mean the steps of creating the patch?
First I see the error or warning by running checkpatch.pl. Then I make the
required changes. Then I build it using make command.And also run
checkpatch on that file. After that git add. Then, git commit -s -v . I
dont know why its creating a new file like that .:(

Patch
diff mbox

diff --git a/drivers/staging/sb105x/Module.symvers b/drivers/staging/sb105x/Module.symvers
new file mode 100644
index 0000000..e69de29
diff --git a/drivers/staging/sb105x/sb_mp_register.h b/drivers/staging/sb105x/sb_mp_register.h
index 16de497..3130f79 100644
--- a/drivers/staging/sb105x/sb_mp_register.h
+++ b/drivers/staging/sb105x/sb_mp_register.h
@@ -20,12 +20,12 @@ 
  */
 
 /* Device Information Register */
-#define MP_OPTR_DIR0		0x04 	/* port0 ~ port8 */
-#define MP_OPTR_DIR1		0x05 	/* port8 ~ port15 */
-#define MP_OPTR_DIR2		0x06 	/* port16 ~ port23 */
-#define MP_OPTR_DIR3		0x07 	/* port24 ~ port31 */
+#define MP_OPTR_DIR0		0x04	/* port0 ~ port8 */
+#define MP_OPTR_DIR1		0x05	/* port8 ~ port15 */
+#define MP_OPTR_DIR2		0x06	/* port16 ~ port23 */
+#define MP_OPTR_DIR3		0x07	/* port24 ~ port31 */
 
-#define DIR_UART_16C550 	0
+#define DIR_UART_16C550	0
 #define DIR_UART_16C1050	1
 #define DIR_UART_16C1050A	2