[OPW,kernel] staging: dgnc:Replaced deprecated EXTRA_CFLAGS in Makefile
diff mbox

Message ID 1382029017-7576-1-git-send-email-archanakumari959@gmail.com
State Changes Requested
Headers show

Commit Message

Archana kumari Oct. 17, 2013, 4:56 p.m. UTC
This patch fixes use of deprecated EXTRA_CFLAGS in
staging:dgnc:Makefile

Signed-off-by: Archana kumari <archanakumari959@gmail.com>
---
 drivers/staging/dgnc/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Greg Kroah-Hartman Oct. 17, 2013, 5:04 p.m. UTC | #1
On Thu, Oct 17, 2013 at 10:26:57PM +0530, Archana kumari wrote:
> This patch fixes use of deprecated EXTRA_CFLAGS in
> staging:dgnc:Makefile
> 
> Signed-off-by: Archana kumari <archanakumari959@gmail.com>
> ---
>  drivers/staging/dgnc/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/dgnc/Makefile b/drivers/staging/dgnc/Makefile
> index 888c433..65e327f 100644
> --- a/drivers/staging/dgnc/Makefile
> +++ b/drivers/staging/dgnc/Makefile
> @@ -1,4 +1,4 @@
> -EXTRA_CFLAGS += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"
> +ccflags-y += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"

The "correct" fix for this is to define these in the .c code, _if_ they
are still needed.  They can probably just be removed there, and then
this line in the Makefile can be removed as well.

Care to do that instead?

thanks,

greg k-h
Archana kumari Oct. 17, 2013, 5:12 p.m. UTC | #2
If i care to delete the Extra_flags in the c file and then from 
the makefile will this be okay?

thanks

Patch
diff mbox

diff --git a/drivers/staging/dgnc/Makefile b/drivers/staging/dgnc/Makefile
index 888c433..65e327f 100644
--- a/drivers/staging/dgnc/Makefile
+++ b/drivers/staging/dgnc/Makefile
@@ -1,4 +1,4 @@ 
-EXTRA_CFLAGS += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"
+ccflags-y += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"
 
 obj-$(CONFIG_DGNC) += dgnc.o