[OPW,kernel] staging: vt6655:use gfp_t instead of int in hostap.c
diff mbox

Message ID 1382035504-12378-1-git-send-email-archanakumari959@gmail.com
State Changes Requested
Headers show

Commit Message

Archana kumari Oct. 17, 2013, 6:45 p.m. UTC
This patch fixes the following type of sparse warnings:

drivers/staging/vt6655/hostap.c:733:42: warning: cast from restricted gfp_t
drivers/staging/vt6655/hostap.c:733:42: warning: incorrect type in argument 2 (different base types)
drivers/staging/vt6655/hostap.c:733:42:    expected restricted gfp_t [usertype] flags
drivers/staging/vt6655/hostap.c:733:42:    got int [signed] <noident>

Signed-off-by: Archana kumari <archanakumari959@gmail.com>
---
 drivers/staging/vt6655/hostap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Greg KH Oct. 17, 2013, 6:54 p.m. UTC | #1
On Fri, Oct 18, 2013 at 12:15:04AM +0530, Archana kumari wrote:
> This patch fixes the following type of sparse warnings:
> 
> drivers/staging/vt6655/hostap.c:733:42: warning: cast from restricted gfp_t
> drivers/staging/vt6655/hostap.c:733:42: warning: incorrect type in argument 2 (different base types)
> drivers/staging/vt6655/hostap.c:733:42:    expected restricted gfp_t [usertype] flags
> drivers/staging/vt6655/hostap.c:733:42:    got int [signed] <noident>
> 
> Signed-off-by: Archana kumari <archanakumari959@gmail.com>
> ---
>  drivers/staging/vt6655/hostap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6655/hostap.c b/drivers/staging/vt6655/hostap.c
> index fdd63b6..dbc95ce 100644
> --- a/drivers/staging/vt6655/hostap.c
> +++ b/drivers/staging/vt6655/hostap.c
> @@ -730,7 +730,7 @@ int vt6655_hostap_ioctl(PSDevice pDevice, struct iw_point *p)
>  	    p->length > VIAWGET_HOSTAPD_MAX_BUF_SIZE || !p->pointer)
>  		return -EINVAL;
>  
> -	param = kmalloc((int)p->length, (int)GFP_KERNEL);
> +	param = kmalloc((int)p->length, (gfp_t)GFP_KERNEL);

The cast should not be needed at all, right?  What happens if you remove
it?
Archana kumari Oct. 17, 2013, 7 p.m. UTC | #2
the vt6655 driver  worked fine without any casting ....i will resend the 
patch soon

thanks for your feedback Greg 

thanks
archana

Patch
diff mbox

diff --git a/drivers/staging/vt6655/hostap.c b/drivers/staging/vt6655/hostap.c
index fdd63b6..dbc95ce 100644
--- a/drivers/staging/vt6655/hostap.c
+++ b/drivers/staging/vt6655/hostap.c
@@ -730,7 +730,7 @@  int vt6655_hostap_ioctl(PSDevice pDevice, struct iw_point *p)
 	    p->length > VIAWGET_HOSTAPD_MAX_BUF_SIZE || !p->pointer)
 		return -EINVAL;
 
-	param = kmalloc((int)p->length, (int)GFP_KERNEL);
+	param = kmalloc((int)p->length, (gfp_t)GFP_KERNEL);
 	if (param == NULL)
 		return -ENOMEM;