[OPW,kernel,2/4] Staging: crystalhd: Make necessary changes due to removal of typedef in crystalhd_misc.c
diff mbox

Message ID 1a7e8480c080749fb911c6e581a51f2b5478180f.1382092572.git.rashika.kheria@gmail.com
State Rejected
Headers show

Commit Message

Rashika Oct. 18, 2013, 11:14 a.m. UTC
This patch updates the file crystalhd_misc.c to accomodate the removal
of typedef in crystalhd_misc.h

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
 drivers/staging/crystalhd/crystalhd_misc.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Waskiewicz Jr, Peter P Oct. 19, 2013, 2:08 a.m. UTC | #1
On Fri, 2013-10-18 at 16:44 +0530, Rashika Kheria wrote:
> This patch updates the file crystalhd_misc.c to accomodate the removal
> of typedef in crystalhd_misc.h
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>

> ---
>  drivers/staging/crystalhd/crystalhd_misc.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/crystalhd/crystalhd_misc.c b/drivers/staging/crystalhd/crystalhd_misc.c
> index 51f6980..4731ee3 100644
> --- a/drivers/staging/crystalhd/crystalhd_misc.c
> +++ b/drivers/staging/crystalhd/crystalhd_misc.c
> @@ -437,7 +437,8 @@ void bc_kern_dma_free(struct crystalhd_adp *adp, uint32_t sz, void *ka,
>   */
>  enum BC_STATUS crystalhd_create_dioq(struct crystalhd_adp *adp,
>  			      struct crystalhd_dioq **dioq_hnd,
> -			      crystalhd_data_free_cb cb, void *cbctx)
> +			      void (*cb)(void *context, void *data),
> +			      void *cbctx)
>  {
>  	struct crystalhd_dioq *dioq = NULL;
>  
> -- 
> 1.7.9.5
>
Greg KH Oct. 19, 2013, 9:41 p.m. UTC | #2
On Fri, Oct 18, 2013 at 04:44:57PM +0530, Rashika Kheria wrote:
> This patch updates the file crystalhd_misc.c to accomodate the removal
> of typedef in crystalhd_misc.h

Wait, you just broke the build on patch 1 and now are fixing it up here?
That's not ok, each patch must be self-contained and not break anything.

So, good thing I didn't try to apply your first patch :)

thanks,

greg k-h

Patch
diff mbox

diff --git a/drivers/staging/crystalhd/crystalhd_misc.c b/drivers/staging/crystalhd/crystalhd_misc.c
index 51f6980..4731ee3 100644
--- a/drivers/staging/crystalhd/crystalhd_misc.c
+++ b/drivers/staging/crystalhd/crystalhd_misc.c
@@ -437,7 +437,8 @@  void bc_kern_dma_free(struct crystalhd_adp *adp, uint32_t sz, void *ka,
  */
 enum BC_STATUS crystalhd_create_dioq(struct crystalhd_adp *adp,
 			      struct crystalhd_dioq **dioq_hnd,
-			      crystalhd_data_free_cb cb, void *cbctx)
+			      void (*cb)(void *context, void *data),
+			      void *cbctx)
 {
 	struct crystalhd_dioq *dioq = NULL;