From patchwork Fri Oct 18 18:26:29 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josef Bacik X-Patchwork-Id: 3069521 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B18D3BF924 for ; Fri, 18 Oct 2013 18:26:51 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 916242039F for ; Fri, 18 Oct 2013 18:26:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B0762039E for ; Fri, 18 Oct 2013 18:26:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756999Ab3JRS0q (ORCPT ); Fri, 18 Oct 2013 14:26:46 -0400 Received: from dkim1.fusionio.com ([66.114.96.53]:38374 "EHLO dkim1.fusionio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756970Ab3JRS0p (ORCPT ); Fri, 18 Oct 2013 14:26:45 -0400 Received: from mx1.fusionio.com (unknown [10.101.1.160]) by dkim1.fusionio.com (Postfix) with ESMTP id CB1747C0427 for ; Fri, 18 Oct 2013 12:26:44 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fusionio.com; s=default; t=1382120804; bh=dWXLpiXjCx2oCssJeWGvsaEOj+0RtnlwJxNwwtLnw50=; h=From:To:Subject:Date:In-Reply-To:References; b=pva0piGsKL9+4oEis/5efRmxGYWX5kwkLSQO1X/jtePCD1NfZo2hedvsZrYPyr3kb 0m3aBLk4SrIJ9omweLRfa4c43IpFHDpHrbwWwZ7wQZCxA67q9jvm+N0UMUnSo6NZ5D kbAus3mketulLq3W8we8oUiDVhPaMzE+yjO3Y6rk= X-ASG-Debug-ID: 1382120804-03d6a5194a139720001-6jHSXT Received: from CAS2.int.fusionio.com (cas2.int.fusionio.com [10.101.1.41]) by mx1.fusionio.com with ESMTP id DZU7VuVLdGhJB1DX (version=TLSv1 cipher=AES128-SHA bits=128 verify=NO); Fri, 18 Oct 2013 12:26:44 -0600 (MDT) X-Barracuda-Envelope-From: JBacik@fusionio.com Received: from localhost (10.101.1.160) by mail.fusionio.com (10.101.1.41) with Microsoft SMTP Server (TLS) id 14.3.158.1; Fri, 18 Oct 2013 12:26:43 -0600 From: Josef Bacik To: , Subject: [PATCH 7/8] xfstests: btrfs/017: add a regression test for snapshot creation Date: Fri, 18 Oct 2013 14:26:29 -0400 X-ASG-Orig-Subj: [PATCH 7/8] xfstests: btrfs/017: add a regression test for snapshot creation Message-ID: <1382120790-31060-7-git-send-email-jbacik@fusionio.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1382120790-31060-1-git-send-email-jbacik@fusionio.com> References: <1382120790-31060-1-git-send-email-jbacik@fusionio.com> MIME-Version: 1.0 X-Originating-IP: [10.101.1.160] X-Barracuda-Connect: cas2.int.fusionio.com[10.101.1.41] X-Barracuda-Start-Time: 1382120804 X-Barracuda-Encrypted: AES128-SHA X-Barracuda-URL: http://10.101.1.180:8000/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at fusionio.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.141571 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We had a regression where you couldn't snapshot a file system if you mounted it ro and then remounted it rw. This is a test that does just that to make sure we don't have this problem again. I ran the test without the fix and it blew up, and then applied the fix and verified that it passed. Thanks, Reviewed-by: Stefan Behrens Signed-off-by: Josef Bacik --- tests/btrfs/017 | 61 +++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/btrfs/017.out | 2 ++ tests/btrfs/group | 1 + 3 files changed, 64 insertions(+) create mode 100644 tests/btrfs/017 create mode 100644 tests/btrfs/017.out diff --git a/tests/btrfs/017 b/tests/btrfs/017 new file mode 100644 index 0000000..d45f32a --- /dev/null +++ b/tests/btrfs/017 @@ -0,0 +1,61 @@ +#! /bin/bash +# FS QA Test No. btrfs/017 +# +# Regression test to make sure we can create a snapshot after mounting with +# readonly and remounting rw. +# +#----------------------------------------------------------------------- +# Copyright (c) 2013 Fusion IO. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +# +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ + +status=1 # failure is the default! + +_cleanup() +{ + rm -f $tmp.* +} + +trap "_cleanup ; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# real QA test starts here +_supported_fs btrfs +_supported_os Linux +_require_scratch + +rm -f $seqres.full + +_scratch_mkfs > /dev/null 2>&1 +_scratch_mount -o ro +_scratch_mount -o rw,remount + +$BTRFS_UTIL_PROG sub snap $SCRATCH_MNT $SCRATCH_MNT/snap >> $seqres.full 2>&1 \ + || _fail "couldn't create snapshot" + +echo "Silence is golden" +status=0 ; exit diff --git a/tests/btrfs/017.out b/tests/btrfs/017.out new file mode 100644 index 0000000..8222844 --- /dev/null +++ b/tests/btrfs/017.out @@ -0,0 +1,2 @@ +QA output created by 017 +Silence is golden diff --git a/tests/btrfs/group b/tests/btrfs/group index 082fd67..be9476d 100644 --- a/tests/btrfs/group +++ b/tests/btrfs/group @@ -19,3 +19,4 @@ 014 auto 015 auto quick 016 auto quick +017 auto quick