[OPW,kernel,v1,2/3] staging: net: use netdev_warn instead of printk
diff mbox

Message ID 20131022132647.GA27075@fireworks
State Changes Requested
Headers show

Commit Message

Georgiana Rodica Chelu Oct. 22, 2013, 1:26 p.m. UTC
---
 drivers/net/wireless/adm8211.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Rusty Russell Oct. 24, 2013, 2:27 a.m. UTC | #1
Georgiana Rodica Chelu <georgiana.chelu93@gmail.com> writes:
> ---
>  drivers/net/wireless/adm8211.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Hi Georgiana,

Patch is fine, but you're missing a Signed-off-by line?

See Documentation/SubmittingPatches: 12) Sign your work

Thanks,
Rusty.

>
> diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c
> index 2086584..2b9f7a5 100644
> --- a/drivers/net/wireless/adm8211.c
> +++ b/drivers/net/wireless/adm8211.c
> @@ -169,12 +169,12 @@ static int adm8211_read_eeprom(struct ieee80211_hw *dev)
>  		else
>  			priv->bbp_type = ADM8211_TYPE_ADMTEK;
>  
> -		printk(KERN_WARNING "%s (adm8211): Unknown BBPtype: %d\n",
> -		       pci_name(priv->pdev), cr49 >> 3);
> +		netdev_warn(priv->pdev, "(adm8211): Unknown BBPtype: %d\n",
> +			    pci_name(priv->pdev), cr49 >> 3);
>  	}
>  
>  	if (priv->eeprom->country_code >= ARRAY_SIZE(cranges)) {
> -		printk(KERN_WARNING "%s (adm8211): Invalid country code (%d)\n",
> +		netdev_warn(priv->eeprom, "(adm8211): Invalid country code (%d)\n",
>  		       pci_name(priv->pdev), priv->eeprom->country_code);
>  
>  		chan_range = cranges[2];
> @@ -209,7 +209,7 @@ static int adm8211_read_eeprom(struct ieee80211_hw *dev)
>  		else
>  			priv->specific_bbptype = ADM8211_BBP_ADM8011;
>  
> -		printk(KERN_WARNING "%s (adm8211): Unknown specific BBP: %d\n",
> +		netdev_warn(priv->pdev, "(adm8211): Unknown specific BBP: %d\n",
>  		       pci_name(priv->pdev), priv->eeprom->specific_bbptype);
>  	}
>  
> @@ -230,7 +230,7 @@ static int adm8211_read_eeprom(struct ieee80211_hw *dev)
>  		else if (priv->pdev->revision == ADM8211_REV_AB)
>  			priv->transceiver_type = ADM8211_RFMD2948;
>  
> -		printk(KERN_WARNING "%s (adm8211): Unknown transceiver: %d\n",
> +		netdev_warn(priv->pdev, "(adm8211): Unknown transceiver: %d\n",
>  		       pci_name(priv->pdev), priv->eeprom->specific_rftype);
>  
>  		break;
> -- 
> 1.8.1.2
>
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

Patch
diff mbox

diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c
index 2086584..2b9f7a5 100644
--- a/drivers/net/wireless/adm8211.c
+++ b/drivers/net/wireless/adm8211.c
@@ -169,12 +169,12 @@  static int adm8211_read_eeprom(struct ieee80211_hw *dev)
 		else
 			priv->bbp_type = ADM8211_TYPE_ADMTEK;
 
-		printk(KERN_WARNING "%s (adm8211): Unknown BBPtype: %d\n",
-		       pci_name(priv->pdev), cr49 >> 3);
+		netdev_warn(priv->pdev, "(adm8211): Unknown BBPtype: %d\n",
+			    pci_name(priv->pdev), cr49 >> 3);
 	}
 
 	if (priv->eeprom->country_code >= ARRAY_SIZE(cranges)) {
-		printk(KERN_WARNING "%s (adm8211): Invalid country code (%d)\n",
+		netdev_warn(priv->eeprom, "(adm8211): Invalid country code (%d)\n",
 		       pci_name(priv->pdev), priv->eeprom->country_code);
 
 		chan_range = cranges[2];
@@ -209,7 +209,7 @@  static int adm8211_read_eeprom(struct ieee80211_hw *dev)
 		else
 			priv->specific_bbptype = ADM8211_BBP_ADM8011;
 
-		printk(KERN_WARNING "%s (adm8211): Unknown specific BBP: %d\n",
+		netdev_warn(priv->pdev, "(adm8211): Unknown specific BBP: %d\n",
 		       pci_name(priv->pdev), priv->eeprom->specific_bbptype);
 	}
 
@@ -230,7 +230,7 @@  static int adm8211_read_eeprom(struct ieee80211_hw *dev)
 		else if (priv->pdev->revision == ADM8211_REV_AB)
 			priv->transceiver_type = ADM8211_RFMD2948;
 
-		printk(KERN_WARNING "%s (adm8211): Unknown transceiver: %d\n",
+		netdev_warn(priv->pdev, "(adm8211): Unknown transceiver: %d\n",
 		       pci_name(priv->pdev), priv->eeprom->specific_rftype);
 
 		break;