[OPW,kernel] drivers:staging: remove warning space prohibited
diff mbox

Message ID 20131022140758.GA4240@himangi-Inspiron-N5110gmail.com
State Changes Requested
Headers show

Commit Message

HIMANGI SARAOGI Oct. 22, 2013, 2:07 p.m. UTC
There was a warning on running checkpatch.pl on theis file. To get rid
of the warning the extra spaces were eliminated.

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
---
 drivers/staging/lustre/lustre/osc/osc_io.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lisa Nguyen Oct. 22, 2013, 8:46 p.m. UTC | #1
On Tue, Oct 22, 2013 at 7:07 AM, Himangi Saraogi <himangi774@gmail.com> wrote:
> There was a warning on running checkpatch.pl on theis file. To get rid
> of the warning the extra spaces were eliminated.
>
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> ---

Couple suggestions:

1) Can you edit the subject to include the name of the driver you
worked on? (e.g. staging: lustre: <Description>)

2) It doesn't hurt to be clearer in your commit message. You can
either cut and paste the warning message you are trying to resolve or
simply state that you removed the space between the function name and
open parenthesis to meet kernel coding style.

Good first attempt though :)

-- Lisa


>  drivers/staging/lustre/lustre/osc/osc_io.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/osc/osc_io.c b/drivers/staging/lustre/lustre/osc/osc_io.c
> index 3aeaf84..681d60a 100644
> --- a/drivers/staging/lustre/lustre/osc/osc_io.c
> +++ b/drivers/staging/lustre/lustre/osc/osc_io.c
> @@ -105,7 +105,7 @@ static int osc_io_submit(const struct lu_env *env,
>         struct osc_object *osc  = NULL; /* to keep gcc happy */
>         struct osc_page   *opg;
>         struct cl_io      *io;
> -       LIST_HEAD     (list);
> +       LIST_HEAD(list);
>
>         struct cl_page_list *qin      = &queue->c2_qin;
>         struct cl_page_list *qout     = &queue->c2_qout;
> --
> 1.7.9.5
>
> --
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
HIMANGI SARAOGI Oct. 22, 2013, 9:51 p.m. UTC | #2
Thanks Lisa for the suggestions. I'll improve upon my
mistakes and would make the modifications soon.

Himangi Saraogi


On 23 October 2013 02:16, Lisa Nguyen <lisa@xenapiadmin.com> wrote:

> On Tue, Oct 22, 2013 at 7:07 AM, Himangi Saraogi <himangi774@gmail.com>
> wrote:
> > There was a warning on running checkpatch.pl on theis file. To get rid
> > of the warning the extra spaces were eliminated.
> >
> > Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> > ---
>
> Couple suggestions:
>
> 1) Can you edit the subject to include the name of the driver you
> worked on? (e.g. staging: lustre: <Description>)
>
> 2) It doesn't hurt to be clearer in your commit message. You can
> either cut and paste the warning message you are trying to resolve or
> simply state that you removed the space between the function name and
> open parenthesis to meet kernel coding style.
>
> Good first attempt though :)
>
> -- Lisa
>
>
> >  drivers/staging/lustre/lustre/osc/osc_io.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/lustre/lustre/osc/osc_io.c
> b/drivers/staging/lustre/lustre/osc/osc_io.c
> > index 3aeaf84..681d60a 100644
> > --- a/drivers/staging/lustre/lustre/osc/osc_io.c
> > +++ b/drivers/staging/lustre/lustre/osc/osc_io.c
> > @@ -105,7 +105,7 @@ static int osc_io_submit(const struct lu_env *env,
> >         struct osc_object *osc  = NULL; /* to keep gcc happy */
> >         struct osc_page   *opg;
> >         struct cl_io      *io;
> > -       LIST_HEAD     (list);
> > +       LIST_HEAD(list);
> >
> >         struct cl_page_list *qin      = &queue->c2_qin;
> >         struct cl_page_list *qout     = &queue->c2_qout;
> > --
> > 1.7.9.5
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "opw-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to opw-kernel+unsubscribe@googlegroups.com.
> > For more options, visit https://groups.google.com/groups/opt_out.
>

Patch
diff mbox

diff --git a/drivers/staging/lustre/lustre/osc/osc_io.c b/drivers/staging/lustre/lustre/osc/osc_io.c
index 3aeaf84..681d60a 100644
--- a/drivers/staging/lustre/lustre/osc/osc_io.c
+++ b/drivers/staging/lustre/lustre/osc/osc_io.c
@@ -105,7 +105,7 @@  static int osc_io_submit(const struct lu_env *env,
 	struct osc_object *osc  = NULL; /* to keep gcc happy */
 	struct osc_page   *opg;
 	struct cl_io      *io;
-	LIST_HEAD     (list);
+	LIST_HEAD(list);
 
 	struct cl_page_list *qin      = &queue->c2_qin;
 	struct cl_page_list *qout     = &queue->c2_qout;