[OPW,kernel,v1,3/3] This patch fixes this type of checkpatch warnings:
diff mbox

Message ID 20131022214741.GA15079@fireworks
State Changes Requested
Headers show

Commit Message

Georgiana Rodica Chelu Oct. 22, 2013, 9:47 p.m. UTC
WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then
pr_warn(...  to printk(KERN_WARNING ...

Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
---
 drivers/net/wireless/adm8211.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lisa Nguyen Oct. 23, 2013, 7:21 a.m. UTC | #1
On Tue, Oct 22, 2013 at 2:47 PM, Georgiana Rodica Chelu
<georgiana.chelu93@gmail.com> wrote:
> WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then
> pr_warn(...  to printk(KERN_WARNING ...
>
> Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>

Few things:

1) Can you edit your subject to be net: wireless: <brief description>?
In your case, it can be something like net: wireless: Replace printk
with netdev_warn in adm8211.c

2) FYI: Because you are outside of the staging subsystem (as we
*strongly* suggest for applicants to stay in as Greg is the staging
maintainer), you might have to run the get_maintainer script to get
the name of the network wireless maintainer and cc: the wireless
mailing lists to see if your patch will get accepted by them. However,
I will let Greg make the call on this.

3) I don't see the change you made from printk (as I see in my copy of
the original file) to netdev_warn in your patch? I see this:

> -               netdev_warn(dev->priv "(adm8211): Invalid hwaddr in EEPROM!\n",
> +               netdev_warn(dev->priv, "(adm8211): Invalid hwaddr in EEPROM!\n",

Which makes me think, at first glance, that you were fixing spacing
issues instead :(

Hope this helps,
Lisa

> ---
>  drivers/net/wireless/adm8211.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c
> index e1e66a1..be59beb 100644
> --- a/drivers/net/wireless/adm8211.c
> +++ b/drivers/net/wireless/adm8211.c
> @@ -1855,7 +1855,7 @@ static int adm8211_probe(struct pci_dev *pdev,
>                 cpu_to_le16(ADM8211_CSR_READ(PAR1) & 0xFFFF);
>
>         if (!is_valid_ether_addr(perm_addr)) {
> -               netdev_warn(dev->priv "(adm8211): Invalid hwaddr in EEPROM!\n",
> +               netdev_warn(dev->priv, "(adm8211): Invalid hwaddr in EEPROM!\n",
>                        pci_name(pdev));
>                 eth_random_addr(perm_addr);
>         }
> --
> 1.8.1.2
>
> --
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

Patch
diff mbox

diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c
index e1e66a1..be59beb 100644
--- a/drivers/net/wireless/adm8211.c
+++ b/drivers/net/wireless/adm8211.c
@@ -1855,7 +1855,7 @@  static int adm8211_probe(struct pci_dev *pdev,
 		cpu_to_le16(ADM8211_CSR_READ(PAR1) & 0xFFFF);
 
 	if (!is_valid_ether_addr(perm_addr)) {
-		netdev_warn(dev->priv "(adm8211): Invalid hwaddr in EEPROM!\n",
+		netdev_warn(dev->priv, "(adm8211): Invalid hwaddr in EEPROM!\n",
 		       pci_name(pdev));
 		eth_random_addr(perm_addr);
 	}