[OPW,kernel] Staging: vt6655: Fix Sparse Warning for Static Declarations in tkip.c
diff mbox

Message ID 1382568175-13801-1-git-send-email-ebru.akagunduz@gmail.com
State Accepted
Headers show

Commit Message

Ebru Akagündüz Oct. 23, 2013, 10:42 p.m. UTC
This patch fixes the Sparse Warning "symbol was
not declared. Should it be static?" in tkip.c

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
---
 drivers/staging/vt6655/tkip.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Rusty Russell Oct. 24, 2013, 2:51 a.m. UTC | #1
Ebru Akagunduz <ebru.akagunduz@gmail.com> writes:

> This patch fixes the Sparse Warning "symbol was
> not declared. Should it be static?" in tkip.c
>
> Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>

Reviewed-By: Rusty Russell <rusty@rustcorp.com.au>

Cheers,
Rusty.

> ---
>  drivers/staging/vt6655/tkip.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vt6655/tkip.c b/drivers/staging/vt6655/tkip.c
> index b3e087e..e7c17c6 100644
> --- a/drivers/staging/vt6655/tkip.c
> +++ b/drivers/staging/vt6655/tkip.c
> @@ -55,7 +55,7 @@
>  /* The 2nd table is the same as the 1st but with the upper and lower   */
>  /* bytes swapped. To allow an endian tolerant implementation, the byte */
>  /* halves have been expressed independently here.                      */
> -const unsigned char TKIP_Sbox_Lower[256] = {
> +static const unsigned char TKIP_Sbox_Lower[256] = {
>  	0xA5, 0x84, 0x99, 0x8D, 0x0D, 0xBD, 0xB1, 0x54,
>  	0x50, 0x03, 0xA9, 0x7D, 0x19, 0x62, 0xE6, 0x9A,
>  	0x45, 0x9D, 0x40, 0x87, 0x15, 0xEB, 0xC9, 0x0B,
> @@ -90,7 +90,7 @@ const unsigned char TKIP_Sbox_Lower[256] = {
>  	0xC3, 0xB0, 0x77, 0x11, 0xCB, 0xFC, 0xD6, 0x3A
>  };
>  
> -const unsigned char TKIP_Sbox_Upper[256] = {
> +static const unsigned char TKIP_Sbox_Upper[256] = {
>  	0xC6, 0xF8, 0xEE, 0xF6, 0xFF, 0xD6, 0xDE, 0x91,
>  	0x60, 0x02, 0xCE, 0x56, 0xE7, 0xB5, 0x4D, 0xEC,
>  	0x8F, 0x1F, 0x89, 0xFA, 0xEF, 0xB2, 0x8E, 0xFB,
> -- 
> 1.8.1.2
>
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

Patch
diff mbox

diff --git a/drivers/staging/vt6655/tkip.c b/drivers/staging/vt6655/tkip.c
index b3e087e..e7c17c6 100644
--- a/drivers/staging/vt6655/tkip.c
+++ b/drivers/staging/vt6655/tkip.c
@@ -55,7 +55,7 @@ 
 /* The 2nd table is the same as the 1st but with the upper and lower   */
 /* bytes swapped. To allow an endian tolerant implementation, the byte */
 /* halves have been expressed independently here.                      */
-const unsigned char TKIP_Sbox_Lower[256] = {
+static const unsigned char TKIP_Sbox_Lower[256] = {
 	0xA5, 0x84, 0x99, 0x8D, 0x0D, 0xBD, 0xB1, 0x54,
 	0x50, 0x03, 0xA9, 0x7D, 0x19, 0x62, 0xE6, 0x9A,
 	0x45, 0x9D, 0x40, 0x87, 0x15, 0xEB, 0xC9, 0x0B,
@@ -90,7 +90,7 @@  const unsigned char TKIP_Sbox_Lower[256] = {
 	0xC3, 0xB0, 0x77, 0x11, 0xCB, 0xFC, 0xD6, 0x3A
 };
 
-const unsigned char TKIP_Sbox_Upper[256] = {
+static const unsigned char TKIP_Sbox_Upper[256] = {
 	0xC6, 0xF8, 0xEE, 0xF6, 0xFF, 0xD6, 0xDE, 0x91,
 	0x60, 0x02, 0xCE, 0x56, 0xE7, 0xB5, 0x4D, 0xEC,
 	0x8F, 0x1F, 0x89, 0xFA, 0xEF, 0xB2, 0x8E, 0xFB,