[OPW,kernel,v4] Staging: slicoss: Replace seq_printf with seq_puts
diff mbox

Message ID 1382613987-16736-1-git-send-email-rashika.kheria@gmail.com
State Accepted
Headers show

Commit Message

Rashika Oct. 24, 2013, 11:26 a.m. UTC
This patch fixes the following checkpatch.pl warning in slicoss.c:
WARNING: Prefer seq_puts to seq_printf 

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---

This revision fixes the following issues of the previous revision-
Unnecessary replacement of seq_printf() by seq_puts() 

 drivers/staging/slicoss/slicoss.c |   20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

Comments

Josh Triplett Oct. 24, 2013, 12:32 p.m. UTC | #1
On Thu, Oct 24, 2013 at 04:56:27PM +0530, Rashika Kheria wrote:
> This patch fixes the following checkpatch.pl warning in slicoss.c:
> WARNING: Prefer seq_puts to seq_printf 
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> ---
> 
> This revision fixes the following issues of the previous revision-
> Unnecessary replacement of seq_printf() by seq_puts() 
> 
>  drivers/staging/slicoss/slicoss.c |   20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> index 8b5490b..652272b 100644
> --- a/drivers/staging/slicoss/slicoss.c
> +++ b/drivers/staging/slicoss/slicoss.c
> @@ -1835,7 +1835,7 @@ static int slic_debug_card_show(struct seq_file *seq, void *v)
>  #endif
>  
>  	seq_printf(seq, "driver_version           : %s\n", slic_proc_version);
> -	seq_printf(seq, "Microcode versions:           \n");
> +	seq_puts(seq, "Microcode versions:           \n");
>  	seq_printf(seq, "    Gigabit (gb)         : %s %s\n",
>  		    MOJAVE_UCODE_VERS_STRING, MOJAVE_UCODE_VERS_DATE);
>  	seq_printf(seq, "    Gigabit Receiver     : %s %s\n",
> @@ -1866,8 +1866,8 @@ static int slic_debug_card_show(struct seq_file *seq, void *v)
>  			   config->macinfo[i].macaddrA[4],
>  			   config->macinfo[i].macaddrA[5]);
>  	}
> -	seq_printf(seq, "     IF  Init State Duplex/Speed irq\n");
> -	seq_printf(seq, "     -------------------------------\n");
> +	seq_puts(seq, "     IF  Init State Duplex/Speed irq\n");
> +	seq_puts(seq, "     -------------------------------\n");
>  	for (i = 0; i < card->adapters_allocated; i++) {
>  		struct adapter *adapter;
>  
> @@ -1910,7 +1910,7 @@ static int slic_debug_card_show(struct seq_file *seq, void *v)
>  	switch (config->FruFormat) {
>  	case ATK_FRU_FORMAT:
>  		{
> -			seq_printf(seq,
> +			seq_puts(seq,
>  			    "Vendor                   : Alacritech, Inc.\n");
>  			seq_printf(seq,
>  			    "Assembly #               : %c%c%c%c%c%c\n",
> @@ -1943,9 +1943,9 @@ static int slic_debug_card_show(struct seq_file *seq, void *v)
>  
>  	default:
>  		{
> -			seq_printf(seq,
> +			seq_puts(seq,
>  			    "Vendor                   : Alacritech, Inc.\n");
> -			seq_printf(seq,
> +			seq_puts(seq,
>  			    "Serial   #               : Empty FRU\n");
>  			break;
>  		}
> @@ -1954,7 +1954,7 @@ static int slic_debug_card_show(struct seq_file *seq, void *v)
>  	switch (config->OEMFruFormat) {
>  	case VENDOR1_FRU_FORMAT:
>  		{
> -			seq_printf(seq, "FRU Information:\n");
> +			seq_puts(seq, "FRU Information:\n");
>  			seq_printf(seq, "    Commodity #          : %c\n",
>  				    oemfru[0]);
>  			seq_printf(seq,
> @@ -1977,7 +1977,7 @@ static int slic_debug_card_show(struct seq_file *seq, void *v)
>  
>  	case VENDOR2_FRU_FORMAT:
>  		{
> -			seq_printf(seq, "FRU Information:\n");
> +			seq_puts(seq, "FRU Information:\n");
>  			seq_printf(seq,
>  				    "    Part     #           : "
>  				    "%c%c%c%c%c%c%c%c\n",
> @@ -2000,12 +2000,12 @@ static int slic_debug_card_show(struct seq_file *seq, void *v)
>  
>  	case VENDOR3_FRU_FORMAT:
>  		{
> -			seq_printf(seq, "FRU Information:\n");
> +			seq_puts(seq, "FRU Information:\n");
>  		}
>  
>  	case VENDOR4_FRU_FORMAT:
>  		{
> -			seq_printf(seq, "FRU Information:\n");
> +			seq_puts(seq, "FRU Information:\n");
>  			seq_printf(seq,
>  				    "    FRU Number           : "
>  				    "%c%c%c%c%c%c%c%c\n",
> -- 
> 1.7.9.5
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

Patch
diff mbox

diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index 8b5490b..652272b 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -1835,7 +1835,7 @@  static int slic_debug_card_show(struct seq_file *seq, void *v)
 #endif
 
 	seq_printf(seq, "driver_version           : %s\n", slic_proc_version);
-	seq_printf(seq, "Microcode versions:           \n");
+	seq_puts(seq, "Microcode versions:           \n");
 	seq_printf(seq, "    Gigabit (gb)         : %s %s\n",
 		    MOJAVE_UCODE_VERS_STRING, MOJAVE_UCODE_VERS_DATE);
 	seq_printf(seq, "    Gigabit Receiver     : %s %s\n",
@@ -1866,8 +1866,8 @@  static int slic_debug_card_show(struct seq_file *seq, void *v)
 			   config->macinfo[i].macaddrA[4],
 			   config->macinfo[i].macaddrA[5]);
 	}
-	seq_printf(seq, "     IF  Init State Duplex/Speed irq\n");
-	seq_printf(seq, "     -------------------------------\n");
+	seq_puts(seq, "     IF  Init State Duplex/Speed irq\n");
+	seq_puts(seq, "     -------------------------------\n");
 	for (i = 0; i < card->adapters_allocated; i++) {
 		struct adapter *adapter;
 
@@ -1910,7 +1910,7 @@  static int slic_debug_card_show(struct seq_file *seq, void *v)
 	switch (config->FruFormat) {
 	case ATK_FRU_FORMAT:
 		{
-			seq_printf(seq,
+			seq_puts(seq,
 			    "Vendor                   : Alacritech, Inc.\n");
 			seq_printf(seq,
 			    "Assembly #               : %c%c%c%c%c%c\n",
@@ -1943,9 +1943,9 @@  static int slic_debug_card_show(struct seq_file *seq, void *v)
 
 	default:
 		{
-			seq_printf(seq,
+			seq_puts(seq,
 			    "Vendor                   : Alacritech, Inc.\n");
-			seq_printf(seq,
+			seq_puts(seq,
 			    "Serial   #               : Empty FRU\n");
 			break;
 		}
@@ -1954,7 +1954,7 @@  static int slic_debug_card_show(struct seq_file *seq, void *v)
 	switch (config->OEMFruFormat) {
 	case VENDOR1_FRU_FORMAT:
 		{
-			seq_printf(seq, "FRU Information:\n");
+			seq_puts(seq, "FRU Information:\n");
 			seq_printf(seq, "    Commodity #          : %c\n",
 				    oemfru[0]);
 			seq_printf(seq,
@@ -1977,7 +1977,7 @@  static int slic_debug_card_show(struct seq_file *seq, void *v)
 
 	case VENDOR2_FRU_FORMAT:
 		{
-			seq_printf(seq, "FRU Information:\n");
+			seq_puts(seq, "FRU Information:\n");
 			seq_printf(seq,
 				    "    Part     #           : "
 				    "%c%c%c%c%c%c%c%c\n",
@@ -2000,12 +2000,12 @@  static int slic_debug_card_show(struct seq_file *seq, void *v)
 
 	case VENDOR3_FRU_FORMAT:
 		{
-			seq_printf(seq, "FRU Information:\n");
+			seq_puts(seq, "FRU Information:\n");
 		}
 
 	case VENDOR4_FRU_FORMAT:
 		{
-			seq_printf(seq, "FRU Information:\n");
+			seq_puts(seq, "FRU Information:\n");
 			seq_printf(seq,
 				    "    FRU Number           : "
 				    "%c%c%c%c%c%c%c%c\n",