[OPW,kernel,2/5] Staging: lustre: Fix EXPORT_SYMBOL should immediately follow its function/variable
diff mbox

Message ID b6fbdcd161f3732b3778e07f9280f14b75e4d8e0.1382622886.git.rashika.kheria@gmail.com
State Accepted
Headers show

Commit Message

Rashika Oct. 24, 2013, 1:57 p.m. UTC
This patch fixes the following checkpatch.pl issues in lnet/lnet/acceptor.c:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
 drivers/staging/lustre/lnet/lnet/acceptor.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Lisa Nguyen Oct. 25, 2013, 6:03 a.m. UTC | #1
On Thu, Oct 24, 2013 at 6:57 AM, Rashika Kheria
<rashika.kheria@gmail.com> wrote:
> This patch fixes the following checkpatch.pl issues in lnet/lnet/acceptor.c:
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Assuming that it has been compile tested...

Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>

> ---
>  drivers/staging/lustre/lnet/lnet/acceptor.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/lustre/lnet/lnet/acceptor.c b/drivers/staging/lustre/lnet/lnet/acceptor.c
> index 27c1fdf..0fee292 100644
> --- a/drivers/staging/lustre/lnet/lnet/acceptor.c
> +++ b/drivers/staging/lustre/lnet/lnet/acceptor.c
> @@ -53,6 +53,7 @@ lnet_acceptor_port(void)
>  {
>         return accept_port;
>  }
> +EXPORT_SYMBOL(lnet_acceptor_port);
>
>  static inline int
>  lnet_accept_magic(__u32 magic, __u32 constant)
> @@ -61,9 +62,6 @@ lnet_accept_magic(__u32 magic, __u32 constant)
>                 magic == __swab32(constant));
>  }
>
> -
> -EXPORT_SYMBOL(lnet_acceptor_port);
> -
>  static char *accept = "secure";
>
>  CFS_MODULE_PARM(accept, "s", charp, 0444,
> --
> 1.7.9.5
>
> --
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

Patch
diff mbox

diff --git a/drivers/staging/lustre/lnet/lnet/acceptor.c b/drivers/staging/lustre/lnet/lnet/acceptor.c
index 27c1fdf..0fee292 100644
--- a/drivers/staging/lustre/lnet/lnet/acceptor.c
+++ b/drivers/staging/lustre/lnet/lnet/acceptor.c
@@ -53,6 +53,7 @@  lnet_acceptor_port(void)
 {
 	return accept_port;
 }
+EXPORT_SYMBOL(lnet_acceptor_port);
 
 static inline int
 lnet_accept_magic(__u32 magic, __u32 constant)
@@ -61,9 +62,6 @@  lnet_accept_magic(__u32 magic, __u32 constant)
 		magic == __swab32(constant));
 }
 
-
-EXPORT_SYMBOL(lnet_acceptor_port);
-
 static char *accept = "secure";
 
 CFS_MODULE_PARM(accept, "s", charp, 0444,