[OPW,kernel,2/2] staging: lustre: replaced C99 comment style by C89 style
diff mbox

Message ID 1382637978-9995-2-git-send-email-nandu.hgowda@gmail.com
State Accepted
Headers show

Commit Message

nandini h Oct. 24, 2013, 6:06 p.m. UTC
As per coding style guidelines C89 comment style /*...*/
is preferred over C99 comment style //, hence replaced
C99 comment style by C89 comment style to fix checkpatch
error

Signed-off-by: Nandini Hanumanthagowda <nandu.hgowda@gmail.com>
---
 drivers/staging/lustre/lustre/lvfs/lvfs_linux.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rusty Russell Oct. 25, 2013, 12:29 a.m. UTC | #1
Nandini Hanumanthagowda <nandu.hgowda@gmail.com> writes:
> As per coding style guidelines C89 comment style /*...*/
> is preferred over C99 comment style //, hence replaced
> C99 comment style by C89 comment style to fix checkpatch
> error

Hmm... A commented-out assertion always makes me wonder.  But it's
better to leave it for others to wonder about than delete it, I guess.

Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>

Cheers,
Rusty.

> Signed-off-by: Nandini Hanumanthagowda <nandu.hgowda@gmail.com>
> ---
>  drivers/staging/lustre/lustre/lvfs/lvfs_linux.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/lvfs/lvfs_linux.c b/drivers/staging/lustre/lustre/lvfs/lvfs_linux.c
> index bb8b152..1ef06fe 100644
> --- a/drivers/staging/lustre/lustre/lvfs/lvfs_linux.c
> +++ b/drivers/staging/lustre/lustre/lvfs/lvfs_linux.c
> @@ -114,7 +114,7 @@ void push_ctxt(struct lvfs_run_ctxt *save, struct lvfs_run_ctxt *new_ctx,
>  	if (new_ctx->dt != NULL)
>  		return;
>  
> -	//ASSERT_NOT_KERNEL_CTXT("already in kernel context!\n");
> +	/* ASSERT_NOT_KERNEL_CTXT("already in kernel context!\n"); */
>  	ASSERT_CTXT_MAGIC(new_ctx->magic);
>  	OBD_SET_CTXT_MAGIC(save);
>  
> -- 
> 1.7.9.5
>
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

Patch
diff mbox

diff --git a/drivers/staging/lustre/lustre/lvfs/lvfs_linux.c b/drivers/staging/lustre/lustre/lvfs/lvfs_linux.c
index bb8b152..1ef06fe 100644
--- a/drivers/staging/lustre/lustre/lvfs/lvfs_linux.c
+++ b/drivers/staging/lustre/lustre/lvfs/lvfs_linux.c
@@ -114,7 +114,7 @@  void push_ctxt(struct lvfs_run_ctxt *save, struct lvfs_run_ctxt *new_ctx,
 	if (new_ctx->dt != NULL)
 		return;
 
-	//ASSERT_NOT_KERNEL_CTXT("already in kernel context!\n");
+	/* ASSERT_NOT_KERNEL_CTXT("already in kernel context!\n"); */
 	ASSERT_CTXT_MAGIC(new_ctx->magic);
 	OBD_SET_CTXT_MAGIC(save);