[OPW,kernel] Staging: vt6655: Fix Sparse Warning for Static Declarations in ieee80211_crypt_tkip.c
diff mbox

Message ID 1382641080-6969-1-git-send-email-ebru.akagunduz@gmail.com
State Changes Requested
Headers show

Commit Message

Ebru Akagündüz Oct. 24, 2013, 6:58 p.m. UTC
This patch fixes the Sparse Warning "symbol was
not declared. Should it be static?" in
ieee80211_crypt_tkip.c

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
---
 drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_tkip.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Rusty Russell Oct. 25, 2013, 12:30 a.m. UTC | #1
Ebru Akagunduz <ebru.akagunduz@gmail.com> writes:

> This patch fixes the Sparse Warning "symbol was
> not declared. Should it be static?" in
> ieee80211_crypt_tkip.c
>
> Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>

Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>

Cheers,
Rusty.

> ---
>  drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_tkip.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_tkip.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_tkip.c
> index da24e43..211eaf9 100644
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_tkip.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_tkip.c
> @@ -732,13 +732,13 @@ static struct ieee80211_crypto_ops ieee80211_crypt_tkip = {
>  };
>  
>  
> -int ieee80211_crypto_tkip_init(void)
> +static int ieee80211_crypto_tkip_init(void)
>  {
>  	return ieee80211_register_crypto_ops(&ieee80211_crypt_tkip);
>  }
>  
>  
> -void ieee80211_crypto_tkip_exit(void)
> +static void ieee80211_crypto_tkip_exit(void)
>  {
>  	ieee80211_unregister_crypto_ops(&ieee80211_crypt_tkip);
>  }
> -- 
> 1.8.1.2
>
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
Greg KH Oct. 27, 2013, 1:56 p.m. UTC | #2
On Thu, Oct 24, 2013 at 09:58:00PM +0300, Ebru Akagunduz wrote:
> This patch fixes the Sparse Warning "symbol was
> not declared. Should it be static?" in
> ieee80211_crypt_tkip.c
> 
> Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
> ---
>  drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_tkip.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

You have sent a lot of patches for this driver, but I can't see which
ones should be applied in which order.  Some have been asked to be
fixed, and others depend on other ones.

Please redo this whole series, and send them as a series, with numbering
of the patches so that I know which to apply in which order, and which
ones I should be looking at based on other's review.

thanks,

greg k-h
Ebru Akagündüz Oct. 27, 2013, 8:59 p.m. UTC | #3
>
> You have sent a lot of patches for this driver, but I can't see which
> ones should be applied in which order.  Some have been asked to be
> fixed, and others depend on other ones.
>
> Please redo this whole series, and send them as a series, with numbering
> of the patches so that I know which to apply in which order, and which
> ones I should be looking at based on other's review.
>

I've send them seperately because they belong to different files. But if
you wish i can collect them as a series of patches.
Greg KH Oct. 27, 2013, 9:07 p.m. UTC | #4
On Sun, Oct 27, 2013 at 10:59:06PM +0200, Ebru Akagunduz wrote:
>     You have sent a lot of patches for this driver, but I can't see which
>     ones should be applied in which order.  Some have been asked to be
>     fixed, and others depend on other ones.
> 
>     Please redo this whole series, and send them as a series, with numbering
>     of the patches so that I know which to apply in which order, and which
>     ones I should be looking at based on other's review.
> 
> 
> I've send them seperately because they belong to different files.

Not all of them, there was at least 2 patches that were on the same file
from what I remember.

> But if you wish i can collect them as a series of patches. 

Please do.

thanks,

greg k-h
Ebru Akagündüz Oct. 27, 2013, 9:30 p.m. UTC | #5
I saw at patchwork

vt6656: rxtx.c: https://patchwork.kernel.org/patch/3093771/
                       https://patchwork.kernel.org/patch/3093761/

rtl8187se: ieee80211_crypt.c: https://patchwork.kernel.org/patch/3093571/

https://patchwork.kernel.org/patch/3093571/

Sorry for inconvenience. I'll fix and resend them.
Sarah Sharp Oct. 28, 2013, 7:56 p.m. UTC | #6
On Sun, Oct 27, 2013 at 10:59:06PM +0200, Ebru Akagunduz wrote:
> >
> > You have sent a lot of patches for this driver, but I can't see which
> > ones should be applied in which order.  Some have been asked to be
> > fixed, and others depend on other ones.
> >
> > Please redo this whole series, and send them as a series, with numbering
> > of the patches so that I know which to apply in which order, and which
> > ones I should be looking at based on other's review.
> >
> 
> I've send them seperately because they belong to different files. But if
> you wish i can collect them as a series of patches.

If you look carefully at the Makefile in drivers/staging/vt6655/Makefile
you will see that all the files in the vt6655 get compiled into the same
driver.  In general, you should split your changes into one logical
change made to one driver.  If a similar change is made to multiple
files in the driver, you should include all changes in a single patch.

For example, you made several functions static in different files under
the vt6655 directory, those changes should all be in one patch, since
they are all part of the same driver.  The same goes for files in the
vt6656 directory.

So, since Greg hasn't taken any of the sparse changes patches from you
yet, I would suggest re-doing all the static function changes in two
patches: one for the vt6655 driver, and one for the vt6656 driver.

You can use the `git rebase -i` command and squash your patches into two
patches.

Sarah Sharp
Ebru Akagündüz Oct. 28, 2013, 8:58 p.m. UTC | #7
>
>
> If you look carefully at the Makefile in drivers/staging/vt6655/Makefile
> you will see that all the files in the vt6655 get compiled into the same
> driver.  In general, you should split your changes into one logical
> change made to one driver.  If a similar change is made to multiple
> files in the driver, you should include all changes in a single patch.
>
> For example, you made several functions static in different files under
> the vt6655 directory, those changes should all be in one patch, since
> they are all part of the same driver.  The same goes for files in the
> vt6656 directory.
>

 I'll collect them into two patches and resend them.

>
> So, since Greg hasn't taken any of the sparse changes patches from you
> yet, I would suggest re-doing all the static function changes in two
> patches: one for the vt6655 driver, and one for the vt6656 driver.
>
> You can use the `git rebase -i` command and squash your patches into two
> patches.
>
> Sarah Sharp
>

Thanks.

Patch
diff mbox

diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_tkip.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_tkip.c
index da24e43..211eaf9 100644
--- a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_tkip.c
+++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_tkip.c
@@ -732,13 +732,13 @@  static struct ieee80211_crypto_ops ieee80211_crypt_tkip = {
 };
 
 
-int ieee80211_crypto_tkip_init(void)
+static int ieee80211_crypto_tkip_init(void)
 {
 	return ieee80211_register_crypto_ops(&ieee80211_crypt_tkip);
 }
 
 
-void ieee80211_crypto_tkip_exit(void)
+static void ieee80211_crypto_tkip_exit(void)
 {
 	ieee80211_unregister_crypto_ops(&ieee80211_crypt_tkip);
 }