[OPW,kernel] Staging: vt6656: Fix Sparse Warning for Static Declarations in wmgr.c
diff mbox

Message ID 1382650597-27907-1-git-send-email-ebru.akagunduz@gmail.com
State Changes Requested
Headers show

Commit Message

Ebru Akagündüz Oct. 24, 2013, 9:36 p.m. UTC
This patch fixes the Sparse Warning "symbol was
not declared. Should it be static?" in wmgr.c

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
---
 drivers/staging/vt6656/wmgr.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Rusty Russell Oct. 25, 2013, 1:14 a.m. UTC | #1
Ebru Akagunduz <ebru.akagunduz@gmail.com> writes:

> This patch fixes the Sparse Warning "symbol was
> not declared. Should it be static?" in wmgr.c
>
> Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>

Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>

Cheers,
Rusty.

> ---
>  drivers/staging/vt6656/wmgr.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/vt6656/wmgr.c b/drivers/staging/vt6656/wmgr.c
> index e26c415..d74b0e7 100644
> --- a/drivers/staging/vt6656/wmgr.c
> +++ b/drivers/staging/vt6656/wmgr.c
> @@ -2961,7 +2961,7 @@ static struct vnt_tx_mgmt *s_MgrMakeBeacon(struct vnt_private *pDevice,
>   *
>  -*/
>  
> -struct vnt_tx_mgmt *s_MgrMakeProbeResponse(struct vnt_private *pDevice,
> +static struct vnt_tx_mgmt *s_MgrMakeProbeResponse(struct vnt_private *pDevice,
>  	struct vnt_manager *pMgmt, u16 wCurrCapInfo, u16 wCurrBeaconPeriod,
>  	u32 uCurrChannel, u16 wCurrATIMWinodw, u8 *pDstAddr,
>  	PWLAN_IE_SSID pCurrSSID, u8 *pCurrBSSID,
> @@ -3081,7 +3081,7 @@ struct vnt_tx_mgmt *s_MgrMakeProbeResponse(struct vnt_private *pDevice,
>   *
>  -*/
>  
> -struct vnt_tx_mgmt *s_MgrMakeAssocRequest(struct vnt_private *pDevice,
> +static struct vnt_tx_mgmt *s_MgrMakeAssocRequest(struct vnt_private *pDevice,
>  	struct vnt_manager *pMgmt, u8 *pDAddr, u16 wCurrCapInfo,
>  	u16 wListenInterval,
>  	PWLAN_IE_SSID pCurrSSID,
> @@ -3329,7 +3329,7 @@ struct vnt_tx_mgmt *s_MgrMakeAssocRequest(struct vnt_private *pDevice,
>   *
>  -*/
>  
> -struct vnt_tx_mgmt *s_MgrMakeReAssocRequest(struct vnt_private *pDevice,
> +static struct vnt_tx_mgmt *s_MgrMakeReAssocRequest(struct vnt_private *pDevice,
>  	struct vnt_manager *pMgmt, u8 *pDAddr, u16 wCurrCapInfo,
>  	u16 wListenInterval, PWLAN_IE_SSID pCurrSSID,
>  	PWLAN_IE_SUPP_RATES pCurrRates,
> @@ -3576,7 +3576,7 @@ struct vnt_tx_mgmt *s_MgrMakeReAssocRequest(struct vnt_private *pDevice,
>   *
>  -*/
>  
> -struct vnt_tx_mgmt *s_MgrMakeAssocResponse(struct vnt_private *pDevice,
> +static struct vnt_tx_mgmt *s_MgrMakeAssocResponse(struct vnt_private *pDevice,
>  	struct vnt_manager *pMgmt, u16 wCurrCapInfo, u16 wAssocStatus,
>  	u16 wAssocAID, u8 *pDstAddr, PWLAN_IE_SUPP_RATES pCurrSuppRates,
>  	PWLAN_IE_SUPP_RATES pCurrExtSuppRates)
> @@ -3642,7 +3642,7 @@ struct vnt_tx_mgmt *s_MgrMakeAssocResponse(struct vnt_private *pDevice,
>   *
>  -*/
>  
> -struct vnt_tx_mgmt *s_MgrMakeReAssocResponse(struct vnt_private *pDevice,
> +static struct vnt_tx_mgmt *s_MgrMakeReAssocResponse(struct vnt_private *pDevice,
>  	struct vnt_manager *pMgmt, u16 wCurrCapInfo, u16 wAssocStatus,
>  	u16 wAssocAID, u8 *pDstAddr, PWLAN_IE_SUPP_RATES pCurrSuppRates,
>  	PWLAN_IE_SUPP_RATES pCurrExtSuppRates)
> -- 
> 1.8.1.2
>
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

Patch
diff mbox

diff --git a/drivers/staging/vt6656/wmgr.c b/drivers/staging/vt6656/wmgr.c
index e26c415..d74b0e7 100644
--- a/drivers/staging/vt6656/wmgr.c
+++ b/drivers/staging/vt6656/wmgr.c
@@ -2961,7 +2961,7 @@  static struct vnt_tx_mgmt *s_MgrMakeBeacon(struct vnt_private *pDevice,
  *
 -*/
 
-struct vnt_tx_mgmt *s_MgrMakeProbeResponse(struct vnt_private *pDevice,
+static struct vnt_tx_mgmt *s_MgrMakeProbeResponse(struct vnt_private *pDevice,
 	struct vnt_manager *pMgmt, u16 wCurrCapInfo, u16 wCurrBeaconPeriod,
 	u32 uCurrChannel, u16 wCurrATIMWinodw, u8 *pDstAddr,
 	PWLAN_IE_SSID pCurrSSID, u8 *pCurrBSSID,
@@ -3081,7 +3081,7 @@  struct vnt_tx_mgmt *s_MgrMakeProbeResponse(struct vnt_private *pDevice,
  *
 -*/
 
-struct vnt_tx_mgmt *s_MgrMakeAssocRequest(struct vnt_private *pDevice,
+static struct vnt_tx_mgmt *s_MgrMakeAssocRequest(struct vnt_private *pDevice,
 	struct vnt_manager *pMgmt, u8 *pDAddr, u16 wCurrCapInfo,
 	u16 wListenInterval,
 	PWLAN_IE_SSID pCurrSSID,
@@ -3329,7 +3329,7 @@  struct vnt_tx_mgmt *s_MgrMakeAssocRequest(struct vnt_private *pDevice,
  *
 -*/
 
-struct vnt_tx_mgmt *s_MgrMakeReAssocRequest(struct vnt_private *pDevice,
+static struct vnt_tx_mgmt *s_MgrMakeReAssocRequest(struct vnt_private *pDevice,
 	struct vnt_manager *pMgmt, u8 *pDAddr, u16 wCurrCapInfo,
 	u16 wListenInterval, PWLAN_IE_SSID pCurrSSID,
 	PWLAN_IE_SUPP_RATES pCurrRates,
@@ -3576,7 +3576,7 @@  struct vnt_tx_mgmt *s_MgrMakeReAssocRequest(struct vnt_private *pDevice,
  *
 -*/
 
-struct vnt_tx_mgmt *s_MgrMakeAssocResponse(struct vnt_private *pDevice,
+static struct vnt_tx_mgmt *s_MgrMakeAssocResponse(struct vnt_private *pDevice,
 	struct vnt_manager *pMgmt, u16 wCurrCapInfo, u16 wAssocStatus,
 	u16 wAssocAID, u8 *pDstAddr, PWLAN_IE_SUPP_RATES pCurrSuppRates,
 	PWLAN_IE_SUPP_RATES pCurrExtSuppRates)
@@ -3642,7 +3642,7 @@  struct vnt_tx_mgmt *s_MgrMakeAssocResponse(struct vnt_private *pDevice,
  *
 -*/
 
-struct vnt_tx_mgmt *s_MgrMakeReAssocResponse(struct vnt_private *pDevice,
+static struct vnt_tx_mgmt *s_MgrMakeReAssocResponse(struct vnt_private *pDevice,
 	struct vnt_manager *pMgmt, u16 wCurrCapInfo, u16 wAssocStatus,
 	u16 wAssocAID, u8 *pDstAddr, PWLAN_IE_SUPP_RATES pCurrSuppRates,
 	PWLAN_IE_SUPP_RATES pCurrExtSuppRates)