[OPW,kernel] Staging: vt6656: Fix Sparse Warning for Static Declarations in wcmd.c
diff mbox

Message ID 1382651253-28855-1-git-send-email-ebru.akagunduz@gmail.com
State Changes Requested
Headers show

Commit Message

Ebru Akagündüz Oct. 24, 2013, 9:47 p.m. UTC
This patch fixes the Sparse Warning "symbol was
not declared. Should it be static?" in wcmd.c

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
---
 drivers/staging/vt6656/wcmd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Rusty Russell Oct. 25, 2013, 1:15 a.m. UTC | #1
Ebru Akagunduz <ebru.akagunduz@gmail.com> writes:
> This patch fixes the Sparse Warning "symbol was
> not declared. Should it be static?" in wcmd.c
>
> Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>

Hmm, why isn't this patch part of the previous one?

Cheers,
Rusty.

> ---
>  drivers/staging/vt6656/wcmd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vt6656/wcmd.c b/drivers/staging/vt6656/wcmd.c
> index 2f8e2a8..c4a1a74 100644
> --- a/drivers/staging/vt6656/wcmd.c
> +++ b/drivers/staging/vt6656/wcmd.c
> @@ -224,7 +224,7 @@ static void s_vProbeChannel(struct vnt_private *pDevice)
>   *
>  -*/
>  
> -struct vnt_tx_mgmt *s_MgrMakeProbeRequest(struct vnt_private *pDevice,
> +static struct vnt_tx_mgmt *s_MgrMakeProbeRequest(struct vnt_private *pDevice,
>  	struct vnt_manager *pMgmt, u8 *pScanBSSID, PWLAN_IE_SSID pSSID,
>  	PWLAN_IE_SUPP_RATES pCurrRates, PWLAN_IE_SUPP_RATES pCurrExtSuppRates)
>  {
> @@ -266,7 +266,7 @@ struct vnt_tx_mgmt *s_MgrMakeProbeRequest(struct vnt_private *pDevice,
>      return pTxPacket;
>  }
>  
> -void vCommandTimerWait(struct vnt_private *pDevice, unsigned long MSecond)
> +static void vCommandTimerWait(struct vnt_private *pDevice, unsigned long MSecond)
>  {
>  	schedule_delayed_work(&pDevice->run_command_work,
>  						msecs_to_jiffies(MSecond));
> -- 
> 1.8.1.2
>
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
Ebru Akagündüz Oct. 27, 2013, 10:32 p.m. UTC | #2
>
> Hmm, why isn't this patch part of the previous one?
>
> It isn't a part of previous patch. Previous patch and this to belong
different files. So I sent them different patches.

Thanks.
Rusty Russell Oct. 28, 2013, 3:17 a.m. UTC | #3
Ebru Akagunduz <ebru.akagunduz@gmail.com> writes:
>>
>> Hmm, why isn't this patch part of the previous one?
>>
>> It isn't a part of previous patch. Previous patch and this to belong
> different files. So I sent them different patches.

Good point, I misread.

This patch is fine:

Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>

Cheers,
Rusty.
Greg Kroah-Hartman Oct. 28, 2013, 3:19 a.m. UTC | #4
On Mon, Oct 28, 2013 at 12:32:11AM +0200, Ebru Akagunduz wrote:
> 
> 
>     Hmm, why isn't this patch part of the previous one?
> 
> 
> It isn't a part of previous patch. Previous patch and this to belong different
> files. So I sent them different patches.

But it's doing the same _logical_ thing.  Don't just split patches
across files, but do it per _logical_ change.  Most of the time that
means multiple files.

greg k-h

Patch
diff mbox

diff --git a/drivers/staging/vt6656/wcmd.c b/drivers/staging/vt6656/wcmd.c
index 2f8e2a8..c4a1a74 100644
--- a/drivers/staging/vt6656/wcmd.c
+++ b/drivers/staging/vt6656/wcmd.c
@@ -224,7 +224,7 @@  static void s_vProbeChannel(struct vnt_private *pDevice)
  *
 -*/
 
-struct vnt_tx_mgmt *s_MgrMakeProbeRequest(struct vnt_private *pDevice,
+static struct vnt_tx_mgmt *s_MgrMakeProbeRequest(struct vnt_private *pDevice,
 	struct vnt_manager *pMgmt, u8 *pScanBSSID, PWLAN_IE_SSID pSSID,
 	PWLAN_IE_SUPP_RATES pCurrRates, PWLAN_IE_SUPP_RATES pCurrExtSuppRates)
 {
@@ -266,7 +266,7 @@  struct vnt_tx_mgmt *s_MgrMakeProbeRequest(struct vnt_private *pDevice,
     return pTxPacket;
 }
 
-void vCommandTimerWait(struct vnt_private *pDevice, unsigned long MSecond)
+static void vCommandTimerWait(struct vnt_private *pDevice, unsigned long MSecond)
 {
 	schedule_delayed_work(&pDevice->run_command_work,
 						msecs_to_jiffies(MSecond));