[OPW,kernel,1/5] Staging: ft1000: Fix assignment of bool to non-0/1 constant
diff mbox

Message ID 012e75944b812a08eed5d672810660057ef34f5e.1382714792.git.rashika.kheria@gmail.com
State Changes Requested
Headers show

Commit Message

Rashika Oct. 25, 2013, 3:28 p.m. UTC
This patch fixes the following coccinelle error in ft1000-usb/ft1000_usb.c-
drivers/staging/ft1000/ft1000-usb/ft1000_usb.c:50:4-18: ERROR: Assignment of bool to non-0/1 constant
drivers/staging/ft1000/ft1000-usb/ft1000_usb.c:174:1-15: ERROR: Assignment of bool to non-0/1 constant
drivers/staging/ft1000/ft1000-usb/ft1000_usb.c:39:12-26: ERROR: Assignment of bool to non-0/1 constant

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
 drivers/staging/ft1000/ft1000-usb/ft1000_usb.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Lisa Nguyen Oct. 25, 2013, 5:31 p.m. UTC | #1
On Fri, Oct 25, 2013 at 8:28 AM, Rashika Kheria
<rashika.kheria@gmail.com> wrote:
> This patch fixes the following coccinelle error in ft1000-usb/ft1000_usb.c-
> drivers/staging/ft1000/ft1000-usb/ft1000_usb.c:50:4-18: ERROR: Assignment of bool to non-0/1 constant
> drivers/staging/ft1000/ft1000-usb/ft1000_usb.c:174:1-15: ERROR: Assignment of bool to non-0/1 constant
> drivers/staging/ft1000/ft1000-usb/ft1000_usb.c:39:12-26: ERROR: Assignment of bool to non-0/1 constant
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>

> ---
>  drivers/staging/ft1000/ft1000-usb/ft1000_usb.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c b/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c
> index 29a7cd2..a8dd1e5 100644
> --- a/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c
> +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c
> @@ -36,7 +36,7 @@ static struct usb_device_id id_table[] = {
>
>  MODULE_DEVICE_TABLE(usb, id_table);
>
> -static bool gPollingfailed = FALSE;
> +static bool gPollingfailed = false;
>  static int ft1000_poll_thread(void *arg)
>  {
>         int ret;
> @@ -47,7 +47,7 @@ static int ft1000_poll_thread(void *arg)
>                         ret = ft1000_poll(arg);
>                         if (ret != STATUS_SUCCESS) {
>                                 DEBUG("ft1000_poll_thread: polling failed\n");
> -                               gPollingfailed = TRUE;
> +                               gPollingfailed = true;
>                         }
>                 }
>         }
> @@ -171,7 +171,7 @@ static int ft1000_probe(struct usb_interface *interface,
>                 goto err_load;
>         }
>
> -       gPollingfailed = FALSE;
> +       gPollingfailed = false;
>         ft1000dev->pPollThread =
>             kthread_run(ft1000_poll_thread, ft1000dev, "ft1000_poll");
>
> --
> 1.7.9.5
>
> --
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
Greg Kroah-Hartman Oct. 27, 2013, 1:38 p.m. UTC | #2
On Fri, Oct 25, 2013 at 08:58:14PM +0530, Rashika Kheria wrote:
> This patch fixes the following coccinelle error in ft1000-usb/ft1000_usb.c-
> drivers/staging/ft1000/ft1000-usb/ft1000_usb.c:50:4-18: ERROR: Assignment of bool to non-0/1 constant
> drivers/staging/ft1000/ft1000-usb/ft1000_usb.c:174:1-15: ERROR: Assignment of bool to non-0/1 constant
> drivers/staging/ft1000/ft1000-usb/ft1000_usb.c:39:12-26: ERROR: Assignment of bool to non-0/1 constant
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

This series is good, but you have 2 patches with the same exact Subject:
line, and 3 others with the same exact Subject: line, making it so I
can't accept this patch (the Subjects need to be unique.)

Can you please redo this?

thanks,

greg k-h

Patch
diff mbox

diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c b/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c
index 29a7cd2..a8dd1e5 100644
--- a/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c
+++ b/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c
@@ -36,7 +36,7 @@  static struct usb_device_id id_table[] = {
 
 MODULE_DEVICE_TABLE(usb, id_table);
 
-static bool gPollingfailed = FALSE;
+static bool gPollingfailed = false;
 static int ft1000_poll_thread(void *arg)
 {
 	int ret;
@@ -47,7 +47,7 @@  static int ft1000_poll_thread(void *arg)
 			ret = ft1000_poll(arg);
 			if (ret != STATUS_SUCCESS) {
 				DEBUG("ft1000_poll_thread: polling failed\n");
-				gPollingfailed = TRUE;
+				gPollingfailed = true;
 			}
 		}
 	}
@@ -171,7 +171,7 @@  static int ft1000_probe(struct usb_interface *interface,
 		goto err_load;
 	}
 
-	gPollingfailed = FALSE;
+	gPollingfailed = false;
 	ft1000dev->pPollThread =
 	    kthread_run(ft1000_poll_thread, ft1000dev, "ft1000_poll");