[OPW,kernel,2/5] Staging: ft1000: Fix assignment of bool to non-0/1 constant
diff mbox

Message ID ad86ddadaa15957a237ba04de6782cfaf1500b2a.1382714792.git.rashika.kheria@gmail.com
State Changes Requested
Headers show

Commit Message

Rashika Oct. 25, 2013, 3:30 p.m. UTC
This patch fixes the following coccinelle error in ft1000-usb/ft1000_download.c -

drivers/staging/ft1000/ft1000-usb/ft1000_download.c:615:1-16: ERROR: Assignment of bool to non-0/1 constant
drivers/staging/ft1000/ft1000-usb/ft1000_download.c:926:5-20: ERROR: Assignment of bool to non-0/1 constant
drivers/staging/ft1000/ft1000-usb/ft1000_download.c:943:7-22: ERROR: Assignment of bool to non-0/1 constant

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
 .../staging/ft1000/ft1000-usb/ft1000_download.c    |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Lisa Nguyen Oct. 25, 2013, 5:32 p.m. UTC | #1
On Fri, Oct 25, 2013 at 8:30 AM, Rashika Kheria
<rashika.kheria@gmail.com> wrote:
> This patch fixes the following coccinelle error in ft1000-usb/ft1000_download.c -
>
> drivers/staging/ft1000/ft1000-usb/ft1000_download.c:615:1-16: ERROR: Assignment of bool to non-0/1 constant
> drivers/staging/ft1000/ft1000-usb/ft1000_download.c:926:5-20: ERROR: Assignment of bool to non-0/1 constant
> drivers/staging/ft1000/ft1000-usb/ft1000_download.c:943:7-22: ERROR: Assignment of bool to non-0/1 constant
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>

> ---
>  .../staging/ft1000/ft1000-usb/ft1000_download.c    |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c b/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
> index 1a1413d..bfffce5 100644
> --- a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
> +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
> @@ -612,7 +612,7 @@ u16 scram_dnldr(struct ft1000_usb *ft1000dev, void *pFileStart,
>
>         loader_code_address = file_hdr->loader_code_address;
>         loader_code_size = file_hdr->loader_code_size;
> -       correct_version = FALSE;
> +       correct_version = false;
>
>         while ((status == STATUS_SUCCESS) && (state != STATE_DONE_FILE)) {
>                 switch (state) {
> @@ -923,7 +923,7 @@ u16 scram_dnldr(struct ft1000_usb *ft1000dev, void *pFileStart,
>                                 case REQUEST_CODE_BY_VERSION:
>                                         DEBUG
>                                             ("FT1000:download:REQUEST_CODE_BY_VERSION\n");
> -                                       correct_version = FALSE;
> +                                       correct_version = false;
>                                         requested_version =
>                                             get_request_value(ft1000dev);
>
> @@ -940,7 +940,7 @@ u16 scram_dnldr(struct ft1000_usb *ft1000dev, void *pFileStart,
>
>                                                 if (dsp_img_info->version ==
>                                                     requested_version) {
> -                                                       correct_version = TRUE;
> +                                                       correct_version = true;
>                                                         DEBUG
>                                                             ("FT1000:download: correct_version is TRUE\n");
>                                                         s_file =
> --
> 1.7.9.5
>
> --
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

Patch
diff mbox

diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c b/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
index 1a1413d..bfffce5 100644
--- a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
+++ b/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
@@ -612,7 +612,7 @@  u16 scram_dnldr(struct ft1000_usb *ft1000dev, void *pFileStart,
 
 	loader_code_address = file_hdr->loader_code_address;
 	loader_code_size = file_hdr->loader_code_size;
-	correct_version = FALSE;
+	correct_version = false;
 
 	while ((status == STATUS_SUCCESS) && (state != STATE_DONE_FILE)) {
 		switch (state) {
@@ -923,7 +923,7 @@  u16 scram_dnldr(struct ft1000_usb *ft1000dev, void *pFileStart,
 				case REQUEST_CODE_BY_VERSION:
 					DEBUG
 					    ("FT1000:download:REQUEST_CODE_BY_VERSION\n");
-					correct_version = FALSE;
+					correct_version = false;
 					requested_version =
 					    get_request_value(ft1000dev);
 
@@ -940,7 +940,7 @@  u16 scram_dnldr(struct ft1000_usb *ft1000dev, void *pFileStart,
 
 						if (dsp_img_info->version ==
 						    requested_version) {
-							correct_version = TRUE;
+							correct_version = true;
 							DEBUG
 							    ("FT1000:download: correct_version is TRUE\n");
 							s_file =