[OPW,kernel,v2] drivers/staging/bcm/Adapter.h: changed union name from _U_IP_ADDRESS to U_IP_ADDRESS
diff mbox

Message ID 20131025212156.GA373@himangi-Inspiron-N5110gmail.com
State Changes Requested
Headers show

Commit Message

HIMANGI SARAOGI Oct. 25, 2013, 9:21 p.m. UTC
The union was earlier typedef to U_IP_ADDRESS but I removed typedef in
my previous patch. Based on feedback I have removed the underscore.

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
---
 drivers/staging/bcm/Adapter.h |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Lisa Nguyen Oct. 25, 2013, 9:24 p.m. UTC | #1
On Fri, Oct 25, 2013 at 2:21 PM, Himangi Saraogi <himangi774@gmail.com> wrote:
> The union was earlier typedef to U_IP_ADDRESS but I removed typedef in
> my previous patch. Based on feedback I have removed the underscore.
>
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> ---
>  drivers/staging/bcm/Adapter.h |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
> index ed83b84..605fa79 100644
> --- a/drivers/staging/bcm/Adapter.h
> +++ b/drivers/staging/bcm/Adapter.h
> @@ -35,7 +35,7 @@ struct bcm_link_request {
>  #define MAX_PROTOCOL_LENGTH   32
>  #define IPV6_ADDRESS_SIZEINBYTES 0x10
>
> -union _U_IP_ADDRESS {
> +union U_IP_ADDRESS {
>         struct {
>                 ULONG ulIpv4Addr[MAX_IP_RANGE_LENGTH]; /* Source Ip Address Range */
>                 ULONG ulIpv4Mask[MAX_IP_RANGE_LENGTH]; /* Source Ip Mask Address Range */
> @@ -66,10 +66,10 @@ struct bcm_classifier_rule {
>         BOOLEAN         bUsed;
>         USHORT          usVCID_Value;
>         B_UINT8         u8ClassifierRulePriority; /* This field detemines the Classifier Priority */
> -       union _U_IP_ADDRESS     stSrcIpAddress;
> +       union U_IP_ADDRESS      stSrcIpAddress;
>         UCHAR           ucIPSourceAddressLength; /* Ip Source Address Length */
>
> -       union _U_IP_ADDRESS     stDestIpAddress;
> +       union U_IP_ADDRESS      stDestIpAddress;
>         UCHAR           ucIPDestinationAddressLength; /* Ip Destination Address Length */
>         UCHAR           ucIPTypeOfServiceLength; /* Type of service Length */
>         UCHAR           ucTosLow; /* Tos Low */

Hi Himangi,

The patch is starting to look better :)

One thing -- Did you compile the changes to make sure it didn't create
any build errors?

Lisa

> --
> 1.7.9.5
>
> --
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
Lisa Nguyen Oct. 25, 2013, 9:44 p.m. UTC | #2
On Fri, Oct 25, 2013 at 2:24 PM, Lisa Nguyen <lisa@xenapiadmin.com> wrote:
> On Fri, Oct 25, 2013 at 2:21 PM, Himangi Saraogi <himangi774@gmail.com> wrote:
>> The union was earlier typedef to U_IP_ADDRESS but I removed typedef in
>> my previous patch. Based on feedback I have removed the underscore.
>>
>> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
>> ---
>>  drivers/staging/bcm/Adapter.h |    6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
>> index ed83b84..605fa79 100644
>> --- a/drivers/staging/bcm/Adapter.h
>> +++ b/drivers/staging/bcm/Adapter.h
>> @@ -35,7 +35,7 @@ struct bcm_link_request {
>>  #define MAX_PROTOCOL_LENGTH   32
>>  #define IPV6_ADDRESS_SIZEINBYTES 0x10
>>
>> -union _U_IP_ADDRESS {
>> +union U_IP_ADDRESS {
>>         struct {
>>                 ULONG ulIpv4Addr[MAX_IP_RANGE_LENGTH]; /* Source Ip Address Range */
>>                 ULONG ulIpv4Mask[MAX_IP_RANGE_LENGTH]; /* Source Ip Mask Address Range */
>> @@ -66,10 +66,10 @@ struct bcm_classifier_rule {
>>         BOOLEAN         bUsed;
>>         USHORT          usVCID_Value;
>>         B_UINT8         u8ClassifierRulePriority; /* This field detemines the Classifier Priority */
>> -       union _U_IP_ADDRESS     stSrcIpAddress;
>> +       union U_IP_ADDRESS      stSrcIpAddress;
>>         UCHAR           ucIPSourceAddressLength; /* Ip Source Address Length */
>>
>> -       union _U_IP_ADDRESS     stDestIpAddress;
>> +       union U_IP_ADDRESS      stDestIpAddress;
>>         UCHAR           ucIPDestinationAddressLength; /* Ip Destination Address Length */
>>         UCHAR           ucIPTypeOfServiceLength; /* Type of service Length */
>>         UCHAR           ucTosLow; /* Tos Low */
>
> Hi Himangi,
>
> The patch is starting to look better :)
>
> One thing -- Did you compile the changes to make sure it didn't create
> any build errors?
>
> Lisa
>

Assuming that this has been compile tested (been informed by Himangi
that no errors occurred on her end)...

Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>

>> --
>> 1.7.9.5
>>
>> --
>> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
Sarah Sharp Oct. 28, 2013, 9:02 p.m. UTC | #3
Hi Himangi!

First, thanks for using version numbers for this updated patch. :)

However, you need to edit your patch description a bit.  The description
should be like the one you sent in your first patch, but updated for
any revisions you made in this version of the patch.

On Sat, Oct 26, 2013 at 02:51:56AM +0530, Himangi Saraogi wrote:
> The union was earlier typedef to U_IP_ADDRESS but I removed typedef in
> my previous patch. Based on feedback I have removed the underscore.

This is a changelog, and it doesn't go in the patch description.  This
description is all that people would see when they run `git log`, and it
doesn't really make sense without the log from your first patch, does
it?

Instead, you should your change log...

> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> ---

...here.  You might say something like:

v2:

The union was earlier typedef to U_IP_ADDRESS but I removed typedef in
my previous patch. Based on feedback I have removed the underscore.


You can do that creating the patch with `git format-patch` and
then edit it to add that change lot after the --- line.  Then you can
send the patch using `git send-email` or mutt.

Makes sense?

Sarah Sharp

>  drivers/staging/bcm/Adapter.h |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
> index ed83b84..605fa79 100644
> --- a/drivers/staging/bcm/Adapter.h
> +++ b/drivers/staging/bcm/Adapter.h
> @@ -35,7 +35,7 @@ struct bcm_link_request {
>  #define MAX_PROTOCOL_LENGTH   32
>  #define IPV6_ADDRESS_SIZEINBYTES 0x10
>  
> -union _U_IP_ADDRESS {
> +union U_IP_ADDRESS {
>  	struct {
>  		ULONG ulIpv4Addr[MAX_IP_RANGE_LENGTH]; /* Source Ip Address Range */
>  		ULONG ulIpv4Mask[MAX_IP_RANGE_LENGTH]; /* Source Ip Mask Address Range */
> @@ -66,10 +66,10 @@ struct bcm_classifier_rule {
>  	BOOLEAN		bUsed;
>  	USHORT		usVCID_Value;
>  	B_UINT8		u8ClassifierRulePriority; /* This field detemines the Classifier Priority */
> -	union _U_IP_ADDRESS	stSrcIpAddress;
> +	union U_IP_ADDRESS	stSrcIpAddress;
>  	UCHAR		ucIPSourceAddressLength; /* Ip Source Address Length */
>  
> -	union _U_IP_ADDRESS	stDestIpAddress;
> +	union U_IP_ADDRESS	stDestIpAddress;
>  	UCHAR		ucIPDestinationAddressLength; /* Ip Destination Address Length */
>  	UCHAR		ucIPTypeOfServiceLength; /* Type of service Length */
>  	UCHAR		ucTosLow; /* Tos Low */
> -- 
> 1.7.9.5
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
Greg KH Oct. 28, 2013, 9:32 p.m. UTC | #4
On Sat, Oct 26, 2013 at 02:51:56AM +0530, Himangi Saraogi wrote:
> The union was earlier typedef to U_IP_ADDRESS but I removed typedef in
> my previous patch. Based on feedback I have removed the underscore.
> 
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> ---
>  drivers/staging/bcm/Adapter.h |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
> index ed83b84..605fa79 100644
> --- a/drivers/staging/bcm/Adapter.h
> +++ b/drivers/staging/bcm/Adapter.h
> @@ -35,7 +35,7 @@ struct bcm_link_request {
>  #define MAX_PROTOCOL_LENGTH   32
>  #define IPV6_ADDRESS_SIZEINBYTES 0x10
>  
> -union _U_IP_ADDRESS {
> +union U_IP_ADDRESS {

You just made a patch against your patch, not against my tree, so I
can't apply this :(

Also, types are all lowercase, so this would be better as
"u_ip_address".

Can you please try this again?

thanks,

greg k-h

Patch
diff mbox

diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
index ed83b84..605fa79 100644
--- a/drivers/staging/bcm/Adapter.h
+++ b/drivers/staging/bcm/Adapter.h
@@ -35,7 +35,7 @@  struct bcm_link_request {
 #define MAX_PROTOCOL_LENGTH   32
 #define IPV6_ADDRESS_SIZEINBYTES 0x10
 
-union _U_IP_ADDRESS {
+union U_IP_ADDRESS {
 	struct {
 		ULONG ulIpv4Addr[MAX_IP_RANGE_LENGTH]; /* Source Ip Address Range */
 		ULONG ulIpv4Mask[MAX_IP_RANGE_LENGTH]; /* Source Ip Mask Address Range */
@@ -66,10 +66,10 @@  struct bcm_classifier_rule {
 	BOOLEAN		bUsed;
 	USHORT		usVCID_Value;
 	B_UINT8		u8ClassifierRulePriority; /* This field detemines the Classifier Priority */
-	union _U_IP_ADDRESS	stSrcIpAddress;
+	union U_IP_ADDRESS	stSrcIpAddress;
 	UCHAR		ucIPSourceAddressLength; /* Ip Source Address Length */
 
-	union _U_IP_ADDRESS	stDestIpAddress;
+	union U_IP_ADDRESS	stDestIpAddress;
 	UCHAR		ucIPDestinationAddressLength; /* Ip Destination Address Length */
 	UCHAR		ucIPTypeOfServiceLength; /* Type of service Length */
 	UCHAR		ucTosLow; /* Tos Low */