[OPW,kernel] Staging: dgap: Fix "return is not a function" checkpatch.pl warning
diff mbox

Message ID 1382793256-3332-1-git-send-email-julia@jvns.ca
State Changes Requested
Headers show

Commit Message

Julia Evans Oct. 26, 2013, 1:14 p.m. UTC
Signed-off-by: Julia Evans <julia@jvns.ca>
---
 drivers/staging/dgap/dgap_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lisa Nguyen Oct. 27, 2013, 8:09 p.m. UTC | #1
Hi Julia!

On Sat, Oct 26, 2013 at 6:14 AM, Julia Evans <julia@jvns.ca> wrote:
> Signed-off-by: Julia Evans <julia@jvns.ca>
> ---
>  drivers/staging/dgap/dgap_driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/dgap/dgap_driver.c b/drivers/staging/dgap/dgap_driver.c
> index 4c1515e..878a9ee 100644
> --- a/drivers/staging/dgap/dgap_driver.c
> +++ b/drivers/staging/dgap/dgap_driver.c
> @@ -934,7 +934,7 @@ void *dgap_driver_kzmalloc(size_t size, int priority)
>         void *p = kmalloc(size, priority);
>         if(p)
>                 memset(p, 0, size);
> -       return(p);
> +       return p;
>  }

Good first attempt so far :)

Few things:

1. Please rename your subject line to staging: dgap: <brief
description>. The convention is usually <subsystem>: <driver>:
<description> in most cases.

2. I'm not sure if Greg accepts patches without a commit message, so
let's wait for him to respond to this part. It's obvious that you
removed the unnecessary parentheses from the return statement.
However, if I'm looking into someone's patch, I'd expect to see a
commit message explaining why it's important for a maintainer to
accept your patch. You're welcome to look at other applicants' patches
to get an idea.

3. If you choose to redo this patch, please make sure you put "v2" in
your modified subject line. The "editing commits" section of the first
patch tutorial explains how to do this.

4. If you have any more questions, please don't forget to cc the
opw-kernel mailing list in case another mentor can answer your
questions quickly than I do.

Hope this helps,
Lisa

>
> --
> 1.8.4.1
>
> --
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
Lisa Nguyen Oct. 27, 2013, 8:10 p.m. UTC | #2
On Sun, Oct 27, 2013 at 1:09 PM, Lisa Nguyen <lisa@xenapiadmin.com> wrote:
> Hi Julia!
>
> On Sat, Oct 26, 2013 at 6:14 AM, Julia Evans <julia@jvns.ca> wrote:
>> Signed-off-by: Julia Evans <julia@jvns.ca>
>> ---
>>  drivers/staging/dgap/dgap_driver.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/dgap/dgap_driver.c b/drivers/staging/dgap/dgap_driver.c
>> index 4c1515e..878a9ee 100644
>> --- a/drivers/staging/dgap/dgap_driver.c
>> +++ b/drivers/staging/dgap/dgap_driver.c
>> @@ -934,7 +934,7 @@ void *dgap_driver_kzmalloc(size_t size, int priority)
>>         void *p = kmalloc(size, priority);
>>         if(p)
>>                 memset(p, 0, size);
>> -       return(p);
>> +       return p;
>>  }
>
> Good first attempt so far :)
>
> Few things:
>
> 1. Please rename your subject line to staging: dgap: <brief
> description>. The convention is usually <subsystem>: <driver>:
> <description> in most cases.

Oops, please disregard the first item. I just now noticed.

>
> 2. I'm not sure if Greg accepts patches without a commit message, so
> let's wait for him to respond to this part. It's obvious that you
> removed the unnecessary parentheses from the return statement.
> However, if I'm looking into someone's patch, I'd expect to see a
> commit message explaining why it's important for a maintainer to
> accept your patch. You're welcome to look at other applicants' patches
> to get an idea.
>
> 3. If you choose to redo this patch, please make sure you put "v2" in
> your modified subject line. The "editing commits" section of the first
> patch tutorial explains how to do this.
>
> 4. If you have any more questions, please don't forget to cc the
> opw-kernel mailing list in case another mentor can answer your
> questions quickly than I do.
>
> Hope this helps,
> Lisa
>
>>
>> --
>> 1.8.4.1
>>
>> --
>> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
Greg KH Oct. 28, 2013, 9:50 p.m. UTC | #3
On Sun, Oct 27, 2013 at 01:09:56PM -0700, Lisa Nguyen wrote:
> Hi Julia!
> 
> On Sat, Oct 26, 2013 at 6:14 AM, Julia Evans <julia@jvns.ca> wrote:
> > Signed-off-by: Julia Evans <julia@jvns.ca>
> > ---
> >  drivers/staging/dgap/dgap_driver.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/dgap/dgap_driver.c b/drivers/staging/dgap/dgap_driver.c
> > index 4c1515e..878a9ee 100644
> > --- a/drivers/staging/dgap/dgap_driver.c
> > +++ b/drivers/staging/dgap/dgap_driver.c
> > @@ -934,7 +934,7 @@ void *dgap_driver_kzmalloc(size_t size, int priority)
> >         void *p = kmalloc(size, priority);
> >         if(p)
> >                 memset(p, 0, size);
> > -       return(p);
> > +       return p;
> >  }
> 
> Good first attempt so far :)
> 
> Few things:
> 
> 1. Please rename your subject line to staging: dgap: <brief
> description>. The convention is usually <subsystem>: <driver>:
> <description> in most cases.
> 
> 2. I'm not sure if Greg accepts patches without a commit message, so
> let's wait for him to respond to this part.

No, I don't want to, so can this be please redone and resent?

thanks,

greg k-h

Patch
diff mbox

diff --git a/drivers/staging/dgap/dgap_driver.c b/drivers/staging/dgap/dgap_driver.c
index 4c1515e..878a9ee 100644
--- a/drivers/staging/dgap/dgap_driver.c
+++ b/drivers/staging/dgap/dgap_driver.c
@@ -934,7 +934,7 @@  void *dgap_driver_kzmalloc(size_t size, int priority)
  	void *p = kmalloc(size, priority);
 	if(p)
 		memset(p, 0, size);
-	return(p);
+	return p;
 }