[OPW,kernel] staging: imx-drm: remove unnecessary braces
diff mbox

Message ID 20131103101857.GA19539@lovelace
State Awaiting Upstream
Headers show

Commit Message

Sima Baymani Nov. 3, 2013, 10:18 a.m. UTC
Fix checkpatch warning by removing unnecessary braces.
Compile-tested the single file.

Signed-off-by: Sima Baymani <sima.baymani@gmail.com>
---
 drivers/staging/imx-drm/imx-ldb.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Archana kumari Nov. 3, 2013, 10:21 a.m. UTC | #1
On Sunday, November 3, 2013 3:48:57 PM UTC+5:30, Sima wrote:
>
> Fix checkpatch warning by removing unnecessary braces. 
> Compile-tested the single file. 
>
> Signed-off-by: Sima Baymani <sima.b...@gmail.com <javascript:>> 
> --- 
>  drivers/staging/imx-drm/imx-ldb.c |    3 +-- 
>  1 file changed, 1 insertion(+), 2 deletions(-) 
>
> diff --git a/drivers/staging/imx-drm/imx-ldb.c 
> b/drivers/staging/imx-drm/imx-ldb.c 
> index 654bf03..bae58ea 100644 
> --- a/drivers/staging/imx-drm/imx-ldb.c 
> +++ b/drivers/staging/imx-drm/imx-ldb.c 
> @@ -167,9 +167,8 @@ static void imx_ldb_set_clock(struct imx_ldb *ldb, int 
> mux, int chno, 
>   
>          /* set display clock mux to LDB input clock */ 
>          ret = clk_set_parent(ldb->clk_sel[mux], ldb->clk[chno]); 
> -        if (ret) { 
> +        if (ret) 
>                  dev_err(ldb->dev, "unable to set di%d parent clock to 
> ldb_di%d\n", mux, chno); 
> -        } 
>  } 
>   
>  static void imx_ldb_encoder_prepare(struct drm_encoder *encoder) 
> -- 
> 1.7.10.4
>
 sima.. It looks fine
Sima Baymani Nov. 3, 2013, 10:25 a.m. UTC | #2
On Sunday, November 3, 2013 11:21:44 AM UTC+1, Archana Kumari wrote:
>
>
>
> On Sunday, November 3, 2013 3:48:57 PM UTC+5:30, Sima wrote:
>>
>> Fix checkpatch warning by removing unnecessary braces. 
>> Compile-tested the single file. 
>>
>> Signed-off-by: Sima Baymani <sima.b...@gmail.com> 
>> --- 
>>  drivers/staging/imx-drm/imx-ldb.c |    3 +-- 
>>  1 file changed, 1 insertion(+), 2 deletions(-) 
>>
>> diff --git a/drivers/staging/imx-drm/imx-ldb.c 
>> b/drivers/staging/imx-drm/imx-ldb.c 
>> index 654bf03..bae58ea 100644 
>> --- a/drivers/staging/imx-drm/imx-ldb.c 
>> +++ b/drivers/staging/imx-drm/imx-ldb.c 
>> @@ -167,9 +167,8 @@ static void imx_ldb_set_clock(struct imx_ldb *ldb, 
>> int mux, int chno, 
>>   
>>          /* set display clock mux to LDB input clock */ 
>>          ret = clk_set_parent(ldb->clk_sel[mux], ldb->clk[chno]); 
>> -        if (ret) { 
>> +        if (ret) 
>>                  dev_err(ldb->dev, "unable to set di%d parent clock to 
>> ldb_di%d\n", mux, chno); 
>> -        } 
>>  } 
>>   
>>  static void imx_ldb_encoder_prepare(struct drm_encoder *encoder) 
>> -- 
>> 1.7.10.4
>>
>  sima.. It looks fine
>

<3 thanks for having a look!

-Sima
Josh Triplett Nov. 3, 2013, 6:04 p.m. UTC | #3
On Sun, Nov 03, 2013 at 11:18:57AM +0100, Sima Baymani wrote:
> Fix checkpatch warning by removing unnecessary braces.
> Compile-tested the single file.
> 
> Signed-off-by: Sima Baymani <sima.baymani@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  drivers/staging/imx-drm/imx-ldb.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/imx-drm/imx-ldb.c b/drivers/staging/imx-drm/imx-ldb.c
> index 654bf03..bae58ea 100644
> --- a/drivers/staging/imx-drm/imx-ldb.c
> +++ b/drivers/staging/imx-drm/imx-ldb.c
> @@ -167,9 +167,8 @@ static void imx_ldb_set_clock(struct imx_ldb *ldb, int mux, int chno,
>  
>  	/* set display clock mux to LDB input clock */
>  	ret = clk_set_parent(ldb->clk_sel[mux], ldb->clk[chno]);
> -	if (ret) {
> +	if (ret)
>  		dev_err(ldb->dev, "unable to set di%d parent clock to ldb_di%d\n", mux, chno);
> -	}
>  }
>  
>  static void imx_ldb_encoder_prepare(struct drm_encoder *encoder)
> -- 
> 1.7.10.4
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
Greg KH Nov. 10, 2013, 4:10 p.m. UTC | #4
On Sun, Nov 03, 2013 at 11:18:57AM +0100, Sima Baymani wrote:
> Fix checkpatch warning by removing unnecessary braces.
> Compile-tested the single file.
> 
> Signed-off-by: Sima Baymani <sima.baymani@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> Reviewed-by: Archana Kumari <archanakumari959@gmail.com>

Applied, thanks,

greg k-h

Patch
diff mbox

diff --git a/drivers/staging/imx-drm/imx-ldb.c b/drivers/staging/imx-drm/imx-ldb.c
index 654bf03..bae58ea 100644
--- a/drivers/staging/imx-drm/imx-ldb.c
+++ b/drivers/staging/imx-drm/imx-ldb.c
@@ -167,9 +167,8 @@  static void imx_ldb_set_clock(struct imx_ldb *ldb, int mux, int chno,
 
 	/* set display clock mux to LDB input clock */
 	ret = clk_set_parent(ldb->clk_sel[mux], ldb->clk[chno]);
-	if (ret) {
+	if (ret)
 		dev_err(ldb->dev, "unable to set di%d parent clock to ldb_di%d\n", mux, chno);
-	}
 }
 
 static void imx_ldb_encoder_prepare(struct drm_encoder *encoder)