[OPW,kernel,01/11] Staging: tidspbridge: Fix foo ** bar should be foo **bar in cmm.c
diff mbox

Message ID d0f6f1329c11c68dc5ffb641bc7b1b92b5449819.1384089927.git.rashika.kheria@gmail.com
State New, archived
Headers show

Commit Message

Rashika Nov. 10, 2013, 1:26 p.m. UTC
This patch fixes the following checkpatch.pl warning in pmgr/cmm.c-
ERROR: "foo ** bar" should be "foo **bar"

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
 drivers/staging/tidspbridge/pmgr/cmm.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Andrew Grover Nov. 10, 2013, 7:54 p.m. UTC | #1
On Sun, Nov 10, 2013 at 5:26 AM, Rashika Kheria <rashika.kheria@gmail.com>wrote:

> This patch fixes the following checkpatch.pl warning in pmgr/cmm.c-
> ERROR: "foo ** bar" should be "foo **bar"
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> ---
>  drivers/staging/tidspbridge/pmgr/cmm.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/tidspbridge/pmgr/cmm.c
> b/drivers/staging/tidspbridge/pmgr/cmm.c
> index 4a800da..011145e 100644
> --- a/drivers/staging/tidspbridge/pmgr/cmm.c
> +++ b/drivers/staging/tidspbridge/pmgr/cmm.c
> @@ -359,7 +359,7 @@ int cmm_free_buf(struct cmm_object *hcmm_mgr, void
> *buf_pa, u32 ul_seg_id)
>   *      Return the communication memory manager object for this device.
>   *      This is typically called from the client process.
>   */
> -int cmm_get_handle(void *hprocessor, struct cmm_object ** ph_cmm_mgr)
> +int cmm_get_handle(void *hprocessor, struct cmm_object **ph_cmm_mgr)
>  {
>         int status = 0;
>         struct dev_object *hdev_obj;
> @@ -828,7 +828,7 @@ int cmm_xlator_free_buf(struct cmm_xlatorobject
> *xlator, void *buf_va)
>   *  Purpose:
>   *      Set/Get translator info.
>   */
> -int cmm_xlator_info(struct cmm_xlatorobject *xlator, u8 ** paddr,
> +int cmm_xlator_info(struct cmm_xlatorobject *xlator, u8 **paddr,
>                            u32 ul_size, u32 segm_id, bool set_info)
>  {
>         struct cmm_xlator *xlator_obj = (struct cmm_xlator *)xlator;
> --
> 1.7.9.5
>

Hi Rashika,

I'd suggest a little less fine-grained patches. Since this entire series is
to tidspbridge/pmgr, you can group all line break patches into a single
patch, and then group all the "space between ** and foo" patches together,
and so on.

It's a bit of a judgment call, but for trivially-correct changes like
whitespace I think it's preferable to group them more.

Regards -- Andy
Greg Kroah-Hartman Nov. 10, 2013, 8:13 p.m. UTC | #2
On Sun, Nov 10, 2013 at 06:56:40PM +0530, Rashika Kheria wrote:
> This patch fixes the following checkpatch.pl warning in pmgr/cmm.c-
> ERROR: "foo ** bar" should be "foo **bar"
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

All 11 patches applied, thanks.

greg k-h
Rashika Nov. 11, 2013, 6:59 a.m. UTC | #3
On Mon, Nov 11, 2013 at 1:24 AM, Andrew Grover <andy.grover@gmail.com> wrote:
> On Sun, Nov 10, 2013 at 5:26 AM, Rashika Kheria <rashika.kheria@gmail.com>
> wrote:
>>
>> This patch fixes the following checkpatch.pl warning in pmgr/cmm.c-
>> ERROR: "foo ** bar" should be "foo **bar"
>>
>> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
>> ---
>>  drivers/staging/tidspbridge/pmgr/cmm.c |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/tidspbridge/pmgr/cmm.c
>> b/drivers/staging/tidspbridge/pmgr/cmm.c
>> index 4a800da..011145e 100644
>> --- a/drivers/staging/tidspbridge/pmgr/cmm.c
>> +++ b/drivers/staging/tidspbridge/pmgr/cmm.c
>> @@ -359,7 +359,7 @@ int cmm_free_buf(struct cmm_object *hcmm_mgr, void
>> *buf_pa, u32 ul_seg_id)
>>   *      Return the communication memory manager object for this device.
>>   *      This is typically called from the client process.
>>   */
>> -int cmm_get_handle(void *hprocessor, struct cmm_object ** ph_cmm_mgr)
>> +int cmm_get_handle(void *hprocessor, struct cmm_object **ph_cmm_mgr)
>>  {
>>         int status = 0;
>>         struct dev_object *hdev_obj;
>> @@ -828,7 +828,7 @@ int cmm_xlator_free_buf(struct cmm_xlatorobject
>> *xlator, void *buf_va)
>>   *  Purpose:
>>   *      Set/Get translator info.
>>   */
>> -int cmm_xlator_info(struct cmm_xlatorobject *xlator, u8 ** paddr,
>> +int cmm_xlator_info(struct cmm_xlatorobject *xlator, u8 **paddr,
>>                            u32 ul_size, u32 segm_id, bool set_info)
>>  {
>>         struct cmm_xlator *xlator_obj = (struct cmm_xlator *)xlator;
>> --
>> 1.7.9.5
>
>
> Hi Rashika,
>
> I'd suggest a little less fine-grained patches. Since this entire series is
> to tidspbridge/pmgr, you can group all line break patches into a single
> patch, and then group all the "space between ** and foo" patches together,
> and so on.
>
> It's a bit of a judgment call, but for trivially-correct changes like
> whitespace I think it's preferable to group them more.
>
> Regards -- Andy

Hi Andrew,

Thanks for your suggestion. I will keep that in mind for my future patches.

Thanks,

Patch
diff mbox

diff --git a/drivers/staging/tidspbridge/pmgr/cmm.c b/drivers/staging/tidspbridge/pmgr/cmm.c
index 4a800da..011145e 100644
--- a/drivers/staging/tidspbridge/pmgr/cmm.c
+++ b/drivers/staging/tidspbridge/pmgr/cmm.c
@@ -359,7 +359,7 @@  int cmm_free_buf(struct cmm_object *hcmm_mgr, void *buf_pa, u32 ul_seg_id)
  *      Return the communication memory manager object for this device.
  *      This is typically called from the client process.
  */
-int cmm_get_handle(void *hprocessor, struct cmm_object ** ph_cmm_mgr)
+int cmm_get_handle(void *hprocessor, struct cmm_object **ph_cmm_mgr)
 {
 	int status = 0;
 	struct dev_object *hdev_obj;
@@ -828,7 +828,7 @@  int cmm_xlator_free_buf(struct cmm_xlatorobject *xlator, void *buf_va)
  *  Purpose:
  *      Set/Get translator info.
  */
-int cmm_xlator_info(struct cmm_xlatorobject *xlator, u8 ** paddr,
+int cmm_xlator_info(struct cmm_xlatorobject *xlator, u8 **paddr,
 			   u32 ul_size, u32 segm_id, bool set_info)
 {
 	struct cmm_xlator *xlator_obj = (struct cmm_xlator *)xlator;