[OPW,kernel] Staging: gdm72xx: fix code styling warnings in gdm_qos.c
diff mbox

Message ID c2fcae91-abb8-43ae-8411-a3e0e135f70c@googlegroups.com
State New, archived
Headers show

Commit Message

asemahfouz@gmail.com Nov. 11, 2013, 8:01 p.m. UTC
This patch fixes two code styling warnings in the file gdm_qos.c that is part of the source files of the driver gdm72xx

Signed-off-by: Aya Mahfouz <asemahfouz@gmail.com>


checkpatches.pl message:

WARNING: space prohibited before semicolon
#100: FILE: staging/gdm72xx/gdm_qos.c:100:
+    for (i = 0 ; i < QOS_MAX; i++) {

WARNING: unnecessary whitespace before a quoted newline
#380: FILE: staging/gdm72xx/gdm_qos.c:380:
+               "QoS ERROR: csr Update Error / Wrong index (%d) \n",

total: 0 errors, 2 warnings, 444 lines checked


     }

Comments

Sarah Sharp Nov. 11, 2013, 11:59 p.m. UTC | #1
On Mon, Nov 11, 2013 at 12:01:09PM -0800, asemahfouz@gmail.com wrote:
> 
> 
> This patch fixes two code styling warnings in the file gdm_qos.c that is part of the source files of the driver gdm72xx
> 
> Signed-off-by: Aya Mahfouz <asemahfouz@gmail.com>

Please fix your .git/config or git-send-email configuration file to
include your name.  Your From: header on your email doesn't include your
name, which means it doesn't match your Signed-off-by line.  You may
have to use `git commit --amend --author="Your Name"` to fix your commit
authorship information.

Sarah Sharp

> 
> 
> checkpatches.pl message:
> 
> WARNING: space prohibited before semicolon
> #100: FILE: staging/gdm72xx/gdm_qos.c:100:
> +    for (i = 0 ; i < QOS_MAX; i++) {
> 
> WARNING: unnecessary whitespace before a quoted newline
> #380: FILE: staging/gdm72xx/gdm_qos.c:380:
> +               "QoS ERROR: csr Update Error / Wrong index (%d) \n",
> 
> total: 0 errors, 2 warnings, 444 lines checked
> 
> 
> diff --git a/drivers/staging/gdm72xx/gdm_qos.c 
> b/drivers/staging/gdm72xx/gdm_qos.c
> index cc36924..245109e 100644
> --- a/drivers/staging/gdm72xx/gdm_qos.c
> +++ b/drivers/staging/gdm72xx/gdm_qos.c
> @@ -97,7 +97,7 @@ void gdm_qos_init(void *nic_ptr)
>      struct qos_cb_s *qcb = &nic->qos;
>      int i;
>  
> -    for (i = 0 ; i < QOS_MAX; i++) {
> +    for (i = 0; i < QOS_MAX; i++) {
>          INIT_LIST_HEAD(&qcb->qos_list[i]);
>          qcb->csr[i].qos_buf_count = 0;
>          qcb->csr[i].enabled = 0;
> @@ -377,7 +377,7 @@ void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, 
> int size)
>      index = get_csr(qcb, SFID, 1);
>      if (index == -1) {
>          netdev_err(nic->netdev,
> -               "QoS ERROR: csr Update Error / Wrong index (%d) \n",
> +               "QoS ERROR: csr Update Error / Wrong index (%d)\n",
>                 index);
>          return;
>      }
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

Patch
diff mbox

diff --git a/drivers/staging/gdm72xx/gdm_qos.c 
b/drivers/staging/gdm72xx/gdm_qos.c
index cc36924..245109e 100644
--- a/drivers/staging/gdm72xx/gdm_qos.c
+++ b/drivers/staging/gdm72xx/gdm_qos.c
@@ -97,7 +97,7 @@  void gdm_qos_init(void *nic_ptr)
     struct qos_cb_s *qcb = &nic->qos;
     int i;
 
-    for (i = 0 ; i < QOS_MAX; i++) {
+    for (i = 0; i < QOS_MAX; i++) {
         INIT_LIST_HEAD(&qcb->qos_list[i]);
         qcb->csr[i].qos_buf_count = 0;
         qcb->csr[i].enabled = 0;
@@ -377,7 +377,7 @@  void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, 
int size)
     index = get_csr(qcb, SFID, 1);
     if (index == -1) {
         netdev_err(nic->netdev,
-               "QoS ERROR: csr Update Error / Wrong index (%d) \n",
+               "QoS ERROR: csr Update Error / Wrong index (%d)\n",
                index);
         return;