Message ID | 1385921962-19843-11-git-send-email-takasi-y@ops.dti.ne.jp (mailing list archive) |
---|---|
State | Changes Requested |
Headers | show |
On Mon, Dec 02, 2013 at 03:19:22AM +0900, takasi-y@ops.dti.ne.jp wrote: > From: Takashi Yoshii <takasi-y@ops.dti.ne.jp> > > Add board info for r2a11302 on-board PMIC to access with spidev. This doesn't sound clever - why is the PMIC being accessed with spidev and not with an MFD integrated into the relevant kernel frameworks? Apart from the issue of integrating in the normal way for Linus the PMIC typically has the ability to cause lasting physical damage to the system.
Hi Yoshii-san, On Mon, Dec 2, 2013 at 2:24 PM, Mark Brown <broonie@kernel.org> wrote: > On Mon, Dec 02, 2013 at 03:19:22AM +0900, takasi-y@ops.dti.ne.jp wrote: >> From: Takashi Yoshii <takasi-y@ops.dti.ne.jp> >> >> Add board info for r2a11302 on-board PMIC to access with spidev. > > This doesn't sound clever - why is the PMIC being accessed with spidev > and not with an MFD integrated into the relevant kernel frameworks? > Apart from the issue of integrating in the normal way for Linus the PMIC > typically has the ability to cause lasting physical damage to the > system. Do you have a test application to talk to the PMIC, so I can test if everything works? Perhaps this can be turned into a proper PMIC driver? Thanks in advance! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-shmobile/board-koelsch.c b/arch/arm/mach-shmobile/board-koelsch.c index b4add4c..5ff65ff 100644 --- a/arch/arm/mach-shmobile/board-koelsch.c +++ b/arch/arm/mach-shmobile/board-koelsch.c @@ -27,6 +27,7 @@ #include <linux/pinctrl/machine.h> #include <linux/platform_data/gpio-rcar.h> #include <linux/platform_device.h> +#include <linux/spi/spi.h> #include <mach/common.h> #include <mach/r8a7791.h> #include <mach/rcar-gen2.h> @@ -79,6 +80,15 @@ static const struct gpio_keys_platform_data koelsch_keys_pdata __initconst = { .nbuttons = ARRAY_SIZE(gpio_buttons), }; +static const struct spi_board_info spi_bus[] __initconst = { + { + .modalias = "spidev", + .max_speed_hz = 6000000, + .mode = SPI_MODE_3, + .bus_num = 1, + }, +}; + static const struct pinctrl_map koelsch_pinctrl_map[] = { /* SCIF0 (CN19: DEBUG SERIAL0) */ PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.6", "pfc-r8a7791", @@ -110,6 +120,7 @@ static void __init koelsch_add_standard_devices(void) platform_device_register_data(&platform_bus, "gpio-keys", -1, &koelsch_keys_pdata, sizeof(koelsch_keys_pdata)); + spi_register_board_info(spi_bus, ARRAY_SIZE(spi_bus)); } static const char * const koelsch_boards_compat_dt[] __initconst = {