diff mbox

ARM: OMAP4: hwmod data: correct the idlemodes for spinlock

Message ID 1387838928-57745-1-git-send-email-s-anna@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Suman Anna Dec. 23, 2013, 10:48 p.m. UTC
The spinlock module's SYSCONFIG register does not support
smart wakeup, so remove this flag from the idle modes in
the spinlock hwmod definition.

Signed-off-by: Suman Anna <s-anna@ti.com>
---
 arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Paul Walmsley Dec. 26, 2013, 4:49 a.m. UTC | #1
(cc Benoît)

On Mon, 23 Dec 2013, Suman Anna wrote:

> The spinlock module's SYSCONFIG register does not support
> smart wakeup, so remove this flag from the idle modes in
> the spinlock hwmod definition.
> 
> Signed-off-by: Suman Anna <s-anna@ti.com>

Benoît Cousson is the primary maintainer of this file that you're 
changing:

$ scripts/get_maintainer.pl -f arch/arm/mach-omap2/omap_hwmod_44xx_data.c
"Benoît Cousson" <bcousson@baylibre.com> (maintainer:OMAP HWMOD DATA F...)
Tony Lindgren <tony@atomide.com> (maintainer:OMAP SUPPORT)
Russell King <linux@arm.linux.org.uk> (maintainer:ARM PORT)
linux-omap@vger.kernel.org (open list:OMAP HWMOD DATA F...)
linux-arm-kernel@lists.infradead.org (moderated list:ARM SUB-ARCHITECT...)
linux-kernel@vger.kernel.org (open list)
$

Please make sure that he's part of the address list when patches are sent 
that apply against this file.  


- Paul
Tony Lindgren March 13, 2014, 8:25 p.m. UTC | #2
* Paul Walmsley <paul@pwsan.com> [131225 20:51]:
> (cc Benoît)
> 
> On Mon, 23 Dec 2013, Suman Anna wrote:
> 
> > The spinlock module's SYSCONFIG register does not support
> > smart wakeup, so remove this flag from the idle modes in
> > the spinlock hwmod definition.
> > 
> > Signed-off-by: Suman Anna <s-anna@ti.com>
> 
> Benoît Cousson is the primary maintainer of this file that you're 
> changing:
> 
> $ scripts/get_maintainer.pl -f arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> "Benoît Cousson" <bcousson@baylibre.com> (maintainer:OMAP HWMOD DATA F...)
> Tony Lindgren <tony@atomide.com> (maintainer:OMAP SUPPORT)
> Russell King <linux@arm.linux.org.uk> (maintainer:ARM PORT)
> linux-omap@vger.kernel.org (open list:OMAP HWMOD DATA F...)
> linux-arm-kernel@lists.infradead.org (moderated list:ARM SUB-ARCHITECT...)
> linux-kernel@vger.kernel.org (open list)
> $
> 
> Please make sure that he's part of the address list when patches are sent 
> that apply against this file.  

FYI untagging this in my inbox assuming it's being resent or queued by Paul.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Paul Walmsley March 13, 2014, 9:02 p.m. UTC | #3
On Thu, 13 Mar 2014, Tony Lindgren wrote:

> * Paul Walmsley <paul@pwsan.com> [131225 20:51]:
> > (cc Benoît)
> > 
> > On Mon, 23 Dec 2013, Suman Anna wrote:
> > 
> > > The spinlock module's SYSCONFIG register does not support
> > > smart wakeup, so remove this flag from the idle modes in
> > > the spinlock hwmod definition.
> > > 
> > > Signed-off-by: Suman Anna <s-anna@ti.com>
> > 
> > Benoît Cousson is the primary maintainer of this file that you're 
> > changing:
> > 
> > $ scripts/get_maintainer.pl -f arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> > "Benoît Cousson" <bcousson@baylibre.com> (maintainer:OMAP HWMOD DATA F...)
> > Tony Lindgren <tony@atomide.com> (maintainer:OMAP SUPPORT)
> > Russell King <linux@arm.linux.org.uk> (maintainer:ARM PORT)
> > linux-omap@vger.kernel.org (open list:OMAP HWMOD DATA F...)
> > linux-arm-kernel@lists.infradead.org (moderated list:ARM SUB-ARCHITECT...)
> > linux-kernel@vger.kernel.org (open list)
> > $
> > 
> > Please make sure that he's part of the address list when patches are sent 
> > that apply against this file.  
> 
> FYI untagging this in my inbox assuming it's being resent or queued by Paul.

Hmm, seems like it's either you or Benoît who is on the hook for this one.  

Benoît?

Am happy to queue it if either of you want.


- Paul
Benoit Cousson March 13, 2014, 9:07 p.m. UTC | #4
Hi Paul,

On 13/03/2014 22:02, Paul Walmsley wrote:
> On Thu, 13 Mar 2014, Tony Lindgren wrote:
>
>> * Paul Walmsley <paul@pwsan.com> [131225 20:51]:
>>> (cc Benoît)
>>>
>>> On Mon, 23 Dec 2013, Suman Anna wrote:
>>>
>>>> The spinlock module's SYSCONFIG register does not support
>>>> smart wakeup, so remove this flag from the idle modes in
>>>> the spinlock hwmod definition.
>>>>
>>>> Signed-off-by: Suman Anna <s-anna@ti.com>
>>>
>>> Benoît Cousson is the primary maintainer of this file that you're
>>> changing:
>>>
>>> $ scripts/get_maintainer.pl -f arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>>> "Benoît Cousson" <bcousson@baylibre.com> (maintainer:OMAP HWMOD DATA F...)
>>> Tony Lindgren <tony@atomide.com> (maintainer:OMAP SUPPORT)
>>> Russell King <linux@arm.linux.org.uk> (maintainer:ARM PORT)
>>> linux-omap@vger.kernel.org (open list:OMAP HWMOD DATA F...)
>>> linux-arm-kernel@lists.infradead.org (moderated list:ARM SUB-ARCHITECT...)
>>> linux-kernel@vger.kernel.org (open list)
>>> $
>>>
>>> Please make sure that he's part of the address list when patches are sent
>>> that apply against this file.
>>
>> FYI untagging this in my inbox assuming it's being resent or queued by Paul.
>
> Hmm, seems like it's either you or Benoît who is on the hook for this one.
>
> Benoît?
>
> Am happy to queue it if either of you want.

Feel free to queue it, I don't have anything else pending so far, so I 
was not planning to do a pull request.

Acked-by: Benoit Cousson <bcousson@baylibre.com>

Thanks,
Benoit
Tony Lindgren March 13, 2014, 9:09 p.m. UTC | #5
* Benoit Cousson <bcousson@baylibre.com> [140313 14:11]:
> Hi Paul,
> 
> On 13/03/2014 22:02, Paul Walmsley wrote:
> >On Thu, 13 Mar 2014, Tony Lindgren wrote:
> >
> >>* Paul Walmsley <paul@pwsan.com> [131225 20:51]:
> >>>(cc Benoît)
> >>>
> >>>On Mon, 23 Dec 2013, Suman Anna wrote:
> >>>
> >>>>The spinlock module's SYSCONFIG register does not support
> >>>>smart wakeup, so remove this flag from the idle modes in
> >>>>the spinlock hwmod definition.
> >>>>
> >>>>Signed-off-by: Suman Anna <s-anna@ti.com>
> >>>
> >>>Benoît Cousson is the primary maintainer of this file that you're
> >>>changing:
> >>>
> >>>$ scripts/get_maintainer.pl -f arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> >>>"Benoît Cousson" <bcousson@baylibre.com> (maintainer:OMAP HWMOD DATA F...)
> >>>Tony Lindgren <tony@atomide.com> (maintainer:OMAP SUPPORT)
> >>>Russell King <linux@arm.linux.org.uk> (maintainer:ARM PORT)
> >>>linux-omap@vger.kernel.org (open list:OMAP HWMOD DATA F...)
> >>>linux-arm-kernel@lists.infradead.org (moderated list:ARM SUB-ARCHITECT...)
> >>>linux-kernel@vger.kernel.org (open list)
> >>>$
> >>>
> >>>Please make sure that he's part of the address list when patches are sent
> >>>that apply against this file.
> >>
> >>FYI untagging this in my inbox assuming it's being resent or queued by Paul.
> >
> >Hmm, seems like it's either you or Benoît who is on the hook for this one.
> >
> >Benoît?
> >
> >Am happy to queue it if either of you want.
> 
> Feel free to queue it, I don't have anything else pending so far, so
> I was not planning to do a pull request.
> 
> Acked-by: Benoit Cousson <bcousson@baylibre.com>

OK applying into omap-for-v3.15/fixes then, thanks.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index 3318cae9..1219280 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -2541,8 +2541,7 @@  static struct omap_hwmod_class_sysconfig omap44xx_spinlock_sysc = {
 	.sysc_flags	= (SYSC_HAS_AUTOIDLE | SYSC_HAS_CLOCKACTIVITY |
 			   SYSC_HAS_ENAWAKEUP | SYSC_HAS_SIDLEMODE |
 			   SYSC_HAS_SOFTRESET | SYSS_HAS_RESET_STATUS),
-	.idlemodes	= (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART |
-			   SIDLE_SMART_WKUP),
+	.idlemodes	= (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART),
 	.sysc_fields	= &omap_hwmod_sysc_type1,
 };