diff mbox

tools: Allow building on Android after noinst_PROGRAMS is not defined any more

Message ID 1390387265-5971-1-git-send-email-tvrtko.ursulin@linux.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Tvrtko Ursulin Jan. 22, 2014, 10:41 a.m. UTC 
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Looks like filter-out macro gets silently unhappy about an undefined variable.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 tools/Android.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lespiau, Damien Jan. 23, 2014, 8:59 a.m. UTC | #1 
On Wed, Jan 22, 2014 at 10:41:05AM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Looks like filter-out macro gets silently unhappy about an undefined variable.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

and pushed. Thanks for the patch.
diff mbox

Patch

diff --git a/tools/Android.mk b/tools/Android.mk
index 5bda489..99c39b7 100644
--- a/tools/Android.mk
+++ b/tools/Android.mk
@@ -65,6 +65,6 @@  skip_tools_list := \
     intel_vga_read \
     intel_vga_write
 
-tools_list := $(filter-out $(skip_tools_list),$(bin_PROGRAMS) $(noinst_PROGRAMS))
+tools_list := $(filter-out $(skip_tools_list),$(bin_PROGRAMS))
 
 $(foreach item,$(tools_list),$(eval $(call add_tool,$(item))))