| Message ID | 1392055835-6494-1-git-send-email-rogerq@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
$subject probably needs clarity. On 02/10/2014 12:10 PM, Roger Quadros wrote: > The OMAP EHCI controller is not compatible with the EHCI > platform HCD driver so don't claim that we are. might want to refer to the change in drivers/usb/host/ehci-platform.c that created this regression as well. we also probably want to make better explanation about this issue and why we think this is the correct fix for it - for example, question Kevin asked in [1] > > This fixes boot on OMAP platforms with CONFIG_USB_EHCI_HCD_PLATFORM=y > e.g. multi_v7_defconfig > > Reported-by: Nishanth Menon <nm@ti.com> > Signed-off-by: Roger Quadros <rogerq@ti.com> > --- [1] http://marc.info/?t=139204803900004&r=1&w=2
On 02/10/2014 08:10 PM, Roger Quadros wrote: > The OMAP EHCI controller is not compatible with the EHCI > platform HCD driver so don't claim that we are. > > This fixes boot on OMAP platforms with CONFIG_USB_EHCI_HCD_PLATFORM=y > e.g. multi_v7_defconfig > > Reported-by: Nishanth Menon <nm@ti.com> > Signed-off-by: Roger Quadros <rogerq@ti.com> Please ignore this patch as Hans has agreed to do a more proper fix in http://article.gmane.org/gmane.comp.hardware.netbook.arm.sunxi/7015 cheers, -roger > --- > arch/arm/boot/dts/omap3.dtsi | 2 +- > arch/arm/boot/dts/omap4.dtsi | 2 +- > arch/arm/boot/dts/omap5.dtsi | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi > index a5fc83b..6b5dbf8 100644 > --- a/arch/arm/boot/dts/omap3.dtsi > +++ b/arch/arm/boot/dts/omap3.dtsi > @@ -641,7 +641,7 @@ > }; > > usbhsehci: ehci@48064800 { > - compatible = "ti,ehci-omap", "usb-ehci"; > + compatible = "ti,ehci-omap"; > reg = <0x48064800 0x400>; > interrupt-parent = <&intc>; > interrupts = <77>; > diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi > index d3f8a6e..f5d754b 100644 > --- a/arch/arm/boot/dts/omap4.dtsi > +++ b/arch/arm/boot/dts/omap4.dtsi > @@ -706,7 +706,7 @@ > }; > > usbhsehci: ehci@4a064c00 { > - compatible = "ti,ehci-omap", "usb-ehci"; > + compatible = "ti,ehci-omap"; > reg = <0x4a064c00 0x400>; > interrupt-parent = <&gic>; > interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>; > diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi > index a72813a..42fcffd 100644 > --- a/arch/arm/boot/dts/omap5.dtsi > +++ b/arch/arm/boot/dts/omap5.dtsi > @@ -784,7 +784,7 @@ > }; > > usbhsehci: ehci@4a064c00 { > - compatible = "ti,ehci-omap", "usb-ehci"; > + compatible = "ti,ehci-omap"; > reg = <0x4a064c00 0x400>; > interrupt-parent = <&gic>; > interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>; > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/11/2014 07:53 AM, Roger Quadros wrote: > On 02/10/2014 08:10 PM, Roger Quadros wrote: >> The OMAP EHCI controller is not compatible with the EHCI >> platform HCD driver so don't claim that we are. >> >> This fixes boot on OMAP platforms with CONFIG_USB_EHCI_HCD_PLATFORM=y >> e.g. multi_v7_defconfig >> >> Reported-by: Nishanth Menon <nm@ti.com> >> Signed-off-by: Roger Quadros <rogerq@ti.com> > > Please ignore this patch as Hans has agreed to do a more proper fix in > > http://article.gmane.org/gmane.comp.hardware.netbook.arm.sunxi/7015 umm.. even then, drivers/usb/host/ehci-ppc-of.c claims compatibility with usb,ehci -> and we wont function with that driver either.
Hi, On 02/11/2014 03:17 PM, Nishanth Menon wrote: > On 02/11/2014 07:53 AM, Roger Quadros wrote: >> On 02/10/2014 08:10 PM, Roger Quadros wrote: >>> The OMAP EHCI controller is not compatible with the EHCI >>> platform HCD driver so don't claim that we are. >>> >>> This fixes boot on OMAP platforms with CONFIG_USB_EHCI_HCD_PLATFORM=y >>> e.g. multi_v7_defconfig >>> >>> Reported-by: Nishanth Menon <nm@ti.com> >>> Signed-off-by: Roger Quadros <rogerq@ti.com> >> >> Please ignore this patch as Hans has agreed to do a more proper fix in >> >> http://article.gmane.org/gmane.comp.hardware.netbook.arm.sunxi/7015 > umm.. even then, drivers/usb/host/ehci-ppc-of.c claims compatibility > with usb,ehci -> and we wont function with that driver either. Right, but that has never been an issue as no kernel will ever include both ppc and omap support. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/11/2014 08:35 AM, Hans de Goede wrote: > On 02/11/2014 03:17 PM, Nishanth Menon wrote: >> On 02/11/2014 07:53 AM, Roger Quadros wrote: >>> On 02/10/2014 08:10 PM, Roger Quadros wrote: >>>> The OMAP EHCI controller is not compatible with the EHCI >>>> platform HCD driver so don't claim that we are. >>>> >>>> This fixes boot on OMAP platforms with CONFIG_USB_EHCI_HCD_PLATFORM=y >>>> e.g. multi_v7_defconfig >>>> >>>> Reported-by: Nishanth Menon <nm@ti.com> >>>> Signed-off-by: Roger Quadros <rogerq@ti.com> >>> >>> Please ignore this patch as Hans has agreed to do a more proper fix in >>> >>> http://article.gmane.org/gmane.comp.hardware.netbook.arm.sunxi/7015 >> umm.. even then, drivers/usb/host/ehci-ppc-of.c claims compatibility >> with usb,ehci -> and we wont function with that driver either. > > Right, but that has never been an issue as no kernel will ever include > both ppc and omap support. Conceptually, we have compatibility string today in dts description that maps a driver that cant ever handle the device. I dont have strong opinions either way.. just something i noticed with a git grep..
diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi index a5fc83b..6b5dbf8 100644 --- a/arch/arm/boot/dts/omap3.dtsi +++ b/arch/arm/boot/dts/omap3.dtsi @@ -641,7 +641,7 @@ }; usbhsehci: ehci@48064800 { - compatible = "ti,ehci-omap", "usb-ehci"; + compatible = "ti,ehci-omap"; reg = <0x48064800 0x400>; interrupt-parent = <&intc>; interrupts = <77>; diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi index d3f8a6e..f5d754b 100644 --- a/arch/arm/boot/dts/omap4.dtsi +++ b/arch/arm/boot/dts/omap4.dtsi @@ -706,7 +706,7 @@ }; usbhsehci: ehci@4a064c00 { - compatible = "ti,ehci-omap", "usb-ehci"; + compatible = "ti,ehci-omap"; reg = <0x4a064c00 0x400>; interrupt-parent = <&gic>; interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>; diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi index a72813a..42fcffd 100644 --- a/arch/arm/boot/dts/omap5.dtsi +++ b/arch/arm/boot/dts/omap5.dtsi @@ -784,7 +784,7 @@ }; usbhsehci: ehci@4a064c00 { - compatible = "ti,ehci-omap", "usb-ehci"; + compatible = "ti,ehci-omap"; reg = <0x4a064c00 0x400>; interrupt-parent = <&gic>; interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>;
The OMAP EHCI controller is not compatible with the EHCI platform HCD driver so don't claim that we are. This fixes boot on OMAP platforms with CONFIG_USB_EHCI_HCD_PLATFORM=y e.g. multi_v7_defconfig Reported-by: Nishanth Menon <nm@ti.com> Signed-off-by: Roger Quadros <rogerq@ti.com> --- arch/arm/boot/dts/omap3.dtsi | 2 +- arch/arm/boot/dts/omap4.dtsi | 2 +- arch/arm/boot/dts/omap5.dtsi | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)