diff mbox

[2/3] spi: s3c64xx: Let spi core handle validating transfer length

Message ID 1393327109.6723.3.camel@phoenix (mailing list archive)
State Accepted
Commit 382ab20e8138083966b7bde141d3c6a79dda68bf
Headers show

Commit Message

Axel Lin Feb. 25, 2014, 11:18 a.m. UTC
spi core will handle validating transfer length since commit 4d94bd21b333
"spi: core: Validate length of the transfers in message".
So remove the same checking in this driver.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/spi/spi-s3c64xx.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

Mark Brown Feb. 25, 2014, 12:27 p.m. UTC | #1
On Tue, Feb 25, 2014 at 07:18:29PM +0800, Axel Lin wrote:
> spi core will handle validating transfer length since commit 4d94bd21b333
> "spi: core: Validate length of the transfers in message".
> So remove the same checking in this driver.

Applied, thanks.
diff mbox

Patch

diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 9ad5e3e..f19cd97 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -697,13 +697,6 @@  static int s3c64xx_spi_transfer_one(struct spi_master *master,
 	bpw = xfer->bits_per_word;
 	speed = xfer->speed_hz ? : spi->max_speed_hz;
 
-	if (xfer->len % (bpw / 8)) {
-		dev_err(&spi->dev,
-			"Xfer length(%u) not a multiple of word size(%u)\n",
-			xfer->len, bpw / 8);
-		return -EIO;
-	}
-
 	if (bpw != sdd->cur_bpw || speed != sdd->cur_speed) {
 		sdd->cur_bpw = bpw;
 		sdd->cur_speed = speed;