spi: sh-hspi: Remove hspi_cleanup function
diff mbox

Message ID 1393468050.25819.1.camel@phoenix
State New, archived
Delegated to: Mark Brown
Headers show

Commit Message

Axel Lin Feb. 27, 2014, 2:27 a.m. UTC
hspi_cleanup() is doing nothing except print a non-useful debug message,
so remove it.  Also remove unused hspi2info macro.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/spi/spi-sh-hspi.c | 11 -----------
 1 file changed, 11 deletions(-)

Comments

Geert Uytterhoeven Feb. 27, 2014, 9:07 a.m. UTC | #1
On Thu, Feb 27, 2014 at 3:27 AM, Axel Lin <axel.lin@ingics.com> wrote:
> hspi_cleanup() is doing nothing except print a non-useful debug message,
> so remove it.  Also remove unused hspi2info macro.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mark Brown Feb. 27, 2014, 11:09 a.m. UTC | #2
On Thu, Feb 27, 2014 at 10:27:30AM +0800, Axel Lin wrote:
> hspi_cleanup() is doing nothing except print a non-useful debug message,
> so remove it.  Also remove unused hspi2info macro.

Applied, thanks.

Patch
diff mbox

diff --git a/drivers/spi/spi-sh-hspi.c b/drivers/spi/spi-sh-hspi.c
index 3c5d3b8..48becd2 100644
--- a/drivers/spi/spi-sh-hspi.c
+++ b/drivers/spi/spi-sh-hspi.c
@@ -46,8 +46,6 @@ 
 /* SPSR */
 #define RXFL	(1 << 2)
 
-#define hspi2info(h)	(h->dev->platform_data)
-
 struct hspi_priv {
 	void __iomem *addr;
 	struct spi_master *master;
@@ -230,14 +228,6 @@  static int hspi_transfer_one_message(struct spi_master *master,
 	return ret;
 }
 
-static void hspi_cleanup(struct spi_device *spi)
-{
-	struct hspi_priv *hspi = spi_master_get_devdata(spi->master);
-	struct device *dev = hspi->dev;
-
-	dev_dbg(dev, "%s cleanup\n", spi->modalias);
-}
-
 static int hspi_probe(struct platform_device *pdev)
 {
 	struct resource *res;
@@ -284,7 +274,6 @@  static int hspi_probe(struct platform_device *pdev)
 	pm_runtime_enable(&pdev->dev);
 
 	master->bus_num		= pdev->id;
-	master->cleanup		= hspi_cleanup;
 	master->mode_bits	= SPI_CPOL | SPI_CPHA;
 	master->dev.of_node	= pdev->dev.of_node;
 	master->auto_runtime_pm = true;