diff mbox

NFSv4: Don't retry server trunking discovery on timeouts (v2)

Message ID 1394207049-2447-1-git-send-email-steved@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Steve Dickson March 7, 2014, 3:44 p.m. UTC
To allow background mounts to process into background,
server trunking discovery needs to return the -ETIMEDOUT
error to the mount command instead of endless retrying in
the kernel.

Signed-off-by: Steve Dickson <steved@redhat.com>
---
 fs/nfs/nfs4state.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Comments

Steve Dickson March 17, 2014, 2:45 p.m. UTC | #1
Trond,

On 03/07/2014 10:44 AM, Steve Dickson wrote:
> To allow background mounts to process into background,
> server trunking discovery needs to return the -ETIMEDOUT
> error to the mount command instead of endless retrying in
> the kernel.
> 
> Signed-off-by: Steve Dickson <steved@redhat.com>
Any chance of reconsidering this patch? Or come up
with a better a way for the kernel to start returning ETIMEOUTS
and ECONNREFUSEDs again? 

steved.
> ---
>  fs/nfs/nfs4state.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
> index e1a4721..e0e4d34 100644
> --- a/fs/nfs/nfs4state.c
> +++ b/fs/nfs/nfs4state.c
> @@ -2083,8 +2083,9 @@ again:
>  	switch (status) {
>  	case 0:
>  		break;
> -	case -NFS4ERR_DELAY:
>  	case -ETIMEDOUT:
> +		break;
> +	case -NFS4ERR_DELAY:
>  	case -EAGAIN:
>  		ssleep(1);
>  	case -NFS4ERR_STALE_CLIENTID:
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Steve Dickson March 17, 2014, 2:55 p.m. UTC | #2
On 03/17/2014 10:45 AM, Steve Dickson wrote:
> Trond,
> 
> On 03/07/2014 10:44 AM, Steve Dickson wrote:
>> To allow background mounts to process into background,
>> server trunking discovery needs to return the -ETIMEDOUT
>> error to the mount command instead of endless retrying in
>> the kernel.
>>
>> Signed-off-by: Steve Dickson <steved@redhat.com>
> Any chance of reconsidering this patch? Or come up
> with a better a way for the kernel to start returning ETIMEOUTS
> and ECONNREFUSEDs again? 
At least in the mount path I should say.... 

steved.
> 
> steved.
>> ---
>>  fs/nfs/nfs4state.c |    3 ++-
>>  1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
>> index e1a4721..e0e4d34 100644
>> --- a/fs/nfs/nfs4state.c
>> +++ b/fs/nfs/nfs4state.c
>> @@ -2083,8 +2083,9 @@ again:
>>  	switch (status) {
>>  	case 0:
>>  		break;
>> -	case -NFS4ERR_DELAY:
>>  	case -ETIMEDOUT:
>> +		break;
>> +	case -NFS4ERR_DELAY:
>>  	case -EAGAIN:
>>  		ssleep(1);
>>  	case -NFS4ERR_STALE_CLIENTID:
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
index e1a4721..e0e4d34 100644
--- a/fs/nfs/nfs4state.c
+++ b/fs/nfs/nfs4state.c
@@ -2083,8 +2083,9 @@  again:
 	switch (status) {
 	case 0:
 		break;
-	case -NFS4ERR_DELAY:
 	case -ETIMEDOUT:
+		break;
+	case -NFS4ERR_DELAY:
 	case -EAGAIN:
 		ssleep(1);
 	case -NFS4ERR_STALE_CLIENTID: