ASoC: tlv320aic23: Remove spurious bits per word setting
diff mbox

Message ID 1394631195-10480-1-git-send-email-broonie@kernel.org
State Accepted
Commit 051389e250d018f7c38c8043c54aa8979d4b2cab
Headers show

Commit Message

Mark Brown March 12, 2014, 1:33 p.m. UTC
From: Mark Brown <broonie@linaro.org>

regmap should handle any byte ordering issues required, it is looking for
a byte stream from the bus, so don't set 16 bits per word. This is likely
to have tested out OK due to use of an unmerged SPI controller driver.

Signed-off-by: Mark Brown <broonie@linaro.org>
---
 sound/soc/codecs/tlv320aic23-spi.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Max Filippov March 12, 2014, 5:30 p.m. UTC | #1
On Wed, Mar 12, 2014 at 5:33 PM, Mark Brown <broonie@kernel.org> wrote:
> From: Mark Brown <broonie@linaro.org>
>
> regmap should handle any byte ordering issues required, it is looking for
> a byte stream from the bus, so don't set 16 bits per word. This is likely
> to have tested out OK due to use of an unmerged SPI controller driver.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
>  sound/soc/codecs/tlv320aic23-spi.c | 1 -
>  1 file changed, 1 deletion(-)

Tested-by: Max Filippov <jcmvbkbc@gmail.com>

> diff --git a/sound/soc/codecs/tlv320aic23-spi.c b/sound/soc/codecs/tlv320aic23-spi.c
> index 585aea436c6a..3b387e41d75d 100644
> --- a/sound/soc/codecs/tlv320aic23-spi.c
> +++ b/sound/soc/codecs/tlv320aic23-spi.c
> @@ -25,7 +25,6 @@ static int aic23_spi_probe(struct spi_device *spi)
>
>         dev_dbg(&spi->dev, "probing tlv320aic23 spi device\n");
>
> -       spi->bits_per_word = 16;
>         spi->mode = SPI_MODE_0;
>         ret = spi_setup(spi);
>         if (ret < 0)
> --
> 1.9.0
>

Patch
diff mbox

diff --git a/sound/soc/codecs/tlv320aic23-spi.c b/sound/soc/codecs/tlv320aic23-spi.c
index 585aea436c6a..3b387e41d75d 100644
--- a/sound/soc/codecs/tlv320aic23-spi.c
+++ b/sound/soc/codecs/tlv320aic23-spi.c
@@ -25,7 +25,6 @@  static int aic23_spi_probe(struct spi_device *spi)
 
 	dev_dbg(&spi->dev, "probing tlv320aic23 spi device\n");
 
-	spi->bits_per_word = 16;
 	spi->mode = SPI_MODE_0;
 	ret = spi_setup(spi);
 	if (ret < 0)