ASoC: tlv320aic31xx: Staticise non-exported symbols
diff mbox

Message ID 1394732900-17182-1-git-send-email-broonie@kernel.org
State Accepted
Commit 9296f4da3bafa23d8b9abc5cd271a66ea8f90cd2
Headers show

Commit Message

Mark Brown March 13, 2014, 5:48 p.m. UTC
From: Mark Brown <broonie@linaro.org>

Signed-off-by: Mark Brown <broonie@linaro.org>
---
 sound/soc/codecs/tlv320aic31xx.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Jyri Sarha March 14, 2014, 8:09 a.m. UTC | #1
On 03/13/2014 07:48 PM, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> Signed-off-by: Mark Brown <broonie@linaro.org>


Acked-by: Jyri Sarha <jsarha@it.com>

/me has added one more thing to his patch sending check list.

Best reggards,
Jyri
Lars-Peter Clausen March 14, 2014, 8:31 a.m. UTC | #2
On 03/14/2014 09:09 AM, Jyri Sarha wrote:
> On 03/13/2014 07:48 PM, Mark Brown wrote:
>> From: Mark Brown <broonie@linaro.org>
>>
>> Signed-off-by: Mark Brown <broonie@linaro.org>
>
>
> Acked-by: Jyri Sarha <jsarha@it.com>
>
> /me has added one more thing to his patch sending check list.

What I typically try to do before submitting a patch is run

make C=2 .../driver.o
make C=2 CHECK=scripts/coccicheck .../driver.o
make C=2 CHECK="smatch --full-path -p=kernel" .../driver.o

that will typically catch these little mistakes. Also of course 
scripts/checkpatch.pl on the patch itself.

- Lars
Mark Brown March 14, 2014, 10:23 a.m. UTC | #3
On Fri, Mar 14, 2014 at 09:31:44AM +0100, Lars-Peter Clausen wrote:
> On 03/14/2014 09:09 AM, Jyri Sarha wrote:

> >/me has added one more thing to his patch sending check list.

> What I typically try to do before submitting a patch is run

> make C=2 .../driver.o
> make C=2 CHECK=scripts/coccicheck .../driver.o
> make C=2 CHECK="smatch --full-path -p=kernel" .../driver.o

> that will typically catch these little mistakes. Also of course
> scripts/checkpatch.pl on the patch itself.

Make sure you're running against the latest development code when you do
this too.

Patch
diff mbox

diff --git a/sound/soc/codecs/tlv320aic31xx.c b/sound/soc/codecs/tlv320aic31xx.c
index dcdc5751048f..d3517a919776 100644
--- a/sound/soc/codecs/tlv320aic31xx.c
+++ b/sound/soc/codecs/tlv320aic31xx.c
@@ -129,7 +129,7 @@  static const struct regmap_range_cfg aic31xx_ranges[] = {
 	},
 };
 
-struct regmap_config aic31xx_i2c_regmap = {
+static const struct regmap_config aic31xx_i2c_regmap = {
 	.reg_bits = 8,
 	.val_bits = 8,
 	.writeable_reg = aic31xx_writeable,
@@ -321,9 +321,9 @@  static const struct snd_kcontrol_new ldac_in_control =
 static const struct snd_kcontrol_new rdac_in_control =
 	SOC_DAPM_ENUM("DAC Right Input", rdac_in_enum);
 
-int aic31xx_wait_bits(struct aic31xx_priv *aic31xx, unsigned int reg,
-		      unsigned int mask, unsigned int wbits, int sleep,
-		      int count)
+static int aic31xx_wait_bits(struct aic31xx_priv *aic31xx, unsigned int reg,
+			     unsigned int mask, unsigned int wbits, int sleep,
+			     int count)
 {
 	unsigned int bits;
 	int counter = count;
@@ -1177,7 +1177,7 @@  static void aic31xx_pdata_from_of(struct aic31xx_priv *aic31xx)
 }
 #endif /* CONFIG_OF */
 
-void aic31xx_device_init(struct aic31xx_priv *aic31xx)
+static void aic31xx_device_init(struct aic31xx_priv *aic31xx)
 {
 	int ret, i;