spi: clps711x: Enable driver compilation with COMPILE_TEST
diff mbox

Message ID 1395822170.7555.0.camel@phoenix
State New, archived
Headers show

Commit Message

Axel Lin March 26, 2014, 8:22 a.m. UTC
This helps increasing build testing coverage.
This driver uses SYSCON APIs, so it needs to depend on MFD_SYSCON.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/spi/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Alexander Shiyan March 26, 2014, 8:31 a.m. UTC | #1
Wed, 26 Mar 2014 16:22:50 +0800 ?? Axel Lin <axel.lin@ingics.com>:
> This helps increasing build testing coverage.
> This driver uses SYSCON APIs, so it needs to depend on MFD_SYSCON.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/spi/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 1ee6a54..78ca395 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -150,7 +150,8 @@ config SPI_BUTTERFLY
>  
>  config SPI_CLPS711X
>  	tristate "CLPS711X host SPI controller"
> -	depends on ARCH_CLPS711X
> +	depends on MFD_SYSCON
> +	depends on ARCH_CLPS711X || COMPILE_TEST
>  	help
>  	  This enables dedicated general purpose SPI/Microwire1-compatible
>  	  master mode interface (SSI1) for CLPS711X-based CPUs.
> -- 

MFD_SYSCON is selected by ARCH_CLPS711X and this symbol is
not needed for COMPILE_TEST, so I am do not agree with this patch.

---
Axel Lin March 26, 2014, 8:34 a.m. UTC | #2
>
> MFD_SYSCON is selected by ARCH_CLPS711X and this symbol is
> not needed for COMPILE_TEST, so I am do not agree with this patch.

COMPILE_TEST is purely for build test.
I have no problem to build this driver for x86 and some arm configs
with this patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alexander Shiyan March 26, 2014, 8:36 a.m. UTC | #3
Wed, 26 Mar 2014 16:34:50 +0800 ?? Axel Lin <axel.lin@ingics.com>:
> >
> > MFD_SYSCON is selected by ARCH_CLPS711X and this symbol is
> > not needed for COMPILE_TEST, so I am do not agree with this patch.
> 
> COMPILE_TEST is purely for build test.
> I have no problem to build this driver for x86 and some arm configs
> with this patch.

Yes. but driver can be compiled without MFD_SYSCON in such cases.

---
Axel Lin March 26, 2014, 8:53 a.m. UTC | #4
2014-03-26 16:36 GMT+08:00 Alexander Shiyan <shc_work@mail.ru>:
> Wed, 26 Mar 2014 16:34:50 +0800 ?? Axel Lin <axel.lin@ingics.com>:
>> >
>> > MFD_SYSCON is selected by ARCH_CLPS711X and this symbol is
>> > not needed for COMPILE_TEST, so I am do not agree with this patch.
>>
>> COMPILE_TEST is purely for build test.
>> I have no problem to build this driver for x86 and some arm configs
>> with this patch.
>
> Yes. but driver can be compiled without MFD_SYSCON in such cases.

Ok. v2 is no the way.

Thanks,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 1ee6a54..78ca395 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -150,7 +150,8 @@  config SPI_BUTTERFLY
 
 config SPI_CLPS711X
 	tristate "CLPS711X host SPI controller"
-	depends on ARCH_CLPS711X
+	depends on MFD_SYSCON
+	depends on ARCH_CLPS711X || COMPILE_TEST
 	help
 	  This enables dedicated general purpose SPI/Microwire1-compatible
 	  master mode interface (SSI1) for CLPS711X-based CPUs.