diff mbox

[6/6] ASoC: rt5640: Change the setting method of idle_bias_off

Message ID 1396009710-21324-6-git-send-email-oder_chiou@realtek.com (mailing list archive)
State Accepted
Commit 09caf300540c4a610dbe6e46afdab18f365be7e7
Headers show

Commit Message

Oder Chiou March 28, 2014, 12:28 p.m. UTC
The patch moves the idle_bias_off setting to struct "soc_codec_dev_rt5640".

Signed-off-by: Oder Chiou <oder_chiou@realtek.com>
---
 sound/soc/codecs/rt5640.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown March 28, 2014, 12:54 p.m. UTC | #1
On Fri, Mar 28, 2014 at 08:28:30PM +0800, Oder Chiou wrote:
> The patch moves the idle_bias_off setting to struct "soc_codec_dev_rt5640".

This doesn't seem to apply against current code, can you please check
and resend?
Oder Chiou March 31, 2014, 2:24 a.m. UTC | #2
> -----Original Message-----
> From: Mark Brown [mailto:broonie@kernel.org]
> Sent: Friday, March 28, 2014 8:54 PM
> To: Oder Chiou
> Cc: lgirdwood@gmail.com; alsa-devel@alsa-project.org; Bard Liao; Flove
> Subject: Re: [PATCH 6/6] ASoC: rt5640: Change the setting method ofidle_bias_off
> 
> On Fri, Mar 28, 2014 at 08:28:30PM +0800, Oder Chiou wrote:
> > The patch moves the idle_bias_off setting to struct "soc_codec_dev_rt5640".
> 
> This doesn't seem to apply against current code, can you please check and resend?
I've resent it, thank you.
diff mbox

Patch

diff --git a/sound/soc/codecs/rt5640.c b/sound/soc/codecs/rt5640.c
index b5014a2..2a349b0 100644
--- a/sound/soc/codecs/rt5640.c
+++ b/sound/soc/codecs/rt5640.c
@@ -1879,7 +1879,6 @@  static int rt5640_probe(struct snd_soc_codec *codec)
 
 	rt5640->codec = codec;
 
-	codec->dapm.idle_bias_off = 1;
 	rt5640_set_bias_level(codec, SND_SOC_BIAS_OFF);
 
 	snd_soc_update_bits(codec, RT5640_DUMMY1, 0x0301, 0x0301);
@@ -1988,6 +1987,7 @@  static struct snd_soc_codec_driver soc_codec_dev_rt5640 = {
 	.suspend = rt5640_suspend,
 	.resume = rt5640_resume,
 	.set_bias_level = rt5640_set_bias_level,
+	.idle_bias_off = true,
 	.controls = rt5640_snd_controls,
 	.num_controls = ARRAY_SIZE(rt5640_snd_controls),
 	.dapm_widgets = rt5640_dapm_widgets,