[4/4] ASoC: spdif: Add Vybird and LS1+ compatibles support.
diff mbox

Message ID 1396516257-25354-5-git-send-email-Li.Xiubo@freescale.com
State New, archived
Headers show

Commit Message

Xiubo Li April 3, 2014, 9:10 a.m. UTC
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
---
 sound/soc/fsl/fsl_spdif.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Nicolin Chen April 3, 2014, 12:45 p.m. UTC | #1
On Thu, Apr 03, 2014 at 05:10:57PM +0800, Xiubo Li wrote:
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> ---
>  sound/soc/fsl/fsl_spdif.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
> index 173553c..5c958ca 100644
> --- a/sound/soc/fsl/fsl_spdif.c
> +++ b/sound/soc/fsl/fsl_spdif.c
> @@ -1186,6 +1186,8 @@ static int fsl_spdif_probe(struct platform_device *pdev)
>  
>  static const struct of_device_id fsl_spdif_dt_ids[] = {
>  	{ .compatible = "fsl,imx35-spdif", },
> +	{ .compatible = "fsl,vybird-spdif", },
> +	{ .compatible = "fsl,ls1+-spdif", },

Same comments here.

And just a little reminder:
You are using "fsl,vf610-sai" for fsl_sai.c. I was wondering if you'd better
use "fsl,vf610-spdif" over here as well.

Best regards,
Nicolin

>  	{}
>  };
>  MODULE_DEVICE_TABLE(of, fsl_spdif_dt_ids);
> -- 
> 1.8.4
> 
>
Fabio Estevam April 3, 2014, 2:46 p.m. UTC | #2
On Thu, Apr 3, 2014 at 6:10 AM, Xiubo Li <Li.Xiubo@freescale.com> wrote:
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> ---
>  sound/soc/fsl/fsl_spdif.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
> index 173553c..5c958ca 100644
> --- a/sound/soc/fsl/fsl_spdif.c
> +++ b/sound/soc/fsl/fsl_spdif.c
> @@ -1186,6 +1186,8 @@ static int fsl_spdif_probe(struct platform_device *pdev)
>
>  static const struct of_device_id fsl_spdif_dt_ids[] = {
>         { .compatible = "fsl,imx35-spdif", },
> +       { .compatible = "fsl,vybird-spdif", },

I think you mean vybrid ;-)
Xiubo Li April 4, 2014, 12:40 a.m. UTC | #3
> Subject: Re: [alsa-devel] [PATCH 4/4] ASoC: spdif: Add Vybird and LS1+
> compatibles support.
> 
> On Thu, Apr 3, 2014 at 6:10 AM, Xiubo Li <Li.Xiubo@freescale.com> wrote:
> > Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> > ---
> >  sound/soc/fsl/fsl_spdif.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
> > index 173553c..5c958ca 100644
> > --- a/sound/soc/fsl/fsl_spdif.c
> > +++ b/sound/soc/fsl/fsl_spdif.c
> > @@ -1186,6 +1186,8 @@ static int fsl_spdif_probe(struct platform_device
> *pdev)
> >
> >  static const struct of_device_id fsl_spdif_dt_ids[] = {
> >         { .compatible = "fsl,imx35-spdif", },
> > +       { .compatible = "fsl,vybird-spdif", },
> 
> I think you mean vybrid ;-)
> 
Well yes, you are right.

I will follow GuangYu's advice in another mail.

Thanks,

Brs
Xiubo
Xiubo Li April 4, 2014, 12:41 a.m. UTC | #4
> Subject: Re: [PATCH 4/4] ASoC: spdif: Add Vybird and LS1+ compatibles support.
> 
> On Thu, Apr 03, 2014 at 05:10:57PM +0800, Xiubo Li wrote:
> > Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> > ---
> >  sound/soc/fsl/fsl_spdif.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
> > index 173553c..5c958ca 100644
> > --- a/sound/soc/fsl/fsl_spdif.c
> > +++ b/sound/soc/fsl/fsl_spdif.c
> > @@ -1186,6 +1186,8 @@ static int fsl_spdif_probe(struct platform_device
> *pdev)
> >
> >  static const struct of_device_id fsl_spdif_dt_ids[] = {
> >  	{ .compatible = "fsl,imx35-spdif", },
> > +	{ .compatible = "fsl,vybird-spdif", },
> > +	{ .compatible = "fsl,ls1+-spdif", },
> 
> Same comments here.
> 
> And just a little reminder:
> You are using "fsl,vf610-sai" for fsl_sai.c. I was wondering if you'd better
> use "fsl,vf610-spdif" over here as well.
> 

Please see the next version.

Thanks,

BRs
Xiubo

> Best regards,
> Nicolin
> 
> >  	{}
> >  };
> >  MODULE_DEVICE_TABLE(of, fsl_spdif_dt_ids);
> > --
> > 1.8.4
> >
> >

Patch
diff mbox

diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
index 173553c..5c958ca 100644
--- a/sound/soc/fsl/fsl_spdif.c
+++ b/sound/soc/fsl/fsl_spdif.c
@@ -1186,6 +1186,8 @@  static int fsl_spdif_probe(struct platform_device *pdev)
 
 static const struct of_device_id fsl_spdif_dt_ids[] = {
 	{ .compatible = "fsl,imx35-spdif", },
+	{ .compatible = "fsl,vybird-spdif", },
+	{ .compatible = "fsl,ls1+-spdif", },
 	{}
 };
 MODULE_DEVICE_TABLE(of, fsl_spdif_dt_ids);