[RFC] spi: efm32: Make "efm32,location" property optional
diff mbox

Message ID 1396840732.7635.2.camel@phoenix
State New, archived
Headers show

Commit Message

Axel Lin April 7, 2014, 3:18 a.m. UTC
The spi driver still works even if "efm32,location" property is not provided.
Thus make "efm32,location" property optional.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 Documentation/devicetree/bindings/spi/efm32-spi.txt | 2 ++
 1 file changed, 2 insertions(+)

Comments

Uwe Kleine-K├Ânig April 7, 2014, 6:16 a.m. UTC | #1
Hi Axel,

On Mon, Apr 07, 2014 at 11:18:52AM +0800, Axel Lin wrote:
> The spi driver still works even if "efm32,location" property is not provided.
> Thus make "efm32,location" property optional.
good catch. The changelog is wrong though. You don't make the property
optional, you only adapt the documentation to reality. It would be also
nice to mention the default value (i.e. keeping what is already
configured in the hardware, so its either the reset default 0 or
whatever the bootloader did.) OTOH I'm not sure if that should go into
the binding doc as it sounds Linux specific?

Best regards
Uwe

Patch
diff mbox

diff --git a/Documentation/devicetree/bindings/spi/efm32-spi.txt b/Documentation/devicetree/bindings/spi/efm32-spi.txt
index 8f081c9..33e6040 100644
--- a/Documentation/devicetree/bindings/spi/efm32-spi.txt
+++ b/Documentation/devicetree/bindings/spi/efm32-spi.txt
@@ -8,6 +8,8 @@  Required properties:
 - interrupts: pair specifying rx and tx irq
 - clocks: phandle to the spi clock
 - cs-gpios: see spi-bus.txt
+
+Recommended properties :
 - efm32,location: Value to write to the ROUTE register's LOCATION bitfield to configure the pinmux for the device, see datasheet for values.
 
 Example: