[v2] spi: efm32: Make "efm32,location" property optional
diff mbox

Message ID 1396852971.26619.3.camel@phoenix
State New, archived
Headers show

Commit Message

Axel Lin April 7, 2014, 6:42 a.m. UTC
If "efm32,location" property is not provided, keeping what is already
configured in the hardware, so its either the reset default 0 or whatever
the bootloader did.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 Documentation/devicetree/bindings/spi/efm32-spi.txt | 2 ++
 1 file changed, 2 insertions(+)

Comments

Uwe Kleine-K├Ânig April 7, 2014, 7 a.m. UTC | #1
Hello,

the Subject still suggests a change in the driver.

On Mon, Apr 07, 2014 at 02:42:51PM +0800, Axel Lin wrote:
> If "efm32,location" property is not provided, keeping what is already
> configured in the hardware, so its either the reset default 0 or whatever
> the bootloader did.
I would prefer to have this info in the binding doc.

Best regards
Uwe
 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  Documentation/devicetree/bindings/spi/efm32-spi.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/efm32-spi.txt b/Documentation/devicetree/bindings/spi/efm32-spi.txt
> index 8f081c9..33e6040 100644
> --- a/Documentation/devicetree/bindings/spi/efm32-spi.txt
> +++ b/Documentation/devicetree/bindings/spi/efm32-spi.txt
> @@ -8,6 +8,8 @@ Required properties:
>  - interrupts: pair specifying rx and tx irq
>  - clocks: phandle to the spi clock
>  - cs-gpios: see spi-bus.txt
> +
> +Recommended properties :
>  - efm32,location: Value to write to the ROUTE register's LOCATION bitfield to configure the pinmux for the device, see datasheet for values.
>  
>  Example:
> -- 
> 1.8.3.2
> 
> 
> 
>

Patch
diff mbox

diff --git a/Documentation/devicetree/bindings/spi/efm32-spi.txt b/Documentation/devicetree/bindings/spi/efm32-spi.txt
index 8f081c9..33e6040 100644
--- a/Documentation/devicetree/bindings/spi/efm32-spi.txt
+++ b/Documentation/devicetree/bindings/spi/efm32-spi.txt
@@ -8,6 +8,8 @@  Required properties:
 - interrupts: pair specifying rx and tx irq
 - clocks: phandle to the spi clock
 - cs-gpios: see spi-bus.txt
+
+Recommended properties :
 - efm32,location: Value to write to the ROUTE register's LOCATION bitfield to configure the pinmux for the device, see datasheet for values.
 
 Example: