Patchwork HID: rmi: do not stop the device at the end of probe

login
register
mail settings
Submitter Benjamin Tissoires
Date April 9, 2014, 3:01 p.m.
Message ID <1397055694-6312-1-git-send-email-benjamin.tissoires@redhat.com>
Download mbox | patch
Permalink /patch/3956041/
State New, archived
Delegated to: Jiri Kosina
Headers show

Comments

Benjamin Tissoires - April 9, 2014, 3:01 p.m.
Well, this is embarrassing, if the device is stopped at the end of probe,
we get into big troubles (it even oopses my kernel).

This was a leftover of an attempt to be smart when sending the patch,
I deeply apologies.

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---

Hi Jiri,

well, first thanks for having integrating hid-rmi in your for 3.16 branch.

While backporting it to 3.13 so Fedora can get it, I noticed a tiny difference
(besides formatting) between the version I submitted and the one I asked people
to test...

...facepalm.

Cheers,
Benjamin

 drivers/hid/hid-rmi.c | 1 -
 1 file changed, 1 deletion(-)
Jiri Kosina - April 9, 2014, 3:14 p.m.
On Wed, 9 Apr 2014, Benjamin Tissoires wrote:

> Well, this is embarrassing, if the device is stopped at the end of probe,
> we get into big troubles (it even oopses my kernel).
> 
> This was a leftover of an attempt to be smart when sending the patch,
> I deeply apologies.
> 
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
> 
> Hi Jiri,
> 
> well, first thanks for having integrating hid-rmi in your for 3.16 branch.
> 
> While backporting it to 3.13 so Fedora can get it, I noticed a tiny difference
> (besides formatting) between the version I submitted and the one I asked people
> to test...
> 
> ...facepalm.

Well, I missed that as well when reviewing it. Good catch, now queued on 
top of previous one. Thanks,

Patch

diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
index 699d631..7da9509 100644
--- a/drivers/hid/hid-rmi.c
+++ b/drivers/hid/hid-rmi.c
@@ -848,7 +848,6 @@  static int rmi_probe(struct hid_device *hdev, const struct hid_device_id *id)
 		return -EIO;
 	}
 
-	hid_hw_stop(hdev);
 	return 0;
 }