spi: cadence: Add dependency on ARCH_ZYNQ
diff mbox

Message ID 1397537392-3709-1-git-send-email-harinik@xilinx.com
State New, archived
Headers show

Commit Message

Harini Katakam April 15, 2014, 4:49 a.m. UTC
Add dependency on ARCH_ZYNQ in Kconfig.
This is to fix the build error.

Signed-off-by: Harini Katakam <harinik@xilinx.com>
---
 drivers/spi/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Comments

Mark Brown April 15, 2014, 9:45 a.m. UTC | #1
On Tue, Apr 15, 2014 at 08:11:37AM +0200, Michal Simek wrote:

> I sent the patch for it which solve this problem in generic way.
> http://lkml.org/lkml/2014/4/8/42

> Feel free to give me ACK for it.

Will has been working on this too off and on, he was also trying to
define some semantics for the relaxed versions.  It'd be really good to
address this properly, this is a constant source of make work.
Mark Brown April 15, 2014, 9:49 a.m. UTC | #2
On Tue, Apr 15, 2014 at 10:19:52AM +0530, Harini Katakam wrote:
> Add dependency on ARCH_ZYNQ in Kconfig.
> This is to fix the build error.

This is too strict - ARCH_ARM would be fine (PowerPC also defines the
_relaxed() operaton if you want to include that too).
Will Deacon April 15, 2014, 4:26 p.m. UTC | #3
On Tue, Apr 15, 2014 at 10:45:41AM +0100, Mark Brown wrote:
> On Tue, Apr 15, 2014 at 08:11:37AM +0200, Michal Simek wrote:
> 
> > I sent the patch for it which solve this problem in generic way.
> > http://lkml.org/lkml/2014/4/8/42
> 
> > Feel free to give me ACK for it.
> 
> Will has been working on this too off and on, he was also trying to
> define some semantics for the relaxed versions.  It'd be really good to
> address this properly, this is a constant source of make work.

Yes, I have a series adding relaxed accessors to all architectures (and
asm-generic) along with an attempt at defining some semantics. This came
about from discussion with BenH at the last kernel summit, I just didn't get
around to posting what we came up with.

I should be able to post something this week, but there's still an open
question relating to mmiowb() that I'd like the PPC guys to chime in on.

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index b0f091b..0db219b 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -150,6 +150,7 @@  config SPI_BUTTERFLY
 
 config SPI_CADENCE
 	tristate "Cadence SPI controller"
+	depends on ARCH_ZYNQ
 	depends on SPI_MASTER
 	help
 	  This selects the Cadence SPI controller master driver