[1/6] sound: lx_core: Remove unused defines
diff mbox

Message ID 1397728281-26050-1-git-send-email-maxime.ripard@free-electrons.com
State Accepted
Commit 7b3b302615c3ab9c111d0238107d741146dda701
Headers show

Commit Message

Maxime Ripard April 17, 2014, 9:51 a.m. UTC
Commit f9367f3fbe3c ("ALSA: lx6464es: Remove unused
function in pci/lx6464es/lx_core.c") removed the
lx_dsp_es_check_pipeline function that was the only user
of these defines.

Since they're useless now, simply remove them.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 sound/pci/lx6464es/lx_core.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Takashi Iwai April 18, 2014, 8:01 a.m. UTC | #1
At Thu, 17 Apr 2014 11:51:16 +0200,
Maxime Ripard wrote:
> 
> Commit f9367f3fbe3c ("ALSA: lx6464es: Remove unused
> function in pci/lx6464es/lx_core.c") removed the
> lx_dsp_es_check_pipeline function that was the only user
> of these defines.
> 
> Since they're useless now, simply remove them.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks, applied all patches now.
But, at the next time, please put my correct address to Cc.

Also, for ALSA stuff (except for ASoC), we usually use "ALSA:"
prefix.


Takashi

> ---
>  sound/pci/lx6464es/lx_core.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/sound/pci/lx6464es/lx_core.c b/sound/pci/lx6464es/lx_core.c
> index 2d8e95e9fbe5..6a1d90a308ea 100644
> --- a/sound/pci/lx6464es/lx_core.c
> +++ b/sound/pci/lx6464es/lx_core.c
> @@ -429,11 +429,6 @@ int lx_dsp_read_async_events(struct lx6464es *chip, u32 *data)
>  	return ret;
>  }
>  
> -#define CSES_TIMEOUT        100     /* microseconds */
> -#define CSES_CE             0x0001
> -#define CSES_BROADCAST      0x0002
> -#define CSES_UPDATE_LDSV    0x0004
> -
>  #define PIPE_INFO_TO_CMD(capture, pipe)					\
>  	((u32)((u32)(pipe) | ((capture) ? ID_IS_CAPTURE : 0L)) << ID_OFFSET)
>  
> -- 
> 1.9.1
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
Maxime Ripard April 18, 2014, 9:45 a.m. UTC | #2
Hi,

On Fri, Apr 18, 2014 at 10:01:22AM +0200, Takashi Iwai wrote:
> At Thu, 17 Apr 2014 11:51:16 +0200,
> Maxime Ripard wrote:
> > 
> > Commit f9367f3fbe3c ("ALSA: lx6464es: Remove unused
> > function in pci/lx6464es/lx_core.c") removed the
> > lx_dsp_es_check_pipeline function that was the only user
> > of these defines.
> > 
> > Since they're useless now, simply remove them.
> > 
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> 
> Thanks, applied all patches now.
> But, at the next time, please put my correct address to Cc.

Hmmm, yes, look like it was a typo on my side.. Sorry.

> Also, for ALSA stuff (except for ASoC), we usually use "ALSA:"
> prefix.

Ok, I will.

Thanks!
Maxime

Patch
diff mbox

diff --git a/sound/pci/lx6464es/lx_core.c b/sound/pci/lx6464es/lx_core.c
index 2d8e95e9fbe5..6a1d90a308ea 100644
--- a/sound/pci/lx6464es/lx_core.c
+++ b/sound/pci/lx6464es/lx_core.c
@@ -429,11 +429,6 @@  int lx_dsp_read_async_events(struct lx6464es *chip, u32 *data)
 	return ret;
 }
 
-#define CSES_TIMEOUT        100     /* microseconds */
-#define CSES_CE             0x0001
-#define CSES_BROADCAST      0x0002
-#define CSES_UPDATE_LDSV    0x0004
-
 #define PIPE_INFO_TO_CMD(capture, pipe)					\
 	((u32)((u32)(pipe) | ((capture) ? ID_IS_CAPTURE : 0L)) << ID_OFFSET)