From patchwork Tue Apr 29 11:18:35 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xia Kaixu X-Patchwork-Id: 4087981 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 084039F169 for ; Tue, 29 Apr 2014 14:39:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3F5FD201F9 for ; Tue, 29 Apr 2014 14:39:35 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id E7666201F5 for ; Tue, 29 Apr 2014 14:39:33 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id D2227265626; Tue, 29 Apr 2014 16:39:32 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00, RCVD_IN_SORBS_WEB, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id D82A5265193; Tue, 29 Apr 2014 16:28:09 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 05A05265087; Tue, 29 Apr 2014 13:20:54 +0200 (CEST) Received: from mail-pa0-f50.google.com (mail-pa0-f50.google.com [209.85.220.50]) by alsa0.perex.cz (Postfix) with ESMTP id 7E4E326508C for ; Tue, 29 Apr 2014 13:20:33 +0200 (CEST) Received: by mail-pa0-f50.google.com with SMTP id rd3so53787pab.9 for ; Tue, 29 Apr 2014 04:20:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1sYyqcbiwjAI3ilKkijN2au0PfNHago4U9/e3YbY3+E=; b=B07uGS7eIDSkNMHMg1RD2Zk1bA1tZGAu3vF2X++zmlZwZtT0J/7po/+ofgaQgx7OwL RfsSxDHz6Vqv6NmwQ8Nbt/thNmtgxQJ3ZbTxZoVQZMrvCne1tyhdYvSNZgMr3+rkZZ0w b0wP3qgIQpC/AoH+R4MzQV66M+yOwr4btPHKHnVSFfGdKIL3H4cDbnPzaKKMF7oz+cxd T0/bVdazwyZz/L/W+07H/BDOpLubabGKnrOjLZCj4ePylyvtQQwqMq+x4qWV4dQccoEy rkHgVNM+08ZTbJ4rNiTmMHYhV7PWB90qScVp84pavhbm5N6MhgyvYpBB5O5JLigzC7oC cpzg== X-Gm-Message-State: ALoCoQl+o5TZzC/3QVtLg3E+9HPJ/ZzmRaeAxsiSSkXqBwzwTmz+b2W3eRk16nlH7OxX1K3ipwVC X-Received: by 10.66.221.99 with SMTP id qd3mr32475821pac.46.1398770427170; Tue, 29 Apr 2014 04:20:27 -0700 (PDT) Received: from localhost.localdomain ([218.17.215.175]) by mx.google.com with ESMTPSA id xo9sm108641006pab.18.2014.04.29.04.20.22 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 29 Apr 2014 04:20:26 -0700 (PDT) From: Xia Kaixu To: linux-kernel@vger.kernel.org Date: Tue, 29 Apr 2014 19:18:35 +0800 Message-Id: <1398770316-19715-15-git-send-email-kaixu.xia@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1398770316-19715-1-git-send-email-kaixu.xia@linaro.org> References: <1398770316-19715-1-git-send-email-kaixu.xia@linaro.org> X-Mailman-Approved-At: Tue, 29 Apr 2014 16:27:55 +0200 Cc: alsa-devel@alsa-project.org, linaro-kernel@lists.linaro.org, arnd@arndb.de, Liam Girdwood , Peter Ujfalusi , Mark Brown , linux-omap@vger.kernel.org, Jarkko Nikula , kaixu.xia@linaro.org Subject: [alsa-devel] [PATCH 14/15] ASoC: Amstrad E3 needs TTY support for codec X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Arnd Bergmann The cx20442 codec driver used here requires the TTY layer to be enabled, or we get a link error: sound/built-in.o: In function `cx20442_codec_remove': cx20442.c:398: undefined reference to `tty_hangup' sound/built-in.o: In function `ams_delta_remove': ams-delta.c:613: undefined reference to `tty_unregister_ldisc' sound/built-in.o: In function `ams_delta_cx20442_init': ams-delta.c:559: undefined reference to `tty_register_ldisc' This adds the missing dependency in the E3 configuration, there was already one for the codec. Signed-off-by: Arnd Bergmann Signed-off-by: Xia Kaixu Cc: Mark Brown Cc: Liam Girdwood Cc: Peter Ujfalusi Cc: Jarkko Nikula Cc: linux-omap@vger.kernel.org Cc: alsa-devel@alsa-project.org --- sound/soc/omap/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig index 2796af9..d44463a 100644 --- a/sound/soc/omap/Kconfig +++ b/sound/soc/omap/Kconfig @@ -37,7 +37,7 @@ config SND_OMAP_SOC_RX51 config SND_OMAP_SOC_AMS_DELTA tristate "SoC Audio support for Amstrad E3 (Delta) videophone" - depends on SND_OMAP_SOC && MACH_AMS_DELTA + depends on SND_OMAP_SOC && MACH_AMS_DELTA && TTY select SND_OMAP_SOC_MCBSP select SND_SOC_CX20442 help