| Message ID | 1399936220-17123-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e6b0d896ab0597d37422cae3cef3e789431549eb |
| Headers | show |
Hi Thank you for your help > Use the %pap printk specifier to print resource_size_t variables. This > fixes warnings on platforms where resource_size_t has a different size > than int. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > sound/soc/sh/rcar/gen.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > Would it be possible to get this patch in v3.16 ? > > diff --git a/sound/soc/sh/rcar/gen.c b/sound/soc/sh/rcar/gen.c > index 50a1ef3..1d5c025 100644 > --- a/sound/soc/sh/rcar/gen.c > +++ b/sound/soc/sh/rcar/gen.c > @@ -252,13 +252,13 @@ static int rsnd_gen2_probe(struct platform_device *pdev, > return ret; > > dev_dbg(dev, "Gen2 device probed\n"); > - dev_dbg(dev, "SCU : %08x => %p\n", scu_res->start, > + dev_dbg(dev, "SCU : %pap => %p\n", &scu_res->start, > gen->base[RSND_GEN2_SCU]); > - dev_dbg(dev, "ADG : %08x => %p\n", adg_res->start, > + dev_dbg(dev, "ADG : %pap => %p\n", &adg_res->start, > gen->base[RSND_GEN2_ADG]); > - dev_dbg(dev, "SSIU : %08x => %p\n", ssiu_res->start, > + dev_dbg(dev, "SSIU : %pap => %p\n", &ssiu_res->start, > gen->base[RSND_GEN2_SSIU]); > - dev_dbg(dev, "SSI : %08x => %p\n", ssi_res->start, > + dev_dbg(dev, "SSI : %pap => %p\n", &ssi_res->start, > gen->base[RSND_GEN2_SSI]); > > return 0; > @@ -345,11 +345,11 @@ static int rsnd_gen1_probe(struct platform_device *pdev, > return ret; > > dev_dbg(dev, "Gen1 device probed\n"); > - dev_dbg(dev, "SRU : %08x => %p\n", sru_res->start, > + dev_dbg(dev, "SRU : %pap => %p\n", &sru_res->start, > gen->base[RSND_GEN1_SRU]); > - dev_dbg(dev, "ADG : %08x => %p\n", adg_res->start, > + dev_dbg(dev, "ADG : %pap => %p\n", &adg_res->start, > gen->base[RSND_GEN1_ADG]); > - dev_dbg(dev, "SSI : %08x => %p\n", ssi_res->start, > + dev_dbg(dev, "SSI : %pap => %p\n", &ssi_res->start, > gen->base[RSND_GEN1_SSI]); > > return 0; > -- > Regards, > > Laurent Pinchart >
On Mon, May 12, 2014 at 04:53:44PM -0700, Kuninori Morimoto wrote: > > Hi > > Thank you for your help > > > Use the %pap printk specifier to print resource_size_t variables. This > > fixes warnings on platforms where resource_size_t has a different size > > than int. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > --- > > Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Morimoto-san, should Mark Brown need to be CCed on a re-post in order for him to see this? > > sound/soc/sh/rcar/gen.c | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > Would it be possible to get this patch in v3.16 ? > > > > diff --git a/sound/soc/sh/rcar/gen.c b/sound/soc/sh/rcar/gen.c > > index 50a1ef3..1d5c025 100644 > > --- a/sound/soc/sh/rcar/gen.c > > +++ b/sound/soc/sh/rcar/gen.c > > @@ -252,13 +252,13 @@ static int rsnd_gen2_probe(struct platform_device *pdev, > > return ret; > > > > dev_dbg(dev, "Gen2 device probed\n"); > > - dev_dbg(dev, "SCU : %08x => %p\n", scu_res->start, > > + dev_dbg(dev, "SCU : %pap => %p\n", &scu_res->start, > > gen->base[RSND_GEN2_SCU]); > > - dev_dbg(dev, "ADG : %08x => %p\n", adg_res->start, > > + dev_dbg(dev, "ADG : %pap => %p\n", &adg_res->start, > > gen->base[RSND_GEN2_ADG]); > > - dev_dbg(dev, "SSIU : %08x => %p\n", ssiu_res->start, > > + dev_dbg(dev, "SSIU : %pap => %p\n", &ssiu_res->start, > > gen->base[RSND_GEN2_SSIU]); > > - dev_dbg(dev, "SSI : %08x => %p\n", ssi_res->start, > > + dev_dbg(dev, "SSI : %pap => %p\n", &ssi_res->start, > > gen->base[RSND_GEN2_SSI]); > > > > return 0; > > @@ -345,11 +345,11 @@ static int rsnd_gen1_probe(struct platform_device *pdev, > > return ret; > > > > dev_dbg(dev, "Gen1 device probed\n"); > > - dev_dbg(dev, "SRU : %08x => %p\n", sru_res->start, > > + dev_dbg(dev, "SRU : %pap => %p\n", &sru_res->start, > > gen->base[RSND_GEN1_SRU]); > > - dev_dbg(dev, "ADG : %08x => %p\n", adg_res->start, > > + dev_dbg(dev, "ADG : %pap => %p\n", &adg_res->start, > > gen->base[RSND_GEN1_ADG]); > > - dev_dbg(dev, "SSI : %08x => %p\n", ssi_res->start, > > + dev_dbg(dev, "SSI : %pap => %p\n", &ssi_res->start, > > gen->base[RSND_GEN1_SSI]); > > > > return 0; > > -- > > Regards, > > > > Laurent Pinchart > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
Hi >>> Use the %pap printk specifier to print resource_size_t variables. This >>> fixes warnings on platforms where resource_size_t has a different size >>> than int. >>> >>> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> >>> --- >> >> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Morimoto-san, should Mark Brown need to be CCed on a re-post > in order for him to see this? Ahh, I didn't notice that Mark wasn't CCed. He never (?) accepts patch which doesn't have "To" him. Please use this address, broonie@kernel.org
On Wed, May 14, 2014 at 11:33:08AM +0900, Kuninori Morimoto wrote: > >Morimoto-san, should Mark Brown need to be CCed on a re-post > >in order for him to see this? > Ahh, I didn't notice that Mark wasn't CCed. > He never (?) accepts patch which doesn't have "To" him. Well, sometimes I do but it's much less likely I'll even see an e-mail that only went to the lists than if it goes to my inbox and since CCing the maintainer is one of the things SubmittingPatches tells you to do people really ought to know better. Anyway, I saw this one and applied it.
Hi Mark, On Thursday 15 May 2014 11:14:50 Mark Brown wrote: > On Wed, May 14, 2014 at 11:33:08AM +0900, Kuninori Morimoto wrote: > > >Morimoto-san, should Mark Brown need to be CCed on a re-post > > >in order for him to see this? > > > > Ahh, I didn't notice that Mark wasn't CCed. > > He never (?) accepts patch which doesn't have "To" him. > > Well, sometimes I do but it's much less likely I'll even see an e-mail > that only went to the lists than if it goes to my inbox and since CCing > the maintainer is one of the things SubmittingPatches tells you to do > people really ought to know better. Anyway, I saw this one and applied > it. My bad, sorry. I suppose I'm too used to maintainers who prefer not to be CC'ed :-/
diff --git a/sound/soc/sh/rcar/gen.c b/sound/soc/sh/rcar/gen.c index 50a1ef3..1d5c025 100644 --- a/sound/soc/sh/rcar/gen.c +++ b/sound/soc/sh/rcar/gen.c @@ -252,13 +252,13 @@ static int rsnd_gen2_probe(struct platform_device *pdev, return ret; dev_dbg(dev, "Gen2 device probed\n"); - dev_dbg(dev, "SCU : %08x => %p\n", scu_res->start, + dev_dbg(dev, "SCU : %pap => %p\n", &scu_res->start, gen->base[RSND_GEN2_SCU]); - dev_dbg(dev, "ADG : %08x => %p\n", adg_res->start, + dev_dbg(dev, "ADG : %pap => %p\n", &adg_res->start, gen->base[RSND_GEN2_ADG]); - dev_dbg(dev, "SSIU : %08x => %p\n", ssiu_res->start, + dev_dbg(dev, "SSIU : %pap => %p\n", &ssiu_res->start, gen->base[RSND_GEN2_SSIU]); - dev_dbg(dev, "SSI : %08x => %p\n", ssi_res->start, + dev_dbg(dev, "SSI : %pap => %p\n", &ssi_res->start, gen->base[RSND_GEN2_SSI]); return 0; @@ -345,11 +345,11 @@ static int rsnd_gen1_probe(struct platform_device *pdev, return ret; dev_dbg(dev, "Gen1 device probed\n"); - dev_dbg(dev, "SRU : %08x => %p\n", sru_res->start, + dev_dbg(dev, "SRU : %pap => %p\n", &sru_res->start, gen->base[RSND_GEN1_SRU]); - dev_dbg(dev, "ADG : %08x => %p\n", adg_res->start, + dev_dbg(dev, "ADG : %pap => %p\n", &adg_res->start, gen->base[RSND_GEN1_ADG]); - dev_dbg(dev, "SSI : %08x => %p\n", ssi_res->start, + dev_dbg(dev, "SSI : %pap => %p\n", &ssi_res->start, gen->base[RSND_GEN1_SSI]); return 0;
Use the %pap printk specifier to print resource_size_t variables. This fixes warnings on platforms where resource_size_t has a different size than int. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- sound/soc/sh/rcar/gen.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) Would it be possible to get this patch in v3.16 ?