diff mbox

[2/2] ASoC: rt5651: Do not use rtd->codec

Message ID 1400479384-19108-2-git-send-email-lars@metafoo.de (mailing list archive)
State Accepted
Commit c1406846e4e1ae92c4fb96fcb4532a63a2bceb21
Headers show

Commit Message

Lars-Peter Clausen May 19, 2014, 6:03 a.m. UTC
rtd->codec does not necessarily point to the CODEC instance for which the
callback was called (e.g. for CODEC<->CODEC or multi-CODEC links). Use
dai->codec instead.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
 sound/soc/codecs/rt5651.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Mark Brown May 19, 2014, 4:16 p.m. UTC | #1
On Mon, May 19, 2014 at 08:03:04AM +0200, Lars-Peter Clausen wrote:
> rtd->codec does not necessarily point to the CODEC instance for which the
> callback was called (e.g. for CODEC<->CODEC or multi-CODEC links). Use
> dai->codec instead.

Applied, thanks.
diff mbox

Patch

diff --git a/sound/soc/codecs/rt5651.c b/sound/soc/codecs/rt5651.c
index f785b81..9c88d89 100644
--- a/sound/soc/codecs/rt5651.c
+++ b/sound/soc/codecs/rt5651.c
@@ -1368,8 +1368,7 @@  static int get_clk_info(int sclk, int rate)
 static int rt5651_hw_params(struct snd_pcm_substream *substream,
 	struct snd_pcm_hw_params *params, struct snd_soc_dai *dai)
 {
-	struct snd_soc_pcm_runtime *rtd = substream->private_data;
-	struct snd_soc_codec *codec = rtd->codec;
+	struct snd_soc_codec *codec = dai->codec;
 	struct rt5651_priv *rt5651 = snd_soc_codec_get_drvdata(codec);
 	unsigned int val_len = 0, val_clk, mask_clk;
 	int pre_div, bclk_ms, frame_size;