wl1251: correct definitions for 0th bit defines
diff mbox

Message ID 20090817151814.GB13125@hash.localnet
State Not Applicable, archived
Headers show

Commit Message

Bob Copeland Aug. 17, 2009, 3:18 p.m. UTC
ACX_SLV_SOFT_RESET_BIT and ACX_REG_EEPROM_START_BIT are both defined
as "1" in the vendor driver code, but they were defined to be BIT(1)
("2") here.  

The SOFT_RESET typo ensures that wl1251_boot_soft_reset() doesn't;
as a result the device hangs when trying to reprogram the PLL
registers while running.

Signed-off-by: Bob Copeland <me@bobcopeland.com>
---
 drivers/net/wireless/wl12xx/wl1251_reg.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

Kalle Valo Aug. 17, 2009, 3:44 p.m. UTC | #1
Bob Copeland <me@bobcopeland.com> writes:

> ACX_SLV_SOFT_RESET_BIT and ACX_REG_EEPROM_START_BIT are both defined
> as "1" in the vendor driver code, but they were defined to be BIT(1)
> ("2") here.  
>
> The SOFT_RESET typo ensures that wl1251_boot_soft_reset() doesn't;
> as a result the device hangs when trying to reprogram the PLL
> registers while running.

My bad, thanks for fixing this.

> Signed-off-by: Bob Copeland <me@bobcopeland.com>

Acked-by: Kalle Valo <kalle.valo@nokia.com>

Patch
diff mbox

diff --git a/drivers/net/wireless/wl12xx/wl1251_reg.h b/drivers/net/wireless/wl12xx/wl1251_reg.h
index 2de47cc..86a8666 100644
--- a/drivers/net/wireless/wl12xx/wl1251_reg.h
+++ b/drivers/net/wireless/wl12xx/wl1251_reg.h
@@ -309,8 +309,8 @@  enum wl12xx_acx_int_reg {
 	ACX_REG_TABLE_LEN
 };
 
-#define ACX_SLV_SOFT_RESET_BIT   BIT(1)
-#define ACX_REG_EEPROM_START_BIT BIT(1)
+#define ACX_SLV_SOFT_RESET_BIT   BIT(0)
+#define ACX_REG_EEPROM_START_BIT BIT(0)
 
 /* Command/Information Mailbox Pointers */