[2/2,v4] btrfs: usage error should not be logged into system log
diff mbox

Message ID 1400813402-27474-2-git-send-email-anand.jain@oracle.com
State Accepted
Headers show

Commit Message

Anand Jain May 23, 2014, 2:50 a.m. UTC
From: Anand Jain <Anand.Jain@oracle.com>

I have an opinion that system logs under /var/log/ are
valuable info to investigate the real system issues at
the data center. People handling data center issues
do spend a lot time and efforts analyzing messages
files. Having usage error logged into system log is
something we should avoid.

Signed-off-by: Anand Jain <Anand.Jain@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.cz>
 v4: commit reword. Thanks Koen
 v3: rebase again
 v2: rebase

 fs/btrfs/sysfs.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff mbox

diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
index e12e2be..522d023 100644
--- a/fs/btrfs/sysfs.c
+++ b/fs/btrfs/sysfs.c
@@ -381,11 +381,8 @@  static ssize_t btrfs_label_store(struct kobject *kobj,
 	p_len = strcspn(buf, "\n");
-	if (p_len >= BTRFS_LABEL_SIZE) {
-		pr_err("BTRFS: unable to set label with more than %d bytes\n",
-		       BTRFS_LABEL_SIZE - 1);
+	if (p_len >= BTRFS_LABEL_SIZE)
 		return -EINVAL;
-	}
 	trans = btrfs_start_transaction(root, 0);
 	if (IS_ERR(trans))