ASoC: fsl: Remove dependencies of boards for SND_SOC_EUKREA_TLV320
diff mbox

Message ID 1400843461-24991-1-git-send-email-shc_work@mail.ru
State Accepted
Commit 7b8751abdd34a2f924c37c29ad61d598f5d29e7b
Headers show

Commit Message

Alexander Shiyan May 23, 2014, 11:11 a.m. UTC
Eukrea-i.MX51 board was converted to use DT, ie we no longer have a
MACH_EUKREA_MBIMXSD51_BASEBOARD symbol.
Transformation of other boards planned for the near future, so this
patch removes all these dependencies and restricts build of this
driver to ARCH_MXC.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 sound/soc/fsl/Kconfig | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Mark Brown May 23, 2014, 11:24 a.m. UTC | #1
On Fri, May 23, 2014 at 03:11:01PM +0400, Alexander Shiyan wrote:
> Eukrea-i.MX51 board was converted to use DT, ie we no longer have a
> MACH_EUKREA_MBIMXSD51_BASEBOARD symbol.
> Transformation of other boards planned for the near future, so this
> patch removes all these dependencies and restricts build of this
> driver to ARCH_MXC.

Does it actually depend on ARCH_MXC or can we also enable build with
COMPILE_TEST now everything is DT converted?  Looking at the code
there's a lot of machine_is_ checks in there so it's not clear that this
will work well on DT...
Mark Brown May 23, 2014, 4:09 p.m. UTC | #2
On Fri, May 23, 2014 at 07:19:27PM +0400, Alexander Shiyan wrote:

> Yes, now I see.
> So on my opinion the true method is transform this board (for DT case) is
> to use generic sound card. In this patch , I just try to remove non-existent
> symbol dependencies, so if we have is_machine_xx checks I do not know
> the true way, since cannot test this.

Yes, transitioning to simple-card would be ideal if you can do that.  I
guess we can apply this one for now since it doesn't make things any
worse at least.
Mark Brown June 1, 2014, 11 a.m. UTC | #3
On Fri, May 23, 2014 at 03:11:01PM +0400, Alexander Shiyan wrote:
> Eukrea-i.MX51 board was converted to use DT, ie we no longer have a
> MACH_EUKREA_MBIMXSD51_BASEBOARD symbol.
> Transformation of other boards planned for the near future, so this
> patch removes all these dependencies and restricts build of this
> driver to ARCH_MXC.

Applied, thanks.

Patch
diff mbox

diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index d262ec0..2989319 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -207,12 +207,7 @@  config SND_SOC_PHYCORE_AC97
 
 config SND_SOC_EUKREA_TLV320
 	tristate "Eukrea TLV320"
-	depends on MACH_EUKREA_MBIMX27_BASEBOARD \
-		|| MACH_EUKREA_MBIMXSD25_BASEBOARD \
-		|| MACH_EUKREA_MBIMXSD35_BASEBOARD \
-		|| MACH_EUKREA_MBIMXSD51_BASEBOARD \
-		|| (OF && ARM)
-	depends on I2C
+	depends on ARCH_MXC && I2C
 	select SND_SOC_TLV320AIC23_I2C
 	select SND_SOC_IMX_AUDMUX
 	select SND_SOC_IMX_SSI