Makefile: Fix size_append issue for bzip2/lzma kernel
diff mbox

Message ID 20090819173854.2250758f@dxy.sh.intel.com
State New, archived
Headers show

Commit Message

Du, Alek Aug. 19, 2009, 9:38 a.m. UTC
From 6d755cbd7a136a4314f6976275aaa6c9d10bf3e4 Mon Sep 17 00:00:00 2001
From: Alek Du <alek.du@intel.com>
Date: Wed, 19 Aug 2009 17:18:39 +0800
Subject: [PATCH] Makefile: Fix size_append issue for bzip2/lzma kernel

The Makefile.lib will call "echo -ne" to append uncompressed kernel size to
bzip2/lzma kernel image. The "echo" here depends on the shell that /bin/sh pointing
to. On Ubuntu system, the /bin/sh is pointing to dash, which does not support
"echo -e" at all. Use /bin/echo instead of shell echo should always be safe.

Signed-off-by: Alek Du <alek.du@intel.com>
---
 scripts/Makefile.lib |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Cong Wang Aug. 19, 2009, 9:52 a.m. UTC | #1
On Wed, Aug 19, 2009 at 05:38:54PM +0800, Alek Du wrote:
>From 6d755cbd7a136a4314f6976275aaa6c9d10bf3e4 Mon Sep 17 00:00:00 2001
>From: Alek Du <alek.du@intel.com>
>Date: Wed, 19 Aug 2009 17:18:39 +0800
>Subject: [PATCH] Makefile: Fix size_append issue for bzip2/lzma kernel
>
>The Makefile.lib will call "echo -ne" to append uncompressed kernel size to
>bzip2/lzma kernel image. The "echo" here depends on the shell that /bin/sh pointing
>to. On Ubuntu system, the /bin/sh is pointing to dash, which does not support
>"echo -e" at all. Use /bin/echo instead of shell echo should always be safe.
>
>Signed-off-by: Alek Du <alek.du@intel.com>

Agree.

Acked-by: WANG Cong <xiyou.wangcong@gmail.com>


>---
> scripts/Makefile.lib |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
>index 7a77787..c63c941 100644
>--- a/scripts/Makefile.lib
>+++ b/scripts/Makefile.lib
>@@ -208,7 +208,7 @@ cmd_gzip = (cat $(filter-out FORCE,$^) | gzip -f -9 > $@) || \
> 
> # Bzip2 and LZMA do not include size in file... so we have to fake that;
> # append the size as a 32-bit littleendian number as gzip does.
>-size_append = echo -ne $(shell						\
>+size_append = /bin/echo -ne $(shell						\
> dec_size=0;								\
> for F in $1; do								\
> 	fsize=$$(stat -c "%s" $$F);					\
>-- 
>1.6.0.4
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 7a77787..c63c941 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -208,7 +208,7 @@  cmd_gzip = (cat $(filter-out FORCE,$^) | gzip -f -9 > $@) || \
 
 # Bzip2 and LZMA do not include size in file... so we have to fake that;
 # append the size as a 32-bit littleendian number as gzip does.
-size_append = echo -ne $(shell						\
+size_append = /bin/echo -ne $(shell						\
 dec_size=0;								\
 for F in $1; do								\
 	fsize=$$(stat -c "%s" $$F);					\