From patchwork Wed Aug 19 09:38:54 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Du, Alek" X-Patchwork-Id: 42555 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n7J9eCaw000530 for ; Wed, 19 Aug 2009 09:40:13 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751667AbZHSJj1 (ORCPT ); Wed, 19 Aug 2009 05:39:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751656AbZHSJjZ (ORCPT ); Wed, 19 Aug 2009 05:39:25 -0400 Received: from mga09.intel.com ([134.134.136.24]:54910 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751275AbZHSJjX convert rfc822-to-8bit (ORCPT ); Wed, 19 Aug 2009 05:39:23 -0400 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 19 Aug 2009 02:25:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.43,407,1246863600"; d="scan'208,223";a="542789975" Received: from pgsmsx601.gar.corp.intel.com ([10.221.43.69]) by orsmga001.jf.intel.com with ESMTP; 19 Aug 2009 02:38:51 -0700 Received: from pdsmsx602.ccr.corp.intel.com (172.16.12.184) by pgsmsx601.gar.corp.intel.com (10.221.43.69) with Microsoft SMTP Server (TLS) id 8.1.358.0; Wed, 19 Aug 2009 17:39:23 +0800 Received: from dxy.sh.intel.com (10.239.36.123) by pdsmsx602.ccr.corp.intel.com (172.16.12.184) with Microsoft SMTP Server (TLS) id 8.1.358.0; Wed, 19 Aug 2009 17:39:21 +0800 Date: Wed, 19 Aug 2009 17:38:54 +0800 From: Alek Du To: Kernel Mailing List , , Sam Ravnborg Subject: [PATCH] Makefile: Fix size_append issue for bzip2/lzma kernel Message-ID: <20090819173854.2250758f@dxy.sh.intel.com> Organization: Intel Corp. X-Mailer: Claws Mail 3.6.1 (GTK+ 2.16.1; i486-pc-linux-gnu) MIME-Version: 1.0 Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org From 6d755cbd7a136a4314f6976275aaa6c9d10bf3e4 Mon Sep 17 00:00:00 2001 From: Alek Du Date: Wed, 19 Aug 2009 17:18:39 +0800 Subject: [PATCH] Makefile: Fix size_append issue for bzip2/lzma kernel The Makefile.lib will call "echo -ne" to append uncompressed kernel size to bzip2/lzma kernel image. The "echo" here depends on the shell that /bin/sh pointing to. On Ubuntu system, the /bin/sh is pointing to dash, which does not support "echo -e" at all. Use /bin/echo instead of shell echo should always be safe. Signed-off-by: Alek Du Acked-by: WANG Cong --- scripts/Makefile.lib | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 7a77787..c63c941 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -208,7 +208,7 @@ cmd_gzip = (cat $(filter-out FORCE,$^) | gzip -f -9 > $@) || \ # Bzip2 and LZMA do not include size in file... so we have to fake that; # append the size as a 32-bit littleendian number as gzip does. -size_append = echo -ne $(shell \ +size_append = /bin/echo -ne $(shell \ dec_size=0; \ for F in $1; do \ fsize=$$(stat -c "%s" $$F); \