From patchwork Thu May 29 07:59:17 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hui Wang X-Patchwork-Id: 4262721 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 3D9EF9F1E7 for ; Thu, 29 May 2014 08:00:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6F77B202F8 for ; Thu, 29 May 2014 08:00:28 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id C025F2034E for ; Thu, 29 May 2014 08:00:26 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 2AC622610A1; Thu, 29 May 2014 10:00:25 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 734A2260845; Thu, 29 May 2014 09:59:46 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 06B96260815; Thu, 29 May 2014 09:59:42 +0200 (CEST) Received: from mail-pb0-f51.google.com (mail-pb0-f51.google.com [209.85.160.51]) by alsa0.perex.cz (Postfix) with ESMTP id B4C29260799 for ; Thu, 29 May 2014 09:59:30 +0200 (CEST) Received: by mail-pb0-f51.google.com with SMTP id ma3so12549660pbc.24 for ; Thu, 29 May 2014 00:59:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=nTnJQ/5CA4iKAVL1iZ22NQUjatDXzs9L6uK37CcIuwU=; b=cdM2Y2t9YEQf6XInUjsbdxxiJtImQ9OFMWZ3iMYN58xde0acc5z/gI0TgdWC0hHEi6 BW0wAjxT/K2LBHdOC2dlEBmUcrmvsCu2XWXr/xLrwW8p5cRBSGw74RoInQPzRfi0J5R8 hWeq81SRSPTxkbDk+q8BgDe1s70YzxtUHy1o0hKyVOAL1Yk/uRk/k5aombMBwLydMihw HkXyKBe30pv4twNfD5QmYgGgNXD2hXz/kXNnJxd2H44mNXIKyES66+68RcF1k31KDX0k pBwC7ZnEobUjrdcUWui7CJ0f0E0WrI9nHr8CvHDQH9WUayYf0R9OC/CMIZrYQtaLzp3a fjYQ== X-Gm-Message-State: ALoCoQmDsH9QbEDnjctAgdqhPuJplRk9Dw3fgK9/U4y8Vg439QN3zg6UwB/PVGeyontVwVp1m3bF X-Received: by 10.66.183.11 with SMTP id ei11mr6604486pac.116.1401350368840; Thu, 29 May 2014 00:59:28 -0700 (PDT) Received: from hwang4-Inspiron-7520.lan ([23.228.209.28]) by mx.google.com with ESMTPSA id is5sm32065850pbb.8.2014.05.29.00.59.25 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 29 May 2014 00:59:28 -0700 (PDT) From: Hui Wang To: tiwai@suse.de, alsa-devel@alsa-project.org Date: Thu, 29 May 2014 15:59:17 +0800 Message-Id: <1401350359-5045-1-git-send-email-hui.wang@canonical.com> X-Mailer: git-send-email 1.8.1.2 Cc: hui.wang@canonical.com, david.henningsson@canonical.com Subject: [alsa-devel] [PATCH 1/3] Revert "ALSA: hda - drop def association and sequence from pinconf comparing" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP This reverts commit c687200b9d4ef60042a50f7d942cfef120cc7bf1. Dropping the def association and sequence from pinconf comparing is a bit risky, It will introduce a greater risk of catching unwanted machines. And in addition, so far no BIOS experts give us an explicit answer whether it makes senses to compare these two fields or not. For safety reason, we revert this commit. Signed-off-by: Hui Wang --- This is the first attempt to move existing machines from old quirk table to hda_pin_quirk table. During the working, I met serveral cases that the same codec has different default pin conf value just because of default association difference, Please see the following two patches (0x10ec0255 and 0x10ec0668). sound/pci/hda/hda_auto_parser.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/pci/hda/hda_auto_parser.c b/sound/pci/hda/hda_auto_parser.c index 3cf9137..b684c6e 100644 --- a/sound/pci/hda/hda_auto_parser.c +++ b/sound/pci/hda/hda_auto_parser.c @@ -844,8 +844,7 @@ static bool pin_config_match(struct hda_codec *codec, { for (; pins->nid; pins++) { u32 def_conf = snd_hda_codec_get_pincfg(codec, pins->nid); - u32 mask = 0xffffff00; - if ((pins->val & mask) != (def_conf & mask)) + if (pins->val != def_conf) return false; } return true;